Refine BridgeGpio object creation logic

This commit refines BridgeGpio object creation logic by using explicit
std::move to prevent object copy. Also, for cases of rescanning of
ADCSensors, it adjus

Refine BridgeGpio object creation logic

This commit refines BridgeGpio object creation logic by using explicit
std::move to prevent object copy. Also, for cases of rescanning of
ADCSensors, it adjusts timing of destroying for the previous ADCSensor
to avoid double request of a gpio line.

Tested: adcsensor service was started without making a below error
even in case of a recreation sensors caused by rescanning:
Error requesting gpio: P3VBAT_BRIDGE_EN
terminate called after throwing an instance of 'std::system_error'
what(): error setting GPIO line values: Operation not permitted

Change-Id: I26ca059f8fe6eea2c60605f19ec49a3e365dc66f
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

show more ...

PSUSensor: Change ScaleFactor label

Changed ScaleFactor label to UpperCamelCase type.

Test: Verified with config change.

Change-Id: Ieff3a0b9a4b71fc8c0e52d9e1c4ac873c2affa78
Signed-off-by: Vijay K

PSUSensor: Change ScaleFactor label

Changed ScaleFactor label to UpperCamelCase type.

Test: Verified with config change.

Change-Id: Ieff3a0b9a4b71fc8c0e52d9e1c4ac873c2affa78
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

show more ...

PSUSensor: Add INA230 sensor

Added ina230 support.

Tested: Verified result for ina230 device.

Change-Id: Ibc86765c8dd997b91788e2df8aa73d12e1dd8ca1
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

PSUSensor: Add ScaleFactor

Added support for ScaleFactor for each sensor subtype like
temp, volt, power and current. And it can be defined as
tempScaleFactor for temp, inScaleFactor for voltage,
pow

PSUSensor: Add ScaleFactor

Added support for ScaleFactor for each sensor subtype like
temp, volt, power and current. And it can be defined as
tempScaleFactor for temp, inScaleFactor for voltage,
powerScaleFactor for power and currScaleFactor for
current.

Tested with modified configuration in entity manager.

Change-Id: Ib03510c310f864b02baff2b62e7ffe85230e52fc
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

show more ...

IpmbSensor: Add support for HSC sensor

1. Added support for HSC ADM1278 type sensors.
2. Added a subType as temp, volt, curr and power with default
subtype as temperature.
3. Added support for Sc

IpmbSensor: Add support for HSC sensor

1. Added support for HSC ADM1278 type sensors.
2. Added a subType as temp, volt, curr and power with default
subtype as temperature.
3. Added support for Scale and offset with default value as
scale = 1 and offset = 0.

Tested sensors with config file update.

Change-Id: If8c6b931bc9a27fabe4991ffce44b1a2545195ea
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

show more ...

adcsensor: improve bridge gpio handling

This commit improves bridge gpio handling using name based gpio line
access and polarity setting support.

Tested: P3VBAT sensor reading worked correctly.

Ch

adcsensor: improve bridge gpio handling

This commit improves bridge gpio handling using name based gpio line
access and polarity setting support.

Tested: P3VBAT sensor reading worked correctly.

Change-Id: Iff174c52dba90cc068f4b5e527d4ab1c381817d0
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

show more ...

Trigger Redfish Log in PSU Event

When PSU Event is asserted, trigger Redfish Log.

Tested:
Plug out AC cable on PSU2, we can see below in Redfish Log Entries.
{

"@odata.context": "/redfish/v1/$

Trigger Redfish Log in PSU Event

When PSU Event is asserted, trigger Redfish Log.

Tested:
Plug out AC cable on PSU2, we can see below in Redfish Log Entries.
{

"@odata.context": "/redfish/v1/$metadata#LogEntry.LogEntry",
data.context": "/redfish/v1/$metadata#LogEntry.LogEntry",
"@odata.id": "/redfish/v1/Systems/system/LogServices/EventLog/
Entries/#1562158096",
"@odata.type": "#LogEntry.v1_4_0.LogEntry",
"Created": "2019-07-03T12:48:16+00:00",
"EntryType": "Event",
"Id": "1562158096",
"Message": "Power supply PSU2 AC power lost.",
"MessageArgs": [
"PSU2"
],
"MessageId": "OpenBMC.0.1.PowerSupplyACLost",
"Name": "System Event Log Entry",
"Severity": "Critical"
},

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: I406dbf2047e82ccf523dcea91dce48600341aaee

show more ...

Turn on a bunch of warnings

Turn on as many warnings as easily possible from:
https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md

Turn on a bunch of warnings

Turn on as many warnings as easily possible from:
https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md#L100

Tested:
ipmitool sensor list still works

Change-Id: Ied8fa66de9fcd25e448f8048c4f8216b426b6f55
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

psusensor: Add support for ina219

Added support for ina219 type sensors.

Also fixed issue if there is no label exposed by driver then
sensors will have default label. Added default label in table.

psusensor: Add support for ina219

Added support for ina219 type sensors.

Also fixed issue if there is no label exposed by driver then
sensors will have default label. Added default label in table.

Tested output with ina219 sensors.

Change-Id: Ic100e5d82ec0b07356c1f25e6a952861a598149b
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

show more ...

Revert "Fix CPU detection GPIO handling logic"

This reverts commit be73e6a4d11f6c9f6f6887918404901cd87386b8.

The new SGPIO driver has a critical bug so the driver will be replaced
with old version.

Revert "Fix CPU detection GPIO handling logic"

This reverts commit be73e6a4d11f6c9f6f6887918404901cd87386b8.

The new SGPIO driver has a critical bug so the driver will be replaced
with old version. This commit is for following up of the change.

Change-Id: Ia9cc430b6fd519e3565621c31e6905667d048945
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

show more ...

Update Associations For bmcweb changes

Updating according to
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/22976

Tested: Thermal had all fans, and presence worked.

Change-Id: I03e1e13b3a9c2f

Update Associations For bmcweb changes

Updating according to
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/22976

Tested: Thermal had all fans, and presence worked.

Change-Id: I03e1e13b3a9c2f6d2ac4b7afc6e2723c04597931
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Fix Threshold Parse

We agreed on using Label field, so not having thresholds
should be ok.

Tested: PSU1&2 fanspeeds are back

Change-Id: I99b27300a6ee3ebb92b637297adbcc058c6b223b
Signed-off-by: Jam

Fix Threshold Parse

We agreed on using Label field, so not having thresholds
should be ok.

Tested: PSU1&2 fanspeeds are back

Change-Id: I99b27300a6ee3ebb92b637297adbcc058c6b223b
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add support for more PSU sensors

Added support for extra sensors named as Name1, Name2 etc.
Added vout1 and other labels upto 3 sensors under single
bus interface.

Added labels array enabling throu

Add support for more PSU sensors

Added support for extra sensors named as Name1, Name2 etc.
Added vout1 and other labels upto 3 sensors under single
bus interface.

Added labels array enabling through config file for exposing
only sensors defined as labels in array. If no array is
defined then all sensors will be created in dbus.

Tested output with multiple sensors.

Change-Id: Ic2c4a3feffad90355444e6b9a2e456731213d94b
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

show more ...

Support temp sensor on MCU which is available from I2C

Chassis MCU exposes register to report temperature for the peripheral board.
The MCU access is configurable as below:
{
"Bu

Support temp sensor on MCU which is available from I2C

Chassis MCU exposes register to report temperature for the peripheral board.
The MCU access is configurable as below:
{
"Bus": $bus,
"Address": "0xAA",
"Reg": "0xBB",
"Class": "MCUTemp",
"Name": "MCU Temp",
"Thresholds": [
xxx
]
"Type": "MCUTempSensor"
}

Tested:
The below interface was found under temperature sensor namespace:
└─/xyz/openbmc_project/sensors/temperature/MCU_Temp

Run ipmitool sensor and check below from list:
MCU Temp | 30.175 | degrees C | cr | na | 0.000 | 5.000 | 110.000 | 115.000 | na

Change-Id: I8d54455ccc39ea4f60a5b4aee5c68be092d39a72
Signed-off-by: Yuan Li <yuan.li@linux.intel.com>

show more ...

Fix CPU detection GPIO handling logic

This commit fixes CPU detection GPIO handling logic to support
the latest kernel SGPIO driver which creates a single gpiochip cdev
entry, /dev/gpiochip1.

Chang

Fix CPU detection GPIO handling logic

This commit fixes CPU detection GPIO handling logic to support
the latest kernel SGPIO driver which creates a single gpiochip cdev
entry, /dev/gpiochip1.

Change-Id: I386d3d6831b55d553635e71900299bd840f57906
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

show more ...

Change power control match to use host state

Lower level signals were removed, use host state instead.
Also fix bug that was introduced, std::abs(nan, number)
returns nan, so checkThresholds wasn't

Change power control match to use host state

Lower level signals were removed, use host state instead.
Also fix bug that was introduced, std::abs(nan, number)
returns nan, so checkThresholds wasn't being called.

Tested: Put in prints and saw power/post state change to on

Change-Id: I98df270237900c3a0b01c03ec7905851bc47e3b3
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Correct association of PSU PWM Sensor

Correct association of PSU PWM Sensor which can make redfish get correct PSU
PWM Fan sensors in Thermal/Fans entries.

Tested:
Insert one 1100W PSU and check We

Correct association of PSU PWM Sensor

Correct association of PSU PWM Sensor which can make redfish get correct PSU
PWM Fan sensors in Thermal/Fans entries.

Tested:
Insert one 1100W PSU and check Web redfish page, below entry can be found.
https://ip/redfish/v1/Chassis/Flextronics_S_1100ADU00_201_PSU_1/Thermal
"@odata.id": "/redfish/v1/Chassis/Flextronics_S_1100ADU00_201_PSU_1/Thermal#/
Fans/1",
"@odata.type": "#Thermal.v1_3_0.Fan",
"MaxReadingRange": 100,
"MemberId": "Pwm_PSU1_Fan_1",
"MinReadingRange": 0,
"Name": "Pwm PSU1 Fan 1",
"Reading": 29,
"ReadingUnits": "Percent",
"Status": {
"Health": "OK",
"State": "Enabled"
}

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: I8f068ef3e5bd246a2432e180b1c86dbd6b0bad97

show more ...

cpusensor: Add thresold offset

Added DTS critical offset parameter to change critical thresold
value of DTS sensors.

Tested by setting value in entity manager and seeing output
reflect in dbus inte

cpusensor: Add thresold offset

Added DTS critical offset parameter to change critical thresold
value of DTS sensors.

Tested by setting value in entity manager and seeing output
reflect in dbus interface.

Change-Id: Ib819d20322b7eca5f6e8690827bf97d49695e995
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

show more ...

Add Hysteresis support

This adds a hysteresis to each sensor that is 1% of
the range of the sensor.

Change-Id: I0c8606e61d1aca3582d1f6882be5da1bf2884cd9
Signed-off-by: James Feist <james.feist@linu

Add Hysteresis support

This adds a hysteresis to each sensor that is 1% of
the range of the sensor.

Change-Id: I0c8606e61d1aca3582d1f6882be5da1bf2884cd9
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Follow up on Todo, move path out of base sensor

Not every sensor needs a sysfs path, because of that
move it out of the base class and into the classes that
need it.

Change-Id: I62b7df681e1ee889eb6

Follow up on Todo, move path out of base sensor

Not every sensor needs a sysfs path, because of that
move it out of the base class and into the classes that
need it.

Change-Id: I62b7df681e1ee889eb66e371d1cd6094097e9f21
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

adcsensor: Add CPU presence checking

This adds a match to catch cpu presence coming from
cpusensor.

Tested: ipmitool sensor list no longer showed ADCs that
monitored unavailable CPU

Change-Id: I3

adcsensor: Add CPU presence checking

This adds a match to catch cpu presence coming from
cpusensor.

Tested: ipmitool sensor list no longer showed ADCs that
monitored unavailable CPU

Change-Id: I39c067e5da3565c5b229cc19ed4ccf7767c1e85c
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

cpusensor: detect if cpu is available

Add CPU inventory item detection via gpio.

Tested: inventory item is exposed

Change-Id: Ia26a4bed5534edec6a7f5c7cf0965f84fa0fc23a
Signed-off-by: James Feist <

cpusensor: detect if cpu is available

Add CPU inventory item detection via gpio.

Tested: inventory item is exposed

Change-Id: Ia26a4bed5534edec6a7f5c7cf0965f84fa0fc23a
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Implement PSU Event

Expose PSU Event AC Lost, Fan Fault, Failure, Predictive D-Bus interface.
Read alarm and max_alarm, min_alarm, crit_alarm, lcrit_alarm and
assert or deassert the related properti

Implement PSU Event

Expose PSU Event AC Lost, Fan Fault, Failure, Predictive D-Bus interface.
Read alarm and max_alarm, min_alarm, crit_alarm, lcrit_alarm and
assert or deassert the related properties on PSU Event.

Tested By:
After run /usr/sbin/psusensor below D-Bus interface are exposed
/xyz/openbmc_project/State/Decorator/PSU1_OperationalStatus
/xyz/openbmc_project/State/Decorator/PSU2_OperationalStatus
After plugging out AC cable from PSU1, the functional property in
PSU1_OperationalStatus changes to "false" from "true".
After plugging in AC cable again, the property changes back to "true".

Change-Id: Ic21513471c4632835c39148ea313808fdcc816fa
Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>

show more ...

Add logging for Fan Presence / Redundancy

Add logging and fix bug with shared_ptr usage. We
now use a std::optional * to the shared redundancy
object, so that it can 1. point to object / null and 2.

Add logging for Fan Presence / Redundancy

Add logging and fix bug with shared_ptr usage. We
now use a std::optional * to the shared redundancy
object, so that it can 1. point to object / null and 2.
exist in config or not.

Tested: cat /var/log/redfish to see logs made by removing
and adding fans, and using sensor override to change
redundancy.

Change-Id: Ic4b319cf7484cbbd7ce7dbdf7556f48bebe11cb0
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Change PSU Fan Maximum Value

Normally, PSU Fan can reach to 25000RPM, so change the maximum value
of PSU Fan to 30000.

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: I0954d66

Change PSU Fan Maximum Value

Normally, PSU Fan can reach to 25000RPM, so change the maximum value
of PSU Fan to 30000.

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: I0954d665720218301ba808752a28809c5be37f6b

show more ...