Enable misc-include-cleaner

Change-Id: I22099a0f95b2eb884dec7d95cee0bdd0c159fd1f
Signed-off-by: Ed Tanous <ed@tanous.net>

Enable cppcoreguidelines-rvalue-reference-param-not-moved

and fix the one failure.

Change-Id: I62ddb9e3520b4f16331f605441740da5831ade51
Signed-off-by: Ed Tanous <ed@tanous.net>

psusensor: Fix memory leak

Remove the psuProperties vector since older params are not being used.
Use a temp copy of the psuProperty for customization per label match.
This change fix the memory lea

psusensor: Fix memory leak

Remove the psuProperties vector since older params are not being used.
Use a temp copy of the psuProperty for customization per label match.
This change fix the memory leak when createSensors is called
repeatedly.

Tested:
Memory stay stable with overnight cold reset test.

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: If4ec633fd533fdb90c7fc9f655e82bef2616e3f3

show more ...

Enable readability-container-data-pointer

Clang tidy check, and fix the one case.

Change-Id: I0935eb6403fd3b2e1a66d9e097febd292f61d70d
Signed-off-by: Ed Tanous <ed@tanous.net>

Add bugprone-optional-value-conversion

And fix the one case.

Change-Id: Iaaedf56b12cae38583ae82017ebea8bfe8987689
Signed-off-by: Ed Tanous <ed@tanous.net>

Fix readability-redundant-member-init

Clang-tidy-18 flags one new instance.

Change-Id: I43334b200b47dd1737ac9af9e56bd10be690cf36
Signed-off-by: Ed Tanous <ed@tanous.net>

Enable bugprone-unused-local-non-trivial-variable

And fix the two problems.

Change-Id: Ib91625d66e42fe8b14aaf1ef33761f9084564de9
Signed-off-by: Ed Tanous <ed@tanous.net>

Enable bugprone-assignment-in-if-condition

And fix the one violation.

Change-Id: I8b844d0e987827527c82e3351efd40c1bfd692db
Signed-off-by: Ed Tanous <ed@tanous.net>

Add modernize-redundant-void-arg

Enable this check and fix the failures.

Change-Id: I89b13daf1161be40564367562bb9c8c0c459e1d0
Signed-off-by: Ed Tanous <ed@tanous.net>

add hysteresis param to parseThresholdsFromAttr()

Parameter 'hysteresis' with a default = NaN, is added to the header for
parseThresholdsFromAttr(), and existing calls to it now explicitly
specify a

add hysteresis param to parseThresholdsFromAttr()

Parameter 'hysteresis' with a default = NaN, is added to the header for
parseThresholdsFromAttr(), and existing calls to it now explicitly
specify a hysteresis value.

This is an alternative to having calls to parseThresholdFromAttr() use
a hardcoded Intel-specific value of '0.'

The 'NaN' value was chosen as default because it reflects the value
that was being written before a device-specific value was hardcoded in
to solve a specific issue.

Change was created based on the discussion here:
https://gerrit.openbmc.org/c/openbmc/dbus-sensors/+/61744/comments/38f6a
221_58a39817a

Tested: Confirmed the code builds and doesn't throw errors with OBMC
'local CI' testing. I believe heavier testing with actual Intel HW
isn't needed because this change simple moves where a value is specified
(from hardcode in function body to passed-in parameter) without
affecting any existing in-use functionality.

Change-Id: I1240b951d6e37adc1aad5ad3b19144f6baa64998
Signed-off-by: Chris Sides <christopher.sides@hpe.com>

show more ...

PSUSensor: add sbrmi support

Add device sbrmi for power reading support.

Test result:
- check sensor creation
```
root@bmc:~# busctl tree xyz.openbmc_project.PSUSensor |grep SBRMI
| `- /xyz/o

PSUSensor: add sbrmi support

Add device sbrmi for power reading support.

Test result:
- check sensor creation
```
root@bmc:~# busctl tree xyz.openbmc_project.PSUSensor |grep SBRMI
| `- /xyz/openbmc_project/State/Decorator/SBRMI_OperationalStatus
`- /xyz/openbmc_project/sensors/power/SBRMI_Output_Power
```

Change-Id: I4a86071e4bf01ccd473441d395221f565bb15519
Signed-off-by: Cosmo Chou <cosmo.chou@quantatw.com>

show more ...

HwmonTempSensor: Add support for PT5161L

Add support for PT5161L temperature sensor.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?h=hwmon-next&id=1b2ca93cd05

HwmonTempSensor: Add support for PT5161L

Add support for PT5161L temperature sensor.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?h=hwmon-next&id=1b2ca93cd0592b1fcbc6f8b64e02552bc15f4bb4

Tested Result:
- MB_RETIMER0_TEMP_C sensor config from harma_mb.json
```
{
"Address": "0x24",
"Bus": 12,
"Name": "MB_RETIMER0_TEMP_C",
"PowerState": "On",
"Thresholds": [
{
"Direction": "greater than",
"Name": "upper critical",
"Severity": 1,
"Value": 107
},
{
"Direction": "greater than",
"Name": "upper non critical",
"Severity": 0,
"Value": 105
},
{
"Direction": "less than",
"Name": "lower non critical",
"Severity": 0,
"Value": 5
},
{
"Direction": "less than",
"Name": "lower critical",
"Severity": 1,
"Value": -7
}
],
"Type": "PT5161L"
}
```

- MB_RETIMER0_TEMP_C sensor reading
```
root@bmc:~# busctl introspect xyz.openbmc_project.HwmonTempSensor /xyz/openbmc_project/sensors/temperature/MB_RETIMER0_TEMP_C
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Association.Definitions interface - - -
.Associations property a(sss) 1 "chassis" "all_sensors" "/xyz/openbmc… emits-change
xyz.openbmc_project.Sensor.Threshold.Critical interface - - -
.CriticalAlarmHigh property b false emits-change
.CriticalAlarmLow property b false emits-change
.CriticalHigh property d 107 emits-change writable
.CriticalLow property d -7 emits-change writable
xyz.openbmc_project.Sensor.Threshold.Warning interface - - -
.WarningAlarmHigh property b false emits-change
.WarningAlarmLow property b false emits-change
.WarningHigh property d 105 emits-change writable
.WarningLow property d 5 emits-change writable
xyz.openbmc_project.Sensor.Value interface - - -
.MaxValue property d 127 emits-change
.MinValue property d -128 emits-change
.Unit property s "xyz.openbmc_project.Sensor.Value.Unit.… emits-change
.Value property d 55.6 emits-change writable
xyz.openbmc_project.State.Decorator.Availability interface - - -
.Available property b true emits-change writable
xyz.openbmc_project.State.Decorator.OperationalStatus interface - - -
.Functional property b true emits-change
```

Change-Id: Ie0e7e9603c2e201a06a64de7c265500b73b5156d
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

PSUSensor: add ltc4286/ltc4287 support

Add device ltc4286/ltc4287 reading support.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/drivers/hwmon/pmbus/ltc4286.c?

PSUSensor: add ltc4286/ltc4287 support

Add device ltc4286/ltc4287 reading support.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/drivers/hwmon/pmbus/ltc4286.c?id=0c459759ca971ee49a313b19ba50fc499c6cf8ca

Test result:
- check sensors creation of CMM_HSC device config from minerva_cmm.json
```
root@bmc:~# busctl tree xyz.openbmc_project.PSUSensor | grep CMM_HSC
│ ├─ /xyz/openbmc_project/State/Decorator/CMM_HSC_OperationalStatus
│ ├─ /xyz/openbmc_project/sensors/current/CMM_HSC_CURR_A
│ ├─ /xyz/openbmc_project/sensors/power/CMM_HSC_PWR_W
├─ /xyz/openbmc_project/sensors/voltage/CMM_HSC_VIN_VOLT_V
├─ /xyz/openbmc_project/sensors/voltage/CMM_HSC_VOUT_VOLT_V
```

Change-Id: I945a26ea1ee98cb0ccd9978c2f43d729a9d4cdeb
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

meson: remove Boost TS executors

BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT enables the older Networking TS
executors instead of the newer "Standard Executors" and is not
necessary for io_uring. Remove

meson: remove Boost TS executors

BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT enables the older Networking TS
executors instead of the newer "Standard Executors" and is not
necessary for io_uring. Remove this option to use the newer execution
model.

Tested:

Confirmed the io_uring interfaces are still being used.
```
(gdb) bt
#0 0x00007ffff7dfba47 in ?? () from /usr/lib64/liburing.so.2
#1 0x00007ffff7dfbca2 in __io_uring_get_cqe () from /usr/lib64/liburing.so.2
#2 0x000055555556dd72 in io_uring_wait_cqe_nr (ring=0x555555807c30, cqe_ptr=0x7fffffffd9f0, wait_nr=1)
at /usr/include/liburing.h:1175
#3 0x000055555556df08 in io_uring_wait_cqe (ring=0x555555807c30, cqe_ptr=0x7fffffffd9f0)
at /usr/include/liburing.h:1248
#4 0x000055555557ff4f in boost::asio::detail::io_uring_service::run (this=0x555555807bf0, usec=-1, ops=...)
at ../subprojects/boost_1_83_0/boost/asio/detail/impl/io_uring_service.ipp:437
#5 0x000055555557e7a4 in boost::asio::detail::scheduler::do_run_one (this=0x555555806020, lock=...,
this_thread=..., ec=...) at ../subprojects/boost_1_83_0/boost/asio/detail/impl/scheduler.ipp:477
#6 0x000055555557e27a in boost::asio::detail::scheduler::run (this=0x555555806020, ec=...)
at ../subprojects/boost_1_83_0/boost/asio/detail/impl/scheduler.ipp:210
#7 0x0000555555581725 in boost::asio::io_context::run (this=0x7fffffffdc90)
at ../subprojects/boost_1_83_0/boost/asio/impl/io_context.ipp:64
#8 0x0000555555573af0 in main () at ../src/HwmonTempMain.cpp:643
```

Ran QEMU for Bletchley and observed HwmonTempSensor still works:
```
root@bletchley:~# busctl introspect xyz.openbmc_project.HwmonTempSensor /xyz/openbmc_project/sensors/temperature/SLED1_THERM_LOCAL xyz.openbmc_project.Sensor.Value
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.MaxValue property d 127 emits-change
.MinValue property d -128 emits-change
.Unit property s "xyz.openbmc_project.Sensor.Value.Uni... emits-change
.Value property d 0 emits-change writable
```

Checking strace yields lots of io_uring related calls:
```
root@bletchley:~# strace -p 960
strace: Process 960 attached
io_uring_enter(4, 0, 1, IORING_ENTER_GETEVENTS, NULL, 8) = 0
clock_gettime64(CLOCK_MONOTONIC, {tv_sec=240, tv_nsec=810659232}) = 0
clock_gettime64(CLOCK_MONOTONIC, {tv_sec=240, tv_nsec=813407042}) = 0
io_uring_enter(4, 2, 0, 0, NULL, 8) = 2
clock_gettime64(CLOCK_MONOTONIC, {tv_sec=240, tv_nsec=816897328}) = 0
io_uring_enter(4, 0, 1, IORING_ENTER_GETEVENTS, NULL, 8) = 0
clock_gettime64(CLOCK_MONOTONIC, {tv_sec=240, tv_nsec=822788059}) = 0
clock_gettime64(CLOCK_MONOTONIC, {tv_sec=240, tv_nsec=824535222}) = 0
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0eb1d732a9bc3bb25e625b9f8fe3eeeaf8ae3143

show more ...

State.Chassis: update service name

Both phosphor-state-manager and x86-power-control have code that exposes
both the Chassis and Chassis0 bus names as a backwards compatibility
when multi-chassis su

State.Chassis: update service name

Both phosphor-state-manager and x86-power-control have code that exposes
both the Chassis and Chassis0 bus names as a backwards compatibility
when multi-chassis support was added. Switch to the numbered bus name,
which is expected to be the non-deprecated one.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0aeefc5d00cfd1fbb1c53f35fc2d2f067d97f11b

show more ...

Utils: Remove unused getSensorConfiguration method

Since dbus sensor only uses the getSensorConfiguration method with the
`useCache` parameter, this patch removes the getSensorConfiguration
method t

Utils: Remove unused getSensorConfiguration method

Since dbus sensor only uses the getSensorConfiguration method with the
`useCache` parameter, this patch removes the getSensorConfiguration
method that does not use the `useCache` parameter.

Tested: built dbus-sensors successfully and it works fine with this
patch.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I1730df517e115de0625cfcca561f08af1d053b46

show more ...

adcsensor: add some documentation

Recently dug into utilizing the adcsensor feature so figured my notes
could be useful to others who want to utilize this feature.

Change-Id: I56fa1b3f79a353987af89

adcsensor: add some documentation

Recently dug into utilizing the adcsensor feature so figured my notes
could be useful to others who want to utilize this feature.

Change-Id: I56fa1b3f79a353987af89dbcac2335240ba4d1c4
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

psusensor: Optimize the naming of some variables

Some variable declarations and parameter types use
`boost::container::flat_map`. The long type names make it difficult
for other developers to read.

psusensor: Optimize the naming of some variables

Some variable declarations and parameter types use
`boost::container::flat_map`. The long type names make it difficult
for other developers to read.

This commit makes some minor optimizations, using `using` to declare
an alias to increase the readability of the code.

Tested: built psusensor successfully and works fine.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I9b632c27fc67694d2de384f6e7c88bf66b97f78e

show more ...

Set exitAirSensor to null before creating sensor

If the configuration for the current ExitAirTempSensor is changed the
service will crash because it will re-create its DBus interfaces. To
prevent th

Set exitAirSensor to null before creating sensor

If the configuration for the current ExitAirTempSensor is changed the
service will crash because it will re-create its DBus interfaces. To
prevent this set exitAirSensor to nullptr before creating a new sensor.

Tested:
Change a property of the ExitAirTempSensor to something new to
re-trigger createSensors(), e.g.
busctl set-property xyz.openbmc_project.EntityManager
/xyz/openbmc_project/inventory/system/chassis/R4000_Chassis/Exit_Air_Temp
xyz.openbmc_project.Configuration.ExitAirTempSensor.Thresholds0 Value d 93

Without the fix the service would crash:
with the error: "exitairtempsensor: what(): sd_bus_add_object_vtable:
org.freedesktop.DBus.Error.FileExists: File exists". With the fix the
service doesn't crash and the property change holds.

Change-Id: I288140a8bd7ebb7119726720e0c829f3677a8aca
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

tachsensor: Fix 'Associations' capitalization to register associations

Before patch:
```
# busctl introspect xyz.openbmc_project.FanSensor /xyz/openbmc_project/inventory/Fan1_0 xyz.openbmc_project.A

tachsensor: Fix 'Associations' capitalization to register associations

Before patch:
```
# busctl introspect xyz.openbmc_project.FanSensor /xyz/openbmc_project/inventory/Fan1_0 xyz.openbmc_project.Association.Definitions
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.associations property a(sss) 1 "sensors" "inventory" "/xyz/openbmc... emits-change

# busctl tree xyz.openbmc_project.ObjectMapper | grep Fan1_0
| | |- /xyz/openbmc_project/sensors/fan_tach/Fan1_0
| | | `- /xyz/openbmc_project/sensors/fan_tach/Fan1_0/chassis
```

After patch:
```
# busctl introspect xyz.openbmc_project.FanSensor /xyz/openbmc_project/inventory/Fan1_0 xyz.openbmc_project.Association.Definitions
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.Associations property a(sss) 1 "sensors" "inventory" "/xyz/openbmc... emits-change

# busctl tree xyz.openbmc_project.ObjectMapper | grep Fan1_0
| |- /xyz/openbmc_project/inventory/Fan1_0
| | `- /xyz/openbmc_project/inventory/Fan1_0/sensors
| | |- /xyz/openbmc_project/sensors/fan_tach/Fan1_0
| | | |- /xyz/openbmc_project/sensors/fan_tach/Fan1_0/chassis
| | | `- /xyz/openbmc_project/sensors/fan_tach/Fan1_0/inventory

```

Change-Id: Ie7fd69a4dc7216fb2dcfb1fdccc2b7885c7511ee
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>

show more ...

subprojects: Bump boost to 1.83

Bump to avoid issues such as the following:

```
In file included from ../src/Utils.hpp:3,
from ../src/Thresholds.hpp:3,
from ../src

subprojects: Bump boost to 1.83

Bump to avoid issues such as the following:

```
In file included from ../src/Utils.hpp:3,
from ../src/Thresholds.hpp:3,
from ../src/sensor.hpp:6,
from ../src/PwmSensor.hpp:3,
from ../src/PwmSensor.cpp:17:
../src/VariantVisitors.hpp:18:10: fatal error: boost/type_index.hpp: No such file or directory
18 | #include <boost/type_index.hpp>
| ^~~~~~~~~~~~~~~~~~~~~~
```

1.83 is used by openbmc/openbmc@43471c8c565d346c1727ba2360db373035234c26

With the bump I can now successfully build dbus-sensors on Debian
Bookworm with `meson setup --cross-file=gcc-13 build`[1], even if boost
libraries and headers of varying version are installed via `apt`.

[1]: https://amboar.github.io/notes/2023/09/12/unstable-gcc-on-debian-stable.html

Change-Id: I43cb95167ede3271cc6ce6ea6ea5421911b575c0
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: Order dependencies as an approximate in-order tree traversal

meson appears to not be terribly fancy about resolving dependency
constraints. Dependencies appear to be evaluated in their order

meson: Order dependencies as an approximate in-order tree traversal

meson appears to not be terribly fancy about resolving dependency
constraints. Dependencies appear to be evaluated in their order of
declaration, as an in-order tree traversal. This ordering is problematic
for escalating version constraints.

As a concrete example, we currently declare `dependency('sdbusplus')`
before `dependency('boost')`. sdbusplus itself depends on boost, without
a version constraint. If boost is available on the build system then
this is selected. However, dbus-sensors' boost dependency may have a
version constraint of e.g. >=1.83.0. In this arrangement we hit the the
following error:

```
sdbusplus| Run-time dependency Boost found: YES 1.81.0 (/usr/include)
...
Dependency boost found: NO found 1.81.0 but need: '>=1.83.0' (cached)

meson.build:67:8: ERROR: Dependency 'boost' is required but not found.
```

Declare (common) dependencies as an approximate in-order traversal to
avoid conflicts.

Change-Id: I0277061f3ac36361495183018293a61163d70a36
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: Improve boost integration

Currently we hit the following:

```
$ meson setup --force-fallback-for=boost build
...
WARNING: Subproject 'boost' did not override 'boost' dependency and no variab

meson: Improve boost integration

Currently we hit the following:

```
$ meson setup --force-fallback-for=boost build
...
WARNING: Subproject 'boost' did not override 'boost' dependency and no variable name specified
Dependency boost from subproject subprojects/boost found: NO
meson.build:57: WARNING: include_directories sandbox violation!
The project is trying to access the directory 'subprojects/boost_1_79_0/' which belongs to a different
subproject. This is a problem as it hardcodes the relative paths of these two projects.
This makes it impossible to compile the project in any other directory layout and also
prevents the subproject from changing its own directory layout.

Instead of poking directly at the internals the subproject should be executed and
it should set a variable that the caller can then use. Something like:

# In subproject
some_dep = declare_dependency(include_directories: include_directories('include'))

# In subproject wrap file
[provide]
some = some_dep

# In parent project
some_dep = dependency('some')
executable(..., dependencies: [some_dep])

This warning will become a hard error in a future Meson release.

meson.build:57:14: ERROR: Include dir subprojects/boost_1_79_0/ does not exist.
```

Address the sandbox violation and reduce the amount of configuration
noise in meson.build by providing an appropriate wrap via packagefiles.

Change-Id: I4063764d2c3a00f58d3c83712092303538b64843
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: Clean up specification of sdbusplus dependency

The manual attempt at handling a fallback is unnecessary - let meson do
the work for us in the idiomatic way of deferring to a wrap of the same

meson: Clean up specification of sdbusplus dependency

The manual attempt at handling a fallback is unnecessary - let meson do
the work for us in the idiomatic way of deferring to a wrap of the same
name.

Change-Id: Ie7682771a96680a5093391bff2eaf9b4d16b6696
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

subprojects: Bump liburing to 2.4-2

With the bump we receive the fix in af29310a780e ("liburing: override
"liburing" dependency name") from mesonbuild/wrapdb, which addresses the
following warning:

subprojects: Bump liburing to 2.4-2

With the bump we receive the fix in af29310a780e ("liburing: override
"liburing" dependency name") from mesonbuild/wrapdb, which addresses the
following warning:

```
WARNING: Subproject 'liburing' did not override 'liburing' dependency and no variable name specified
Dependency liburing from subproject subprojects/liburing-liburing-2.2 found: NO
```

The wrap file content was changed via `meson wrap upgrade`.

Change-Id: I4cabb81348986cd376c592509e083be60b27fd2f
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...