Revert "sensor: remove exception in error path"

This reverts commit 379b11316d55b114bdb1bfc5a49839b09ade9038, bringing
it back into line with expected ASIO callback behavior, as documented in
Ic3a36

Revert "sensor: remove exception in error path"

This reverts commit 379b11316d55b114bdb1bfc5a49839b09ade9038, bringing
it back into line with expected ASIO callback behavior, as documented in
Ic3a36027fa95a77469439b296a1497634cfe030f. The reverted commit was based
on a misunderstanding of the ASIO error handling path.

Tested: With accompanying sdbusplus change, was able to override sensor
value only when ValidationUnsecure mode was enabled, and proper error
response was returned:

root@openbmc:~# busctl set-property xyz.openbmc_project.IpmbSensor \
/xyz/openbmc_project/sensors/temperature/SSB_Temp \
xyz.openbmc_project.Sensor.Value Value d 52
Failed to set property Value on interface xyz.openbmc_project.Sensor.Value: Not allowed to set property value.
root@openbmc:~# busctl set-property xyz.openbmc_project.SpecialMode \
/xyz/openbmc_project/security/special_mode \
xyz.openbmc_project.Security.SpecialMode SpecialMode s \
xyz.openbmc_project.Control.Security.SpecialMode.Modes.ValidationUnsecure
root@openbmc:~# busctl set-property xyz.openbmc_project.IpmbSensor \
/xyz/openbmc_project/sensors/temperature/SSB_Temp \
xyz.openbmc_project.Sensor.Value Value d 52
root@openbmc:~#

Change-Id: I05c41318954d5d1549752c5ef2c227f3f22a45d3
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

show more ...

PSUSensor: Add device type RAA228620 and RAA229001

Add device type RAA228620 and RAA229001 to the allowed list.

Signed-off-by: Tom Tung <shes050117@gmail.com>
Change-Id: Id990bf3931fdfb3433de8bddc3

PSUSensor: Add device type RAA228620 and RAA229001

Add device type RAA228620 and RAA229001 to the allowed list.

Signed-off-by: Tom Tung <shes050117@gmail.com>
Change-Id: Id990bf3931fdfb3433de8bddc3f0a72869b18747

show more ...

Update link to the Value.interface.yaml

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: I95b1db1f07612a3e5604bbf043cc00f731bd3a8c

PSUSensor: Add device type mp2971 and mp2973

Add device type mp2971 and mp2973 to the allowed list.

Signed-off-by: Shamim Ali <shamima@ami.com>
Change-Id: I39a177ba770c764aa0fc1e9a5e03b19e639e2ea2

Apply LambdaBodyIndentation to dbus-sensors

Per the transform being done in bmcweb, do the same for dbus-sensors.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: If21489607759f3cdf20fad17

Apply LambdaBodyIndentation to dbus-sensors

Per the transform being done in bmcweb, do the same for dbus-sensors.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: If21489607759f3cdf20fad17eede50fb4e228e5e

show more ...

intrusionsensor: systemd: Use qualified path

Fix a documented anti-pattern:
https://github.com/openbmc/docs/blob/master/anti-patterns.md#use-of-usrbinenv-in-systemd-service-files

Signed-off-by: Bra

intrusionsensor: systemd: Use qualified path

Fix a documented anti-pattern:
https://github.com/openbmc/docs/blob/master/anti-patterns.md#use-of-usrbinenv-in-systemd-service-files

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: Iee20d0516a4bd031b861f47c451a2bfccd986bde

show more ...

hwmon-temp-sensor: Support sensor with missing labels

Erase sensorName from hwmonName even if it is not included in the
`Labels` property. This makes sure that all hwmonNames that it parsed
will be

hwmon-temp-sensor: Support sensor with missing labels

Erase sensorName from hwmonName even if it is not included in the
`Labels` property. This makes sure that all hwmonNames that it parsed
will be removed and allows us to support missing labels when we don't
want to expose all sensors.

Currently the hwmon temp sensors forces all sensor labels to be
required even when we don't want to expose all of them.

With
```
{
"Address": "0x4e",
"Bus": "$bus",
"Name": "test0",
"Name1": "test1",
"Name2": "test2",
"Name3": "test3",
"Labels": ["temp4"],
"Type": "MAX31730"
},
```

It will have
```
$ /tmp/hwmontempsensor &
error getting SpecialMode status No route to host
malloc(): unsorted double linked list corrupted
-sh: line 438: 20466 Aborted (core dumped) /tmp/hwmontempsensor
```

It needs the `Labels` to be `["temp1, "temp2", "temp3", "temp4"]` for
this to work properly.

With the fix to the daemon it doesn't need it anymore.

Tested:
Working and didn't crash
```
busctl tree xyz.openbmc_project.HwmonTempSensor
`-/xyz
`-/xyz/openbmc_project
`-/xyz/openbmc_project/sensors
`-/xyz/openbmc_project/sensors/temperature
`-/xyz/openbmc_project/sensors/temperature/test3
```

Change-Id: I926b76dbb2777bc3e0f273b001139cd468617e63
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Always fill both values for a threshold interface

If one of the thresholds for a threshold dbus interface is provided we
have to set the other one as dbus properties are never optional.

Tested:
B

Always fill both values for a threshold interface

If one of the thresholds for a threshold dbus interface is provided we
have to set the other one as dbus properties are never optional.

Tested:
Before:
xyz.openbmc_project.Sensor.Threshold.Warning interface - -
.WarningAlarmHigh property b false
.WarningHigh property d 14

After:
xyz.openbmc_project.Sensor.Threshold.Warning interface - -
.WarningAlarmHigh property b false
.WarningAlarmLow property b false
.WarningHigh property d 14
.WarningLow property d nan

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: I0e9b885e8c0494d46d39af965047a7582255a48e

show more ...

hwmontempsensor: Add NCT6779 to sensorTypes

This is a Nuvoton Super I/O chip supported by the nct6775-i2c driver
recently added to the Linux kernel, and employed in systems such as the
ASRock Rack r

hwmontempsensor: Add NCT6779 to sensorTypes

This is a Nuvoton Super I/O chip supported by the nct6775-i2c driver
recently added to the Linux kernel, and employed in systems such as the
ASRock Rack romed8hm3, in which it provides the only way for the BMC to
monitor host CPU temperatures.

Tested: on an ASRock Rack romed8hm3 with an entity-manager config
modified to include an nct6779 entry, hwmontempsensor exposes sensor
readings from it appropriately (though support for handling host
power-state transitions is yet to be implemented and will be required
for full support, because the nct6779 is in the same power domain as the
host).

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I562c276f58c2c738ab61cacaa07c819208142249

show more ...

NVMeContext: Rework sensor removal concurrent to polling

Concurrent removal of a sensor's configuration while the sensor list is
being iterated for polling can lead to undefined behaviour via access

NVMeContext: Rework sensor removal concurrent to polling

Concurrent removal of a sensor's configuration while the sensor list is
being iterated for polling can lead to undefined behaviour via access
through a deleted iterator:

Program terminated with signal SIGSEGV, Segmentation fault.
#0 std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count (__r=..., this=<optimised out>, this=<optimised out>, __r=...)
at /usr/include/c++/11.2.0/bits/stl_list.h:224
224 /usr/include/c++/11.2.0/bits/stl_list.h: No such file or directory.
[Current thread is 1 (LWP 6649)]
#0 std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count (__r=..., this=<optimised out>, this=<optimised out>, __r=...)
at /usr/include/c++/11.2.0/bits/stl_list.h:224
#1 std::__shared_ptr<NVMeSensor, (__gnu_cxx::_Lock_policy)2>::__shared_ptr (this=<optimised out>, this=<optimised out>)
at /usr/include/c++/11.2.0/bits/shared_ptr_base.h:1152
#2 std::shared_ptr<NVMeSensor>::shared_ptr (this=<optimised out>, this=<optimised out>) at /usr/include/c++/11.2.0/bits/shared_ptr.h:150
#3 NVMeBasicContext::readAndProcessNVMeSensor (this=0x1ac8a90, iter=non-dereferenceable iterator for std::list) at ../git/src/NVMeBasicContext.cpp:299
#4 0x004dd8b8 in NVMeBasicContext::readAndProcessNVMeSensor (this=0x1ac8a90, iter=non-dereferenceable iterator for std::list) at ../git/src/NVMeBasicContext.cpp:312
#5 0x004dd8b8 in NVMeBasicContext::readAndProcessNVMeSensor (this=0x1ac8a90, iter=std::shared_ptr<NVMeSensor> (use count 26, weak count 28153871) = {get() = 0x1ad8db0})
at ../git/src/NVMeBasicContext.cpp:312

Rework polling and sensor removal to uphold the requirement that the
iterator remains valid.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I69b005fe3dad7ddf21d1762731f9cdfd2408cae1

show more ...

Fansensor: remove SOC info

remove hardcoded SOC specific information

Tested platforms:
- Aspeed ast2600 PWM on Bletchley

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: I9881205110136

Fansensor: remove SOC info

remove hardcoded SOC specific information

Tested platforms:
- Aspeed ast2600 PWM on Bletchley

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: I9881205110136a29159e67589442396f1b2327c8

show more ...

Fansensor: Support ast26xx pwm/tach

Add new fantype for ast26xx tach driver.
Use pwm-fan driver to setup ast26xx pwm driver for easier usage.
User must define pwm-fan node in dts as below

pwm-fanX

Fansensor: Support ast26xx pwm/tach

Add new fantype for ast26xx tach driver.
Use pwm-fan driver to setup ast26xx pwm driver for easier usage.
User must define pwm-fan node in dts as below

pwm-fanX {
compatible = "pwm-fan";
.......
};
refer Documentation/devicetree/bindings/hwmon/pwm-fan.txt for details

and Connector in EM configuration
"Connector": {
"Pwm": X,
......
}

where X is integer

Tested: On Facebook Bletchley (ast26xx) Platform with 1 fan

root@bletchley:/sys/class/leds# busctl set-property xyz.openbmc_project.FanSensor /xyz/openbmc_project/sensors/fan_pwm/Pwm_1 xyz.openbmc_project.Sensor.Value Value d 20
root@bletchley:/sys/class/leds# busctl introspect xyz.openbmc_project.FanSensor /xyz/openbmc_project/sensors/fan_tach/FAN0_TACH_IL xyz.openbmc_project.Sensor.Value
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.MaxValue property d 25000 emits-change
.MinValue property d 0 emits-change
.Unit property s "xyz.openbmc_project.Sensor.Value.Uni... emits-change
.Value property d 3189 emits-change writable
root@bletchley:/sys/class/leds# busctl introspect xyz.openbmc_project.FanSensor /xyz/openbmc_project/sensors/fan_tach/FAN0_TACH_OL xyz.openbmc_project.Sensor.Value
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.MaxValue property d 25000 emits-change
.MinValue property d 0 emits-change
.Unit property s "xyz.openbmc_project.Sensor.Value.Uni... emits-change
.Value property d 3006 emits-change writable

Signed-off-by: Howard Chiu <howard.chiu@quantatw.com>
Change-Id: Ifda89310590c9d914fa0a302df412fead807daa8
Signed-off-by: Potin Lai <potin.lai@quantatw.com>

show more ...

HwmonTempSensor: Fix a crash when an I3C device is scanned

When an I3C device is registered in hwmon sub-system, the device would have
a long address tag such as '0-4cc31020000', so if the scanning

HwmonTempSensor: Fix a crash when an I3C device is scanned

When an I3C device is registered in hwmon sub-system, the device would have
a long address tag such as '0-4cc31020000', so if the scanning loop uses
'stoi' for the address parsing, this service crashs by this error.

terminate called after throwing an instance of 'std::out_of_range'
what(): stoi
Aborted (core dumped)

To prevent this issue, this commit replaces 'stoi' with std::from_chars
to uint64_t type since BasicVariantType can be up to uint64_t and it
actually parses unsigned numbers from Bus and Address settings.

Tested: HwmonTempSensor service didn't crash even when an I3C device is
enumerated in sysfs.

Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
Change-Id: I5a06849b4149d535b2d4002f0f6e1e7bd5f94b97

show more ...

Fix for cpusensor going into D state.

When PECI driver returns the error code EAGAIN, async_read_until will
go into a keep trying again loop. As async_read_until does not handle
EAGAIN reliably.

Sa

Fix for cpusensor going into D state.

When PECI driver returns the error code EAGAIN, async_read_until will
go into a keep trying again loop. As async_read_until does not handle
EAGAIN reliably.

Same issue was identified and fix for PSUSensor:
https://github.com/openbmc/dbus-sensors/commit/bcf76717697238e380be785bd28150963ecf0e9e

Fix for this is to use async_wait instead of async_read_until.

Tested:
In Intel system verified cpusensor daemon is not getting into D state
when there is a peci error EAGAIN.
Verified sensors are getting populated as expected when there is no PECI
error.

Signed-off-by: Arun Lal K M <arun.lal@intel.com>
Signed-off-by: Arun P. Mohanan <arun.p.m@linux.intel.com>
Change-Id: I52e35075e522d0ae0d99e1c893db76156e299871

show more ...

Revert "hwmon-temp-sensor: Support sensor with missing labels"

It turns out this commit results in ignoring the humidity/pressure
sensor for IIO devices that provide both temperature and a different

Revert "hwmon-temp-sensor: Support sensor with missing labels"

It turns out this commit results in ignoring the humidity/pressure
sensor for IIO devices that provide both temperature and a different
type.

It happens because the same device has multiple entries in the 'paths'
variable since they are added here:

findFiles(root, R"(in_temp\d*_(input|raw))", paths);
findFiles(root, R"(in_pressure\d*_(input|raw))", paths);
findFiles(root, R"(in_humidityrelative\d*_(input|raw))", paths);

and then this change would remove the config entry for the device before
it could process the other paths.

This reverts commit 0f580944e22534c8814634d76bd752a5d4236f60.

Change-Id: I22b4336101fae7782c650b9cf5f515dbbdacca9e
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

HwmonTempMain: fix sensor index of Name1

For pressure and humidity sensors are using Name1 as sensor name, and it
needs manually assign the index to 2 for the thresholds config works correctly

Test

HwmonTempMain: fix sensor index of Name1

For pressure and humidity sensors are using Name1 as sensor name, and it
needs manually assign the index to 2 for the thresholds config works correctly

Tested EM conifg:
{
"Address": "0x40",
"Bus": 10,
"Name": "FRONT_PANEL_TEMP",
"Name1": "FRONT_PANEL_HUMIDTY",
"Thresholds": [
{
"Direction": "greater than",
"Index": 1,
"Name": "upper critical",
"Severity": 1,
"Value": 40
},
{
"Direction": "less than",
"Index": 1,
"Name": "lower critical",
"Severity": 1,
"Value": 0
},
{
"Direction": "greater than",
"Index": 2,
"Name": "upper critical",
"Severity": 1,
"Value": 80
},
{
"Direction": "less than",
"Index": 2,
"Name": "lower critical",
"Severity": 1,
"Value": 10
}
],
"Type": "HDC1080"
}

Tested Results:
root@bletchley:~# busctl introspect xyz.openbmc_project.HwmonTempSensor /xyz/openbmc_project/sensors/temperature/FRONT_PANEL_TEMP xyz.openbmc_project.Sensor.Threshold.Critical
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.CriticalAlarmHigh property b false emits-change
.CriticalAlarmLow property b false emits-change
.CriticalHigh property d 40 emits-change writable
.CriticalLow property d 0 emits-change writable
root@bletchley:~# busctl introspect xyz.openbmc_project.HwmonTempSensor /xyz/openbmc_project/sensors/humidity/FRONT_PANEL_HUMIDTY xyz.openbmc_project.Sensor.Threshold.Critical
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.CriticalAlarmHigh property b false emits-change
.CriticalAlarmLow property b false emits-change
.CriticalHigh property d 80 emits-change writable
.CriticalLow property d 10 emits-change writable

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: I6ae1c007729b884acde56ecc83b6c8b88ea1bc81

show more ...

hwmon-temp-sensor: Support sensor with missing labels

Currently the hwmon temp sensors forces all sensor labels to be
required even when we don't want to expose all of them.

For example,
```

hwmon-temp-sensor: Support sensor with missing labels

Currently the hwmon temp sensors forces all sensor labels to be
required even when we don't want to expose all of them.

For example,
```
{
"Address": "0x4e",
"Bus": "$bus",
"Name": "test0",
"Name1": "test1",
"Name2": "test2",
"Name3": "test3",
"Labels": ["temp4"],
"Type": "MAX31730"
},
```

It will have
```
$ /tmp/hwmontempsensor &
error getting SpecialMode status No route to host
malloc(): unsorted double linked list corrupted
-sh: line 438: 20466 Aborted (core dumped)
/tmp/hwmontempsensor
```

It needs the `Labels` to be `["temp1, "temp2", "temp3", "temp4"]` to
work properly.

With the fix to the daemon it doesn't need it anymore and we can expose
only the sensor that we want.

Tested:
Working and didn't crash
```
busctl tree xyz.openbmc_project.HwmonTempSensor
`-/xyz
`-/xyz/openbmc_project
`-/xyz/openbmc_project/sensors
`-/xyz/openbmc_project/sensors/temperature
`-/xyz/openbmc_project/sensors/temperature/test3
```

Change-Id: I73d236cf36f22ec0e64a1603b83b14e29e56d36b
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

NVMeBasicContext: Fix response vector size

73030639a5ba ("Enable cppcoreguidelines-avoid-goto checks") switches
from passing the backing store of the response vector to ::write() to
using an iterato

NVMeBasicContext: Fix response vector size

73030639a5ba ("Enable cppcoreguidelines-avoid-goto checks") switches
from passing the backing store of the response vector to ::write() to
using an iterator over the response vector. This exposed the flaw that
the vector was never properly sized to accommodate the presence of the
response in the backing buffer[1], though from a memory-safety
perspective the backing buffer _was_ appropriately sized from the
reserve() call.

Resize the vector both before and after to ensure that a complete
response can be captured safely while also returning a vector that is
sized in accordance with the response.

It's likely the buffer management strategy could be improved here by
instead using std::array and std::span[2].

[1] https://github.com/openbmc/dbus-sensors/issues/18
[2] https://discord.com/channels/775381525260664832/867820390406422538/959228526811312169

Fixes: #18
Fixes: 73030639a5ba ("Enable cppcoreguidelines-avoid-goto checks")
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ic2015a776389635765972084de75e33e7ea23d53

show more ...

NVMeBasicContext: Account for invalid drive status

Respect the drive status bits in the basic management command response
before parsing the drive temperature value, as it may not yet be valid.

Sig

NVMeBasicContext: Account for invalid drive status

Respect the drive status bits in the basic management command response
before parsing the drive temperature value, as it may not yet be valid.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I5311eb3b07f9b52fce7342c9c7f670f777d68c1d

show more ...

NVMeBasicContext: Defer polling sensors that are in error

A sensor is only polled after N sampling periods if it is in error. This
necessitates the movement of some of the error handling so we can
i

NVMeBasicContext: Defer polling sensors that are in error

A sensor is only polled after N sampling periods if it is in error. This
necessitates the movement of some of the error handling so we can
increment the sensor's error counter as appropriate.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ie19f6ceb7ad8f9b2f1408a4ca8f12c0ca385ce8c

show more ...

NVMeBasicContext: Poll all sensors each polling interval

Rework the polling protocol so that the completion of polling sensor N
invokes polling of sensor N+1 for the given context.

The timer is ret

NVMeBasicContext: Poll all sensors each polling interval

Rework the polling protocol so that the completion of polling sensor N
invokes polling of sensor N+1 for the given context.

The timer is retained in order to trigger polling the initial sensor.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I599547c8c790905549c0cad9fbfbe63cf6930de4

show more ...

nvmesensor: Remove MCTP transport implementation

This was implemented in terms of a series of patches against libmctp
that were never upstreamed (because they in-turn relied on kernel
patches that a

nvmesensor: Remove MCTP transport implementation

This was implemented in terms of a series of patches against libmctp
that were never upstreamed (because they in-turn relied on kernel
patches that also were never upstreamed). Further, there are no
configurations enabling the nvme-mi-mctp option in openbmc/openbmc.

This is motivated by the need to refactor NVMeContext to support polling
all sensors inside the polling period on a given root bus.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ib20b7f3ce218191a391d7b2d893f204fb97b7ab5

show more ...

NVMeBasicContext: Reject bad I2C bus IDs

We can't possibly query such sensors, so ensure they can't exist.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I899979db57a84272be9b537d87e547

NVMeBasicContext: Reject bad I2C bus IDs

We can't possibly query such sensors, so ensure they can't exist.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I899979db57a84272be9b537d87e54756296695cf

show more ...

Move sensorClass and subtype to separate functions

Cleaning up the code by moving the sensor Class, sensor subtype
and sensor Scale & Offset value to separate functions in
IpmbSensor.

TESTED: Teste

Move sensorClass and subtype to separate functions

Cleaning up the code by moving the sensor Class, sensor subtype
and sensor Scale & Offset value to separate functions in
IpmbSensor.

TESTED: Tested on Facebook YosemiteV2 platform and verified the
IpmbSensor sensors.

Signed-off-by: Jayashree Dhanapal <jayashree-d@hcl.com>
Change-Id: Id185ce0d592039d2999902c5ae88a49891c7a807

show more ...

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If0797a

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If0797ab803bbc5b254487e2050c69deceb829976

show more ...