PSUSensor: Rename IPSPS to IPSPS1

Due to upstream[0] in the `EntityManager` using the driver name
`IPSPS1`, update it.

[0]: https://gerrit.openbmc.org/c/openbmc/entity-manager/+/58861

Change-Id: I

PSUSensor: Rename IPSPS to IPSPS1

Due to upstream[0] in the `EntityManager` using the driver name
`IPSPS1`, update it.

[0]: https://gerrit.openbmc.org/c/openbmc/entity-manager/+/58861

Change-Id: Ie03967ab24e9d79cb65e2786755b4686599de724
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

ipmbsensor: remove debug log

The debug log causes log spams and should be removed.

Change-Id: Ib46b280ddf2247f2824a4c126690a0b51cf76ff6
Signed-off-by: Willy Tu <wltu@google.com>

Avoid thresholds vector update while iterating

new data is pushed on thresholds vector while it is being iterated.
vector insertion can resize vector length. Resize in vector cause
invalidation of i

Avoid thresholds vector update while iterating

new data is pushed on thresholds vector while it is being iterated.
vector insertion can resize vector length. Resize in vector cause
invalidation of iterators and further operation iterator is undefined
behaviour(i.e. crash).
Iterate through vector by indexing it from beginning to original size.

Tested:
No cashes were observed with thresholds vector iteration.

Change-Id: Idf1d017847fa77128922a38eb6e33e0fa5702f3d
Signed-off-by: Vikash Chandola <vikash.chandola@intel.com>

show more ...

nvmesensor: Make bus and address private variables

It is recommended to make the bus and address as const variables to
prevent it from being edited in code.
Tested: Manually by verifying that the be

nvmesensor: Make bus and address private variables

It is recommended to make the bus and address as const variables to
prevent it from being edited in code.
Tested: Manually by verifying that the behavior remains the same, and
that the bus and address gotten from Entity Manager configuration is
used by the binary.

Change-Id: Ib69e8d7e68f433064504f2502ce79c4e5c234f3e
Signed-off-by: Nnamdi Ajah <nnamdi@cloudflare.com>

show more ...

intrusion sensor: fix default reading value

As-is the updateValue method will never update the mOldValue and trigger
a redfish message. This can be fixed by changing the default mOldValue
to "Norma

intrusion sensor: fix default reading value

As-is the updateValue method will never update the mOldValue and trigger
a redfish message. This can be fixed by changing the default mOldValue
to "Normal". With this change it'll detect an intrusion event at boot
and then any changes in intrusion state thereafter.

Tested:
Before change no redfish messages were being triggered.

After change asserting intrusion even triggered redfish message
and any changes to the intrusion jumper triggered redfish messages.

Change-Id: Idafa5b2dbd5501a433607981ef042a1802fab0ad
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

intrusionsensor: Add hwmon reading method

This commit adds a new reading method for intrusionsensor, which reads
the chassis intrusion status from hwmon.

Example:
{
"Class": "Aspeed260

intrusionsensor: Add hwmon reading method

This commit adds a new reading method for intrusionsensor, which reads
the chassis intrusion status from hwmon.

Example:
{
"Class": "Aspeed2600_Hwmon",
"Name": "Chassis_Intrusion_Status",
"Type": "ChassisIntrusionSensor"
}

intrusionsensor will search for the sysfs hwmon name string in the
compatibleHwmonNames map using the Class string (e.g intrusion0_alarm
for Aspeed2600_Hwmon class) and read the chassis intrusion status from
it. This currently just supports Aspeed2600_Hwmon class which is based
on the aspeed-chassis driver from Aspeed SDK. The driver reads the
Intrusion Status bit in the CHAI10 register from AST2600. This bit
needs to be cleared every read in order to get the current state (which
means to write 0 to the hwmon file). In the condition of being cleared
every read, it will show 0 in hwmon for the normal state, and 1 for the
intrusion state.

Tested:

$ busctl get-property xyz.openbmc_project.IntrusionSensor \
/xyz/openbmc_project/Chassis/Intrusion \
xyz.openbmc_project.Chassis.Intrusion Status

If the chassis cover is closed: "Normal"
If the chassis cover is open: "HardwareIntrusion"

Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: I6f6a42592c8acae7be4f10e65a8b52ee30a4bd4f

show more ...

hwmontemp: add tmp464

Change-Id: Ic7337e9450a9cb83222b99d70c666f10211f1668
Signed-off-by: Hieu Huynh <hieuh@os.amperecomputing.com>

Rename Sensor class variable

The name of the entity-manager D-Bus interface the sensor was created
from was stored in a variable called objectType. Rename that to
configInterface to make it obvious

Rename Sensor class variable

The name of the entity-manager D-Bus interface the sensor was created
from was stored in a variable called objectType. Rename that to
configInterface to make it obvious it's an interface name.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I5258ebf12c6aa565a6a2ea286cd2724fd54cf986

show more ...

hwmontemp: Fix object type being passed to ctors

The Sensor base class is now tacking on the
'xyz.openbmc_project.Configuration' prefix to the objectType argument
passed into its constructor. But i

hwmontemp: Fix object type being passed to ctors

The Sensor base class is now tacking on the
'xyz.openbmc_project.Configuration' prefix to the objectType argument
passed into its constructor. But in createSensors() the value passed
into the constructor was already the full interface name taken from the
buildSensorConfigMap() output, so the prefix ended up being in the
objectType member variable twice.

This was causing the InterfacesRemoved handler to not find an interface
match when entity-manager removed interfaces, leaving sensors on D-Bus
for hardware that was no longer in the system.

Fix it by stripping off all but the last segment before passing it to
the sensor object constructor.

Tested:
Sensors are now removed from D-Bus when the corresponding objects are
removed from entity-manager.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I3312a6cddbe2b175b89f8566d5c9359b7c2df201

show more ...

IntelCPUSensor: use libpeci to open peciFd

To stay consistent with libpeci usage we should use
dedicated functions to open PECI file descriptors
when using peci-legacy.

Tested: hwmons are successfu

IntelCPUSensor: use libpeci to open peciFd

To stay consistent with libpeci usage we should use
dedicated functions to open PECI file descriptors
when using peci-legacy.

Tested: hwmons are successfully created in the same way
they were created opening peciFd directly

Change-Id: I924c3fdc8029f47aed80480ebc03d2dca71d134f
Signed-off-by: Oleksandr Shulzhenko <oleksandr.shulzhenko.viktorovych@intel.com>

show more ...

psusensor: Add xdpe152c4 support

Tested: Combined with related driver and entity-manager changes from
https://gerrit.openbmc.org/c/openbmc/entity-manager/+/63921
sensors properly show up in IPMI sen

psusensor: Add xdpe152c4 support

Tested: Combined with related driver and entity-manager changes from
https://gerrit.openbmc.org/c/openbmc/entity-manager/+/63921
sensors properly show up in IPMI sensors

Change-Id: I2958d0e566c67881f6e237e9d15c0c2621f30165
Signed-off-by: Jeff Lin <JeffLin2@quantatw.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I0d10afa582342818b9d90b168f6f39f71ce4e0f4
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
[AJ: regenerate using .clang-format from openbmc/docs@f44abd66eca8]
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

intrusionsensor: Refactor source code

This commit splits the intrusionsensor source code into a base class and
derived classes to dictate sensor of different methods. Only one method
of chassis intr

intrusionsensor: Refactor source code

This commit splits the intrusionsensor source code into a base class and
derived classes to dictate sensor of different methods. Only one method
of chassis intrusion detection is expected for one given system.

Tested with hwmon method on Ampere Mt.Mitchell platform which is
implemented in the patch:
https://gerrit.openbmc.org/c/openbmc/dbus-sensors/+/62775

Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: Ia2b71d897a27ee7c7955e233d060ad14d62be3a8

show more ...

Fix format in HwmonMain.cpp to pass format check

Change-Id: I6b39dad6e00e1682cb7ed9bbafcc85999b073c44
Signed-off-by: Michael Shen <gpgpgp@google.com>

Fix PECI client creation flow

This commit fixes the PECI client creation flow to make it retry
the creation when the client is not exposed correctly.

Change-Id: I779cc1865e9ebb8fff90efcbac4503379ca

Fix PECI client creation flow

This commit fixes the PECI client creation flow to make it retry
the creation when the client is not exposed correctly.

Change-Id: I779cc1865e9ebb8fff90efcbac4503379cadea5a
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@intel.com>
Signed-off-by: AppaRao Puli <apparao.puli@intel.com>
Signed-off-by: Oleksandr Shulzhenko <oleksandr.shulzhenko.viktorovych@intel.com>

show more ...

IntelCPUSensor: Use libpeci when communicating via peci-legacy

When using peci-legacy the general approach is to use libpeci as
the middleware to communicate with peci core from userspace.
Integrate

IntelCPUSensor: Use libpeci when communicating via peci-legacy

When using peci-legacy the general approach is to use libpeci as
the middleware to communicate with peci core from userspace.
Integrate libpeci with IntelCPUSensor and use library functions to issue
peci commands where necessary.

Tested: hwmons are succesfully created in the same way
they were created using ioctl.

Change-Id: I4ecd70e604d447a4066dc5fb8d902992cb97cadf
Signed-off-by: Oleksandr Shulzhenko <oleksandr.shulzhenko.viktorovych@intel.com>

show more ...

clang-tidy: reduce repo-specific flags

Adjust the clang-tidy settings so that it does not need to have
a bunch of values related to the libpeci subproject. In general
we should be ignoring any head

clang-tidy: reduce repo-specific flags

Adjust the clang-tidy settings so that it does not need to have
a bunch of values related to the libpeci subproject. In general
we should be ignoring any header files from any subprojects since
they are not under direct control of the repository-under-test.

Change-Id: I64d4e4bae20ca27aed68081b4270fa0ec8fc0543
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

fansensor: fix fan sensor service crash

fs::canonical can throw exception if the path does not exist,
which can happen for i2c fan type. Check for path exists before the
call.

Tested:
fan sensor se

fansensor: fix fan sensor service crash

fs::canonical can throw exception if the path does not exist,
which can happen for i2c fan type. Check for path exists before the
call.

Tested:
fan sensor service successfully detect i2c fan type and does not crash.

Fixes: 9a472e8 ("detect fan type by matching against 'compatible'")
Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: I395e4d47b16fc58eba777e88be304bf28993bec3

show more ...

MCUTempSensor: Fix PDB temparature reading show nan

Actually, i2c_smbus_read_word_data() return value is
not mapped correctly. So, fixed i2c_smbus_read_word_data()
return type to signed int32 from i

MCUTempSensor: Fix PDB temparature reading show nan

Actually, i2c_smbus_read_word_data() return value is
not mapped correctly. So, fixed i2c_smbus_read_word_data()
return type to signed int32 from int16_t.

Tested: Verified PDB temperature reading is getting
reported correctly via D-Bus.

Change-Id: I0a00d5b20c0576abe5635e96b3afadc572241f0a
Signed-off-by: Saitwal, Meghan <meghan.saitwal@intel.com>

show more ...

add support for hpe's gxpfan type

Adds basic support for handling HPE's GXPFan sensors

Tested: confirmed that HPE's GXP fans appear in webUI
with this change + appropriate entity-manager config ent

add support for hpe's gxpfan type

Adds basic support for handling HPE's GXPFan sensors

Tested: confirmed that HPE's GXP fans appear in webUI
with this change + appropriate entity-manager config entries

Change-Id: I0e2e3936575881972f536c80ffc2648a2b2a75e6
Signed-off-by: Chris Sides <christopher.sides@hpe.com>

show more ...

use std::map for fantype 'compatible' string checks

Switches to using a map of valid 'compatible'
strings + fanTypes instead of individual 'compatible'
string == conditionals

Tested: confirmed tha

use std::map for fantype 'compatible' string checks

Switches to using a map of valid 'compatible'
strings + fanTypes instead of individual 'compatible'
string == conditionals

Tested: confirmed that HPE's GXP fans appear in webUI
with this change + appropriate entity-manager config entries

Change was made based on Andrew J's comment @
https://gerrit.openbmc.org/c/openbmc/dbus-sensors/+/62008/comment/cf2f99d8_a3d1d111/

Change-Id: Ia74b1617d95148a9e6a08865146d000c06a65b47
Signed-off-by: Chris Sides <christopher.sides@hpe.com>

show more ...

detect fan type by matching against 'compatible'

Switches fan-type detection to key off well-known 'compatible' strings,
as documented
@ https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linu

detect fan type by matching against 'compatible'

Switches fan-type detection to key off well-known 'compatible' strings,
as documented
@ https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/hwmon/

Change was created in response to the comment:
"I'd much prefer we query compatible attribute through the
of_node symlink" as discussed with Andrew J. and Ed T. in the
gerrit review
@ https://gerrit.openbmc.org/c/openbmc/dbus-sensors/+/58458

Tested: confirmed fans appear in WebUI only when
valid 'compatible' strings are found

Change-Id: Ifae4abc64288e84023c045fc8b2c7a4f0d1b8498
Signed-off-by: Chris Sides <christopher.sides@hpe.com>

show more ...

Deassert thresholds when sensor is unavailable

Some dbus-sensors applications allows you to specify "PowerState"
parameter for its sensors in the configarition. With this parameter
sensor is sampled

Deassert thresholds when sensor is unavailable

Some dbus-sensors applications allows you to specify "PowerState"
parameter for its sensors in the configarition. With this parameter
sensor is sampled/checked against its thresholds only if certain
system conditions are met.
Therefore if sensor becomes unavailable because of the "PowerState"
parameter, all its threshold states must be deasserted.

Tested: tested on the AMD DaytonaX CRB. It is a 2-socket board. For
the test only 1 CPU was installed. In this case voltage sensors that
measure voltages for CPU2 and configured with '"PowerState": "On"'
assert their thresholds when the system is powered on.
Before the patch even if the system is powered off after that, these
voltage sensors stay with the asserted thresholds. Because of that
webui will continue to displays these sensors with a 'Critical' status.
After the patch if system is powered off, the voltage sensors deasset
all their thresholds and the sensors correctly change their status to
'OK' in webui.

Change-Id: Id6a33f15c18ca7aa30e8c449ab9c9e239673dd1f
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

PSUSensor: Add new PMBUS chip TDA38640

Add PMBUS compatible TDA38640 to the supported devices.
The chip has been added to hwmon-next on Sun, 29 Jan 2023.

Change-Id: Ie095359fd9ce223b41eccbc639b6722

PSUSensor: Add new PMBUS chip TDA38640

Add PMBUS compatible TDA38640 to the supported devices.
The chip has been added to hwmon-next on Sun, 29 Jan 2023.

Change-Id: Ie095359fd9ce223b41eccbc639b67223671af733
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

show more ...

PSUSensor: Add more labels

The XDPE11280 exposes two PMBUS VIN channels as it has two
independent outputs. Add those labels to be able to read the
input voltage on that chip.

Added labels:
- vin1
-

PSUSensor: Add more labels

The XDPE11280 exposes two PMBUS VIN channels as it has two
independent outputs. Add those labels to be able to read the
input voltage on that chip.

Added labels:
- vin1
- vin2

Change-Id: Ie94583b8d2f746647e12376b5f51a3e8c399d058
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

show more ...