psusensor: Silence noisy debug message

Skip printing "Configuration skipping ..." by guarding it with the
global debug enable check. On systems with hundreds of configuration
items this debug prin

psusensor: Silence noisy debug message

Skip printing "Configuration skipping ..." by guarding it with the
global debug enable check. On systems with hundreds of configuration
items this debug print is just noisy spam with no value as it's
expected to skip non matching configuration items.

Change-Id: Ia62dbf05e31194d6c233518563656fb01fe30403
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I73acd9daf41b52bcc3f6af9a1c38c5f162ae76b2
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

nvmesensor: Mark drives as unavailable

Fix a race condition where the NVMe sensor is marked available
even though there's no NVMe drive plugged. When the power is already
on when the sensor is creat

nvmesensor: Mark drives as unavailable

Fix a race condition where the NVMe sensor is marked available
even though there's no NVMe drive plugged. When the power is already
on when the sensor is created it will never be marked as unavailable,
but 'not operational' when the communication failed multiple times.
It will remain in this state until power is turned off.

Mark the sensor as unavailable in the constructor to catch this
corner case. For present NVMe drives this will set the available
state after the first NVMe MI packet has been received.

Fixes failSafe mode in phosphor-pid-control when no drive is present.

Change-Id: Ifa3dcc080ecc9ef21213b2a901cf41b2ca0a3de2
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

show more ...

subprojects: Fix libpeci provide variable name

Since its introduction in libpeci with df5c868a14eb ("Declare meson
dependency") the variable has been named `libpeci_dep`. It also appears
that since

subprojects: Fix libpeci provide variable name

Since its introduction in libpeci with df5c868a14eb ("Declare meson
dependency") the variable has been named `libpeci_dep`. It also appears
that since its inception in 77141acb7f09 ("IntelCPUSensor: Use libpeci
when communicating via peci-legacy") the variable name has been wrong in
the dbus-sensors wrap.

Fix the debus-sensors wrap so we can build with libpeci as a meson
subproject.

Tested:

Before:

```
$ meson subprojects purge --confirm && rm -rf build
...
$ meson setup build
...
Executing subproject libpeci

libpeci| Project name: libpeci
libpeci| Project version: 1.0
libpeci| C compiler for the host machine: ccache cc (gcc 12.2.0 "cc (Debian 12.2.0-14) 12.2.0")
libpeci| C linker for the host machine: cc ld.mold 1.10.1
libpeci| C++ compiler for the host machine: ccache c++ (gcc 12.2.0 "c++ (Debian 12.2.0-14) 12.2.0")
libpeci| C++ linker for the host machine: c++ ld.mold 1.10.1
libpeci| Dependency sdbusplus found: YES 1.0.0 (cached)
libpeci| Dependency systemd found: YES 252 (cached)
libpeci| Dependency boost found: YES 1.81.0 (cached)
libpeci| Build targets in project: 664
libpeci| Subproject libpeci finished.

WARNING: Variable 'peci_dep' in the subproject 'subprojects/libpeci' is not found
Dependency libpeci from subproject subprojects/libpeci found: NO

src/meson.build:64:15: ERROR: Dependency 'libpeci' is required but not found.
```

After:

```
$ meson setup build
...
Executing subproject libpeci

libpeci| Project name: libpeci
libpeci| Project version: 1.0
libpeci| C compiler for the host machine: ccache cc (gcc 12.2.0 "cc (Debian 12.2.0-14) 12.2.0")
libpeci| C linker for the host machine: cc ld.mold 1.10.1
libpeci| C++ compiler for the host machine: ccache c++ (gcc 12.2.0 "c++ (Debian 12.2.0-14) 12.2.0")
libpeci| C++ linker for the host machine: c++ ld.mold 1.10.1
libpeci| Dependency sdbusplus found: YES 1.0.0 (cached)
libpeci| Dependency systemd found: YES 252 (cached)
libpeci| Dependency boost found: YES 1.81.0 (cached)
libpeci| Build targets in project: 664
libpeci| Subproject libpeci finished.

Dependency libpeci from subproject subprojects/libpeci found: YES 1.0
...
```

Change-Id: I18f9e89a25c184d7fdc38aea01ff5dbee118a974
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

Utils: Include charconv to fix std::from_chars_result failure

Building `dbus-sensors` outside of a bitbake environment I see the
following:

```
../src/Utils.cpp: In function ‘bool getDeviceBusAddr(

Utils: Include charconv to fix std::from_chars_result failure

Building `dbus-sensors` outside of a bitbake environment I see the
following:

```
../src/Utils.cpp: In function ‘bool getDeviceBusAddr(const std::string&, size_t&, size_t&)’:
../src/Utils.cpp:865:10: error: ‘from_chars_result’ is not a member of ‘std’
865 | std::from_chars_result res{};
| ^~~~~~~~~~~~~~~~~
../src/Utils.cpp:866:5: error: ‘res’ was not declared in this scope
866 | res = std::from_chars(&*busStr.begin(), &*busStr.end(), bus);
| ^~~
../src/Utils.cpp:866:16: error: ‘from_chars’ is not a member of ‘std’
866 | res = std::from_chars(&*busStr.begin(), &*busStr.end(), bus);
| ^~~~~~~~~~
../src/Utils.cpp:872:16: error: ‘from_chars’ is not a member of ‘std’
872 | res = std::from_chars(&*addrStr.begin(), &*addrStr.end(), addr, 16);
| ^~~~~~~~~~
```

Include charconv to define the type.

Change-Id: I0e1aab8707f97f3acc3076fa8304dbafb27711de
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

PSUSensor: add adc128d818 support

add device adc128d818 pmbus reading support

Tested:
Get adc128d818 reading from PSUSensor by dbus introspect

Change-Id: Ie03ed2d8874f3026f18e6aa81063bd276b91d52c

PSUSensor: add adc128d818 support

add device adc128d818 pmbus reading support

Tested:
Get adc128d818 reading from PSUSensor by dbus introspect

Change-Id: Ie03ed2d8874f3026f18e6aa81063bd276b91d52c
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

show more ...

dbus-sensors: utils: Utility to get device bus & addr from dev name.

This is applicable to all the services which rely on "bus-addr" fmt.
1. FanSensor
2. HwmonTempSensor
3. IntelCPUSensor
4. PSUSens

dbus-sensors: utils: Utility to get device bus & addr from dev name.

This is applicable to all the services which rely on "bus-addr" fmt.
1. FanSensor
2. HwmonTempSensor
3. IntelCPUSensor
4. PSUSensor

In addition this would also fix Fansensor Daemon crashes due to
stoi() exceptions weren't caught earlier.

For example: In a FanSensor Daemon -
Device of f0103000.pwm-fan-controller would be classified as i2cfan
based on new way of defining fan type.
Hence when we parse string for bus-addr, bus=f0103000.pwm and
addr=fan-controller for which stoi() would crash.
This would be true for all non I2c devices defaulting to I2cFan type.

Solution is to use 'std::from_chars' which handles under/overflow
properly. Centralizing this now in Utils would also allow us to manage
this appropriatelty across various services.

Tested:
Tested sanity of all daemons in the system and they work as expected.

Change-Id: I546e967abae7c0fb9fca645867e3037046037647
Signed-off-by: Akshit Shah <shahakshit@google.com>

show more ...

hwmontemp: Fix NULL pointer dereference

When createSensors() is called with activateOnly set to false
and a sensor does not have a hwmonFile it is added as nullptr
to sensors array.

This causes int

hwmontemp: Fix NULL pointer dereference

When createSensors() is called with activateOnly set to false
and a sensor does not have a hwmonFile it is added as nullptr
to sensors array.

This causes interfaceRemoved() to crash as it dereferences
that sensor without first checking if it's null.

Tested: hwmontempsensor no longer crashes when some random
interface is removed.

Change-Id: I8f63f753cca7341be5a0683e7b446f63ae92f8cb
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

show more ...

hwmontempsensor: Add support for ADM1021

Add support for ADM1021 I2C temperature sensors.

Tested: The temperature is visible in the webui.

Change-Id: Ic50822df39d2c3930e25b64a1d1bc8ec2234395f
Sign

hwmontempsensor: Add support for ADM1021

Add support for ADM1021 I2C temperature sensors.

Tested: The temperature is visible in the webui.

Change-Id: Ic50822df39d2c3930e25b64a1d1bc8ec2234395f
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>

show more ...

psusensor: Add extra CPU presence logic

In the case of the psusensor service restarting we still need to check
for CPU presence. This adds a handler that will get the number of CPUs
that the BMC ha

psusensor: Add extra CPU presence logic

In the case of the psusensor service restarting we still need to check
for CPU presence. This adds a handler that will get the number of CPUs
that the BMC has in inventory.

Tested:
CPU presence map gets populated correctly.

Change-Id: I17caba6cb602d34852270035fbbf71f3095b96be
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

ADCSensor: Add debug flag to not print debug log

Not all input files under the hwmon produce readings and is required to
be monitored, so these logs should be debug log.

Tested:
The sensor will not

ADCSensor: Add debug flag to not print debug log

Not all input files under the hwmon produce readings and is required to
be monitored, so these logs should be debug log.

Tested:
The sensor will not show debug log in machine.
Change-Id: I31fb7e41514ecba1da3ee01d52f3d4ed381328e6
Signed-off-by: Jeff Lin <JeffLin2@quantatw.com>

show more ...

Fix libpeci build

libpeci recently moved to meson. The detection logic here wasn't
working, and would always fall back to a custom build using cmake.

Replace with a simple dependency call.

Change

Fix libpeci build

libpeci recently moved to meson. The detection logic here wasn't
working, and would always fall back to a custom build using cmake.

Replace with a simple dependency call.

Change-Id: Ica52e81da1d8f2d0215a58aa4790c1154fa24810
Signed-off-by: Ed Tanous <edtanous@google.com>

show more ...

intrusionsensor: Add Rearm property

This patch adds Rearm property to intrusionsensor service, under
"xyz.openbmc_project.Chassis.Intrusion" interface, to specify the method
for rearming the chassis

intrusionsensor: Add Rearm property

This patch adds Rearm property to intrusionsensor service, under
"xyz.openbmc_project.Chassis.Intrusion" interface, to specify the method
for rearming the chassis cover and updating the "Status" property.
As defined in Redfish schema specification, this property is optional.
If not set, "Rearm" will default to "Automatic", which will directly
update the raw chassis intrusion status to the "Status" property.
If set to "Manual", after an intrusion event, the "Status" property
will be kept to "HardwareIntrusion" until a reset action happens for it
to be set to "Normal" (manual rearm). The rearm action comes from
Redfish by writing "Normal" to the "IntrusionSensor" property in
/redfish/v1/Chassis/chassis.

Example:
{
"Class": "Aspeed2600_Hwmon",
"Name": "Chassis_Intrusion_Status",
"Rearm": "Manual",
"Type": "ChassisIntrusionSensor"
}

Tested: This has been tested on Ampere's Mt.Mitchell platform using
hwmon reading method (property values below need to be prefixed with
strings "xyz.openbmc_project.Chassis.Intrusion.Status." and
"xyz.openbmc_project.Chassis.Intrusion.RearmMode." respectively for
Status and Rearm to achieve the real values on DBus).

Automatic mode (default):
1. The chassis cover is closed => the Status property shows "Normal"
2. The chassis cover is open => Status shows "HardwareIntrusion"

Manual mode:
1. The chassis cover is first open from the last rearm action =>
"HardwareIntrusion"
2. The chassis cover is closed => "HardwareIntrusion"
3. The chassis cover is open again => "HardwareIntrusion"
4. The rearm action is taken => "Normal"
5. The chassis cover is closed => "Normal"

Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: I8257a5fee9db67a072e7fafc140f6a143028c429

show more ...

PSUSensor: add IIO device sensor

Support IIO device on D-bus via dbus-sensors, expose path to support
multi-channel labels.
Reference:
https://gerrit.openbmc.org/c/openbmc/dbus-sensors/+/47822

This

PSUSensor: add IIO device sensor

Support IIO device on D-bus via dbus-sensors, expose path to support
multi-channel labels.
Reference:
https://gerrit.openbmc.org/c/openbmc/dbus-sensors/+/47822

This patch is able to support the IIO device ADS1015
Use with this patch.
https://gerrit.openbmc.org/c/openbmc/entity-manager/+/58505

Json config
{
"Address": "0x49",
"Bus": 11,
"Labels": [
"in_voltage1",
"in_voltage2"
],
"Name": "vr_prnt_cem",
"EntityId": "0x07",
"EntityInstance": "0x17",
"in_voltage1_Name": "vr_prnt_msas1",
"in_voltage1_Scale": 1000,
"in_voltage2_Name": "vr_prnt_msas2",
"in_voltage2_Scale": 1000,
"PowerState": "On",
"Thresholds": [
{
"Direction": "greater than",
"Label": "in_voltage1",
"Name": "upper critical",
"Severity": 1,
"Value": 2.0
},
{
"Direction": "less than",
"Label": "in_voltage1",
"Name": "lower critical",
"Severity": 1,
"Value": 0.0
},
{
"Direction": "greater than",
"Label": "in_voltage2",
"Name": "upper critical",
"Severity": 1,
"Value": 2.0
},
{
"Direction": "less than",
"Label": "in_voltage2",
"Name": "lower critical",
"Severity": 1,
"Value": 0.0
}
],
"in_voltage1_Max": 2.0,
"in_voltage1_Min": 0.0,
"in_voltage2_Max": 2.0,
"in_voltage2_Min": 0.0,
"PollRate": 1.0,
"Type": "ADS1015"
}

Tested:
root@qbmc:~# busctl tree xyz.openbmc_project.EntityManager |grep msas
|-/xyz/openbmc_project/inventory/system/board/Yertle/vr_prnt_msas1
`-/xyz/openbmc_project/inventory/system/board/Yertle/vr_prnt_msas2

root@qbmc:~# busctl tree xyz.openbmc_project.PSUSensor
`-/xyz
`-/xyz/openbmc_project
|-/xyz/openbmc_project/control
`-/xyz/openbmc_project/sensors
`-/xyz/openbmc_project/sensors/voltage
|-/xyz/openbmc_project/sensors/voltage/vr_prnt_msas1
`-/xyz/openbmc_project/sensors/voltage/vr_prnt_msas2

root@qbmc:~# busctl get-property xyz.openbmc_project.PSUSensor \
/xyz/openbmc_project/sensors/voltage/vr_prnt_msas1 \
xyz.openbmc_project.Sensor.Value Value
d 1.72

Signed-off-by: Joseph Fu <joseph.fu@quantatw.com>
Change-Id: I584f5d79850921e702b8572fb6b38e9dcfc44d25

show more ...

psusensor: add error handling for all err code

In psusensor handleResponse check for all non 0 error code and read
bytes equal 0, skip parse read data and start waitTimer to try again.
Without this

psusensor: add error handling for all err code

In psusensor handleResponse check for all non 0 error code and read
bytes equal 0, skip parse read data and start waitTimer to try again.
Without this change, sometimes psusensor would log a read error when
power state is off and the sensor requires power state to be on, which
is non desirable.

Tested:
No more read error message in the journal log when system power state
is off.

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: I228de0d454862335ccaa42c1fb12efc08da55084

show more ...

psu-sensor: Add devmgmt and powercallback to PSU

Some PSU sensors are dependent on system power state.
Without change the device initialization would fail and
dbus-sensors and entity-manager wouldn'

psu-sensor: Add devmgmt and powercallback to PSU

Some PSU sensors are dependent on system power state.
Without change the device initialization would fail and
dbus-sensors and entity-manager wouldn't come back to
properly instantiate.

Same intention as this hwmontempsensor change: https://github.com/openbmc/dbus-sensors/commit/a1456c4abafc697e7caa6b8e95ac9ddb35c4e7d1

Tested: Same sensors are getting created. Sensors are
getting created/destroyed on host power events based
on their PowerState.

Signed-off-by: Matt Simmering <matthew.simmering@intel.com>
Change-Id: I3ee719cf65df225f964148d3994eec4d758d72a1

show more ...

intelcpusensor: Update DIMM presence check

Some Intel CPUs will use 0xFF to indicate DIMMs not being present. Add
this check before setting dimmReady. We should be safe checking against
0 and 0xFF

intelcpusensor: Update DIMM presence check

Some Intel CPUs will use 0xFF to indicate DIMMs not being present. Add
this check before setting dimmReady. We should be safe checking against
0 and 0xFF since these shouldn't be actual temperatures in the field.

Also remove the check on pkgConfig[2] because bits 23:16 are reserved.

Tested: intelcpusensor doesn't set dimmReady too early in case of
Intel CPUs setting PCS 14 to 0xFFFF

Change-Id: If943736d3798d02dea17139f408572d80eb74e33
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

hwmontempsensor: Move instantiateDevices

Move instantiateDevices to DeviceMgmt.hpp as a template function.
This way other sensors can leverage this functionality.

Tested:
Same hwmon temp devices ar

hwmontempsensor: Move instantiateDevices

Move instantiateDevices to DeviceMgmt.hpp as a template function.
This way other sensors can leverage this functionality.

Tested:
Same hwmon temp devices are getting instantiated.

Change-Id: I5d932ea57fa67809232a92fc769cd66a17a0cc70
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

psusensor: support ibm cffps driver

certain PSU's, like ACBEL R1CA2122A do not comply with the mechanism
that 'pmbus' driver uses to discover the number of pages.

In that case, the hwmon directory

psusensor: support ibm cffps driver

certain PSU's, like ACBEL R1CA2122A do not comply with the mechanism
that 'pmbus' driver uses to discover the number of pages.

In that case, the hwmon directory is filled with garbage sensors,
and hardcoding the number of pages is required.

IBM cffps driver hardcodes the number of pages. This commit is to
support using this driver in EM config.

Tested: on Tyan s8030 Board with before mentioned powersupplies.

Change-Id: I8288f183b115b8a3e9dd3bb93dcde3b6950739ac
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

IntelCPUSensor: support new Linux PECI API

The upstream PECI bus implementation doesn't support any ioctl() or
other means to send and receive PECI messages directly from the
userspace, instead it o

IntelCPUSensor: support new Linux PECI API

The upstream PECI bus implementation doesn't support any ioctl() or
other means to send and receive PECI messages directly from the
userspace, instead it only provides regular kernel-level abstractions
(just hwmon CPU and DIMM temperature devices for now). It also requires
the userspace to trigger bus rescan after the CPU(s) are powered on.

This patch makes IntelCPUSensor automatically detect and use the new
API.

Change-Id: Icbd568aeeca6428a9fade12416e260741a76213c
Signed-off-by: Paul Fertser <fercerpav@gmail.com>

show more ...

intelcpusensor:always unlock peci fd in detectCPU

Currently, intelcpusensor can leave peci fd locked after detectCPU call.
This causes lock to fail for the next detectCPU call. It also can cause
ker

intelcpusensor:always unlock peci fd in detectCPU

Currently, intelcpusensor can leave peci fd locked after detectCPU call.
This causes lock to fail for the next detectCPU call. It also can cause
kernel issues, when driver is unbound and application keeps the file open
(since peci_unlock is not called it keeps) - the kernel structures remain
in memory. Which means, that on application stop (during reboot or for
any reason) the kernel warnings/errors will appear.

Tested:
intelcpusensor journal log does not have below error message anymore
"intelcpusensor[31213]: PECI device failed to unlock."

Change-Id: Ib2e7682d5f9a25124aeb340cc5cdb5375b4d773d
Signed-off-by: Wang Xiaohua <wangxiaohua.1217@bytedance.com>
Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>

show more ...

IntelCPUSensor: retry when hwmon nodes not found

Due to the dynamic nature of loading kernel modules and creating hwmon
devices it makes sense to retry searching for the suitable hwmon nodes
as they

IntelCPUSensor: retry when hwmon nodes not found

Due to the dynamic nature of loading kernel modules and creating hwmon
devices it makes sense to retry searching for the suitable hwmon nodes
as they might appear later.

This is needed with the current upstream Linux PECI support code.

Change-Id: I4ce1585010bddc5b2162c3f64aae87006fe9a179
Signed-off-by: Paul Fertser <fercerpav@gmail.com>

show more ...

Add uring_args for all build targets in package

io_uring backend is enabled with uring_args. Add them to package args.
All build targets including static libraries for utils and thresholds
and senso

Add uring_args for all build targets in package

io_uring backend is enabled with uring_args. Add them to package args.
All build targets including static libraries for utils and thresholds
and sensor services executables are built consistently.

Currently steady timer in utils.cpp fires right away for services build
with io_uring enabled like fansensor, hwmontempsensor.
https://github.com/openbmc/dbus-sensors/blob/master/src/Utils.cpp#L472

Tested:
Added debug print and verified the above timer handler is called 10
seconds after the timer is started as expected. intelcpusensor, which
does not use random_access_file with io_uring backend reads sensor
values successfully. Services use random_access_file read sensor data
successfully.

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: I8cf3a9a0d1ffca459eb6c2c37e4e2220ce5100ac

show more ...

Revert "fix formatting issues in CI"

This reverts commit a704a8f7391053f11c3479df1c4cce12e5cc6905.
CI build is broken with this commit

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: I0

Revert "fix formatting issues in CI"

This reverts commit a704a8f7391053f11c3479df1c4cce12e5cc6905.
CI build is broken with this commit

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: I02dc3ee2dedc53c34fb7c13801300c6480d16444

show more ...

fix formatting issues in CI

Change-Id: Ib0e14adf4255017aa15329acb51ae7a23d259197
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>