Make dbus-sensors compile with clang-13

clang-13 finds a lot more warnings for unused variables than it used to,
and also picks up some warnings about errant std::moves that are in
p

Make dbus-sensors compile with clang-13

clang-13 finds a lot more warnings for unused variables than it used to,
and also picks up some warnings about errant std::moves that are in
place.

This commit fixes them.

Tested:
code compiles against clang-13

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I80864287b7131acfe936c4b28afaf34ababb3029

show more ...

Modify set-value function from external

Move Special mode from bmcweb to dbus-sensors, this will be handled via dbus-sensor when the user set-value f$
This is unlikely to break a

Modify set-value function from external

Move Special mode from bmcweb to dbus-sensors, this will be handled via dbus-sensor when the user set-value f$
This is unlikely to break any users because the Intel special mode function is no change, only move to dbus-s$

The set value function is to filter the external set, excluding the internal set.
In the external set, if in INSECURE_UNRESTRICTED_SENSOR_OVERRIDE, no need to check before set value else add $

bmcweb needs to be merged at the same time.
bmcweb changes are pushed to Gerrit:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/42448

the mailing list discussion links:
https://lists.ozlabs.org/pipermail/openbmc/2021-March/025597.html

Signed-off-by: Bruce Lee <Bruce_Lee@quantatw.com>
Change-Id: I0919e4d2343e81045010a2b0d4bf01dc272bcb07

show more ...

Add Unit property to dbus interfaces

Previously, the lack of the Unit property on the Value interfaces
provided by dbus-sensors meant that readings from its sensors weren't
displayed

Add Unit property to dbus interfaces

Previously, the lack of the Unit property on the Value interfaces
provided by dbus-sensors meant that readings from its sensors weren't
displayed in phosphor-webui/webui-vue. Here it's added as an extra
parameter to setInitialProperties, allowing sensors that handle multiple
types of data (e.g. IpmbSensor, PSUSensor) to determine the appropriate
string to pass once they've had time to determine that.

Tested: PSUSensor, ADCSensor, CPUSensor, TachSensor, and HwmonTempSensor
all have an appropriate Unit property available on dbus, and are
displayed in webui-vue.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I5e6df74cc42d9fb84852c5bf3ea5d3b383a16cdc

show more ...

Fix thresholds not found

Due to the same attribute name "thresholds" in class 'ADCSensor' and
'Sensor', the function hasWarningInterface use this parameter from class
ADCSensor and c

Fix thresholds not found

Due to the same attribute name "thresholds" in class 'ADCSensor' and
'Sensor', the function hasWarningInterface use this parameter from class
ADCSensor and cause it can not found the correct thresholds.

Rename the "thresholds" to "thresholdsIn" to avoid this problem.

Tested: Add thresholds to adc, cpu, hwmon and fan sensor and verify pass.

Signed-off-by: Jeff Lin <JeffLin2@quantatw.com>
Change-Id: I6a8a5f7036dd9f195a7848ff03fa5f51966c2d2d

show more ...

add clang-tidy

This commit implements a clang-tidy file, and makes some changes to get
it to pass. Most changes are naming or mechanical in nature.

Tested:
Clang-tidy now p

add clang-tidy

This commit implements a clang-tidy file, and makes some changes to get
it to pass. Most changes are naming or mechanical in nature.

Tested:
Clang-tidy now passes.

Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: Ia441e4801b6c8725421d160c531c5df141f255d4

show more ...

Add LED Support to Fan Sensor

This allows the fan sensor to trip an LED when a critical
threshold is crossed.

Tested: Saw LED d-bus object in Group manager get set
using sen

Add LED Support to Fan Sensor

This allows the fan sensor to trip an LED when a critical
threshold is crossed.

Tested: Saw LED d-bus object in Group manager get set
using sensor override

Change-Id: Iab5a69ded20de6e3ac99e9ac687c60605d5763d1
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Move dbus connection into base sensor object

This seems common through most sensors, might as
well move it for consistency.

Tested: sensors operational as normal

Change

Move dbus connection into base sensor object

This seems common through most sensors, might as
well move it for consistency.

Tested: sensors operational as normal

Change-Id: I4e6c55cbb7171ee51700015f8c2ef8c05c90fb4e
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

revert "revert log debug information for sensor threshold assert events"

Add back the orignial submit 9bf6804c2d76b92005ad9851cb052d407ea3117f
and includes the fix the bug that crashed i

revert "revert log debug information for sensor threshold assert events"

Add back the orignial submit 9bf6804c2d76b92005ad9851cb052d407ea3117f
and includes the fix the bug that crashed ipmbsensor.

log debug information for sensor threshold assert events

There are sightings that TCPUx_P12_PVCCIO_VS_Temp Sensor
reports reading of zero and trips the low critical threshold.
Add debug prints to gather data.

Also add logs for raw value in sensor base class to help
debug threshold assert events for other sensor type.

Tested:
Verified that log messages show up as expected for threshold
assert events. There is no unwanted log messages on systems that
do not have bad sensor readings.
Verified system stayed up for 30 minutes without crashing.

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: I73e00e24bbae463dbe0f34e2308ee934588028d1

show more ...

Revert "log debug information for sensor threshold assert events"

This reverts commit 9bf6804c2d76b92005ad9851cb052d407ea3117f.
This causes ipmbsensor crash

Change-Id: I8517d801

Revert "log debug information for sensor threshold assert events"

This reverts commit 9bf6804c2d76b92005ad9851cb052d407ea3117f.
This causes ipmbsensor crash

Change-Id: I8517d801ea1598b190c140f317ef29d1bc172ee0
Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>

show more ...

log debug information for sensor threshold assert events

There are sightings that TCPUx_P12_PVCCIO_VS_Temp Sensor
reports reading of zero and trips the low critical threshold.
Add de

log debug information for sensor threshold assert events

There are sightings that TCPUx_P12_PVCCIO_VS_Temp Sensor
reports reading of zero and trips the low critical threshold.
Add debug prints to gather data.

Also add logs for raw value in sensor base class to help
debug threshold assert events for other sensori type.

Tested:
Verified that log messages show up as expected for threshold
assert events. There is no unwanted log messages on systems that
do not have bad sensor readings.

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: Ib0557e804d275fbb3dce3347b4abec696925cc67

show more ...

TachSensor: Accept PowerState from configuration

Accept the PowerState configuration parameter,
similar to other sensors.
This allows it to optionally be set to "Always",
while s

TachSensor: Accept PowerState from configuration

Accept the PowerState configuration parameter,
similar to other sensors.
This allows it to optionally be set to "Always",
while still preserving the default of "On".

Some systems have their chassis fans not tied to host power,
so they can continue working, even when host powered off,
and "Always" allows the BMC to continue to monitor them.

Tested: Without this patch, or set to "On",
the tachometers show RPM of 0,
even though the fans are still running correctly,
when host is powered off (but BMC and chassis fans
still have power). After this patch, and setting "Always",
the tachometers once again indicate proper RPM.

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: I1774f0bec180f52e18d37500fcdd87d32620d519

show more ...

Fix missing includes

Likey due to
https://github.com/openbmc/sdbusplus/commit/38ab5ecfe3c51501a9380e2c30dbb5fdd88cf4f9

many boost features that were missing from being included

Fix missing includes

Likey due to
https://github.com/openbmc/sdbusplus/commit/38ab5ecfe3c51501a9380e2c30dbb5fdd88cf4f9

many boost features that were missing from being included
made the build stop working. Fix them.

Change-Id: I0ef7fff6b38bd5589a4955fe8f2d892e366406b2
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Standardize read errors

Each sensor handled read errors their own way,
making it inconsistant. This helps to align them all
in the base class, so that error handling happens the

Standardize read errors

Each sensor handled read errors their own way,
making it inconsistant. This helps to align them all
in the base class, so that error handling happens the
same for each sensor. It also aligns the power state
change handling.

Tested: Tested DC Cycling and Enabling/Disabling ME to
make sure functional change correctly

Change-Id: I1a191d27629602e1ca3871d933af07b15bf9f331
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Update clang format

Update to clang-format-10

Change-Id: I7fcab706fb384e5fcc07a06c42897a5ddbc4b511
Signed-off-by: James Feist <james.feist@linux.intel.com>

Cleaned up usage of updateValue() callers

Removed needless float, simply using double
Corrected string parsing function called for each type
Callers no longer need to check for equal

Cleaned up usage of updateValue() callers

Removed needless float, simply using double
Corrected string parsing function called for each type
Callers no longer need to check for equality first
Equality test now added to int and string override methods
This ensures all have same semantics
Removed extraordinarily spammy debug in updateValue(double)

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: If8422d6516e083041685ddb6ef8cd469299cbad3

show more ...

convert sysfs gpio usage to libgpiod

Updated Fan presence sensor monitoring call back
to use pin name and gpiod APIs. Number based sysfs
framework is deprecated and replaced by descr

convert sysfs gpio usage to libgpiod

Updated Fan presence sensor monitoring call back
to use pin name and gpiod APIs. Number based sysfs
framework is deprecated and replaced by descriptor
based gpiod framework. With named gpio pin,
code is more portable provided the device tree
defines GPIO pin name consistently.

This requires device tree change (225598) and
configuration file change (entity-manager/+/28119)

Tested By:
remove and insert fans and observe fan presence
status change on dbus fan sensor objects

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: Ice17a472285373ce866132ccc0da02cd1e70ddbe

show more ...

fix warnings

Fix a couple warnings so we can use meson warning level 3. Instances of
the following warnings are found and resolved:

Wreorder
Wsign-compare

Chan

fix warnings

Fix a couple warnings so we can use meson warning level 3. Instances of
the following warnings are found and resolved:

Wreorder
Wsign-compare

Change-Id: Ia223b42aa6bf743cfa0e7042cc3d5a18977459be
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

src: add missing headers

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I6043ef792c2ce0a8e7584a73f83ca365ec61794d

Fix file descriptor checking

'0' is also a valid file descriptor so this commit fixes incorrect
checks on fd after opening a file. Actually, fd 0, 1 and 2 will be
assigned to stdin,

Fix file descriptor checking

'0' is also a valid file descriptor so this commit fixes incorrect
checks on fd after opening a file. Actually, fd 0, 1 and 2 will be
assigned to stdin, stdout and stderr respectively so this patch
doesn't fix any issue but it's for code consistency.

Tested: Detecting and reading sensors worked well.

Change-Id: I2626a0b92352257d1c294a61ca385f95568dae7d
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

show more ...

Fix Association interface

Mapper changed to only allow the new interface, update
to it.

Tested: Mapper showed all associations

Change-Id: I8b252c70e9f27b083a438393c731f

Fix Association interface

Mapper changed to only allow the new interface, update
to it.

Tested: Mapper showed all associations

Change-Id: I8b252c70e9f27b083a438393c731fbeb3e2ca0e5
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

TachSensor: Add threshold power check

This fixes extra SEL on ipmitool power cycle

tested: ipmitool power cycle very fast 10 times, no sel

Change-Id: I8ae1e080f5a614efb083a

TachSensor: Add threshold power check

This fixes extra SEL on ipmitool power cycle

tested: ipmitool power cycle very fast 10 times, no sel

Change-Id: I8ae1e080f5a614efb083a163ea1e4b69d58c2aed
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Turn on a bunch of warnings

Turn on as many warnings as easily possible from:
https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_

Turn on a bunch of warnings

Turn on as many warnings as easily possible from:
https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md#L100

Tested:
ipmitool sensor list still works

Change-Id: Ied8fa66de9fcd25e448f8048c4f8216b426b6f55
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Update Associations For bmcweb changes

Updating according to
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/22976

Tested: Thermal had all fans, and presence worked.

Update Associations For bmcweb changes

Updating according to
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/22976

Tested: Thermal had all fans, and presence worked.

Change-Id: I03e1e13b3a9c2f6d2ac4b7afc6e2723c04597931
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Follow up on Todo, move path out of base sensor

Not every sensor needs a sysfs path, because of that
move it out of the base class and into the classes that
need it.

Change-

Follow up on Todo, move path out of base sensor

Not every sensor needs a sysfs path, because of that
move it out of the base class and into the classes that
need it.

Change-Id: I62b7df681e1ee889eb66e371d1cd6094097e9f21
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

cpusensor: detect if cpu is available

Add CPU inventory item detection via gpio.

Tested: inventory item is exposed

Change-Id: Ia26a4bed5534edec6a7f5c7cf0965f84fa0fc23a

cpusensor: detect if cpu is available

Add CPU inventory item detection via gpio.

Tested: inventory item is exposed

Change-Id: Ia26a4bed5534edec6a7f5c7cf0965f84fa0fc23a
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...