Filter ADC threshold crossings

When power goes down we get bad events because the
voltage rail spins down faster than pgood. Add in
a delay to check power 2 seconds after the event to
make sure powe

Filter ADC threshold crossings

When power goes down we get bad events because the
voltage rail spins down faster than pgood. Add in
a delay to check power 2 seconds after the event to
make sure power isn't going down.

Tested-by: power cycled and extra SEL went away

Change-Id: Ib820ccb50d1a949b8096f08e2711ad7a7c36087b
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Exit Air: Allow destruction

In the current mode a configuration reload would not
cause thresholds to update. Allow destruction so we
reload the interfaces each time.

Change-Id: I1fec9c6fc9ae1a20a95

Exit Air: Allow destruction

In the current mode a configuration reload would not
cause thresholds to update. Allow destruction so we
reload the interfaces each time.

Change-Id: I1fec9c6fc9ae1a20a95477157ad399c73e3f9c75
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Improve cpusensor performance

The cpusensor service is still making some redundant accesses for
reading hwmon attributes on every scanning. Actually, threshold
update is needed only when CPU package

Improve cpusensor performance

The cpusensor service is still making some redundant accesses for
reading hwmon attributes on every scanning. Actually, threshold
update is needed only when CPU package's Tcontrol target is
changed so this commit make it do that only when Tcontrol value
is changed.

Tested:
Compare cpu resource consumption of cpusensor service using top.
It should eat less cpu resources than before.

Change-Id: Ieb582996fc5c9c07abbfc7ac0d1b37f593269d00
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

show more ...

Fix threshold updating

The object type was never stored so it was never
updated. Also change threshold size to count of
thresholds for if anything has multiple thresholds.

Tested-by: set thresholds

Fix threshold updating

The object type was never stored so it was never
updated. Also change threshold size to count of
thresholds for if anything has multiple thresholds.

Tested-by: set thresholds for front panel temp

Change-Id: I0949261b87336eb4a85cf596805c02683fb30d9b
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add chassis intrusion sensor daemon

Chassis intrusion signal is read from PCH via I2C or from GPIO.
Create a new daemon to poll its status and expose to dbus.

Related patches to run test:
- meta-ph

Add chassis intrusion sensor daemon

Chassis intrusion signal is read from PCH via I2C or from GPIO.
Create a new daemon to poll its status and expose to dbus.

Related patches to run test:
- meta-phosphor: dbus-sensors: Enable new service of intrusion sensor
https://gerrit.openbmc-project.xyz/#/c/openbmc/meta-phosphor/+/17063/
- redfish: chassis: add property of physical security
https://gerrit.openbmc-project.xyz/#/c/openbmc/bmcweb/+/17691/

Tested-by: Check intrusion status value by redfish,
verified PCH solution on WFP and GPIO solution on STP.

Change-Id: Id5e67abbd80bbf2ef502db49fa183d92d0d31bda
Signed-off-by: Qiang XU <qiang.xu@linux.intel.com>

show more ...

Add threshold value scanning logic into cpusensor

Threshold values of a CPU sensor can be changed at runtime by BIOS
based on the thermal policy changes of the host machine. So this
commit adds runt

Add threshold value scanning logic into cpusensor

Threshold values of a CPU sensor can be changed at runtime by BIOS
based on the thermal policy changes of the host machine. So this
commit adds runtime scanning logic for reading threshold values
from hwmon subsystem attributes.

Tested:
Check threshold properties in xyz.openbmc_projects.CPUSensor.
All threshold vaues should reflect peci hwmon values dynamically.

Change-Id: Ib5b0ce72f567437e69879a7e655d6f34f156013e
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

show more ...

ipmbsensor: resend init command every boot

This stops the ipmi response from being na after
ipmitool power cycle.

Tested-by: Power cycled 5 times and sensors never
went to na

Change-Id: Ida6ac3978

ipmbsensor: resend init command every boot

This stops the ipmi response from being na after
ipmitool power cycle.

Tested-by: Power cycled 5 times and sensors never
went to na

Change-Id: Ida6ac397805b9eb47025e0227e2d15fcc26bb045
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Update clang format

Style only change

Change-Id: I41c97cbfb6a0ebf155a34166bc627f49a398442b
Signed-off-by: James Feist <james.feist@linux.intel.com>

Move variant usage to std

Since sdbusplus now uses std, it's cleaner just to
use the variant type directly not behind the namespace.

This was primarily done with sed commands

Tested-by: It builds

Move variant usage to std

Since sdbusplus now uses std, it's cleaner just to
use the variant type directly not behind the namespace.

This was primarily done with sed commands

Tested-by: It builds

Change-Id: I87a90a2942cfc6da312cb0e045cce7cd40a644e5
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add bios post checking support

Some sensors aren't available until after bios post
add support to check for post when needed.

Tested-by: SSB temp no longer asserted thresholds before
bios post.

Ch

Add bios post checking support

Some sensors aren't available until after bios post
add support to check for post when needed.

Tested-by: SSB temp no longer asserted thresholds before
bios post.

Change-Id: I9251c2c501e082ef4bb0e9eb7909dc137771e120
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Fix Exit Air Temp Sensor

Add custom destructor for CFM sensor as it is configuration
driven and can be destroyed unlike exit air. Having this not
have a destructor caused the old sensor loop to keep

Fix Exit Air Temp Sensor

Add custom destructor for CFM sensor as it is configuration
driven and can be destroyed unlike exit air. Having this not
have a destructor caused the old sensor loop to keep running
and not be destroyed. Also attempt to pre-populate inlet temp
as it doesn't get updated as frequently as tach readings.

Tested-by: sensor list started to work again and readings
were appropriate.

Change-Id: Id5b42a73a22ff860149ced1ba073d81fe84a9375
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add Ipmb Sensor

Add daemon responsible for polling ipmb for sensor
readings. Currently base ME and VR bridge sensors
are supported. This daemon uses ipmbd to get sensor
readings.

Tested-by: Saw cor

Add Ipmb Sensor

Add daemon responsible for polling ipmb for sensor
readings. Currently base ME and VR bridge sensors
are supported. This daemon uses ipmbd to get sensor
readings.

Tested-by: Saw correct readings on d-bus and verified
sensor list.

Change-Id: I71c216ae57567470d42180dce76aba8f69ecb50e
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Fix bad sed

filesystem should not have had .hpp added to it.

Change-Id: I46306cf1cc63070831c3b8410049a602c978f0f7
Signed-off-by: James Feist <james.feist@linux.intel.com>

Move filesystem out of experimental namespace

This fix is needed for gcc8. Also fix out of tree build
warning looking for sdbusplus instead of sdbusplus-project.

Change-Id: I2a476ddc9e26154fed23d39

Move filesystem out of experimental namespace

This fix is needed for gcc8. Also fix out of tree build
warning looking for sdbusplus instead of sdbusplus-project.

Change-Id: I2a476ddc9e26154fed23d3992016a6e1056f7a12
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Clean up power state handling and fix voltage events

Seperate isPowerOn into two functions, one to set up the
match and one to poll the boolean. This way a dbus connection
object isn't needed in the

Clean up power state handling and fix voltage events

Seperate isPowerOn into two functions, one to set up the
match and one to poll the boolean. This way a dbus connection
object isn't needed in the sensor. Use this new function to
allow the ADCSensor to only signal threshold crosses if the
sensor is in the correct state.

Tested-by: Verified no SEL events for ADC sensors were created
during power cycling.

Change-Id: Ida800ab478b85ac2cb5976fa3471411c5d4bdc88
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Move LoadVariant into Utils

It seems useful in other daemons and is really a
utility.

Change-Id: Iebf3b0dcf5b2981c5f1832b59014772387a656b8
Signed-off-by: James Feist <james.feist@linux.intel.com>

Consider nan too as an override value

Sensors can be overridden for testing purpose. Start treating
nan too as an override value. With this commit, the only way
to reset the override is to restart t

Consider nan too as an override value

Sensors can be overridden for testing purpose. Start treating
nan too as an override value. With this commit, the only way
to reset the override is to restart the service / BMC F/W.

Unit-test:
1. Verified that overriden value is taken effect by setting the value
property
2. Tried setting nan to the value property and verified it's still
in overriden state.

Change-Id: I6a931377bdaf918e37057275e1dde93f0fd5aa22
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

FanSensor: Add configurable min max

Allow Min and Max reading to be configured

Tested-by: Set a fan to a different Min and it worked.

Change-Id: Ibeebcaa9672d7a9cd9511c3845f5b317db8962c8
Signed-of

FanSensor: Add configurable min max

Allow Min and Max reading to be configured

Tested-by: Set a fan to a different Min and it worked.

Change-Id: Ibeebcaa9672d7a9cd9511c3845f5b317db8962c8
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Break CFM out into its own sensor

Break CFM out into its own sensor to be the System Airflow
sensor. Also change CFM calculation to use rpm instead of pwm
as it is more accurate.

Change-Id: Ic15246

Break CFM out into its own sensor

Break CFM out into its own sensor to be the System Airflow
sensor. Also change CFM calculation to use rpm instead of pwm
as it is more accurate.

Change-Id: Ic152465f8c0cd9256176b6a673f121562cff8580
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add exit air temp sensor

Exit air temperature is calculated based on system
power and CFM. CFM sensor will be broken out into own
sensor in follow on commit.

Change-Id: I01b68c4de9a17e5a8d623bbbd7e

Add exit air temp sensor

Exit air temperature is calculated based on system
power and CFM. CFM sensor will be broken out into own
sensor in follow on commit.

Change-Id: I01b68c4de9a17e5a8d623bbbd7e7089f8f9d15d5
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Remove duplicate functions

There are many duplicate functions in the sensors,
collapse them into base class.

Change-Id: Ic0e4a1c396c221ea637cea5b8f429a751fc31f99
Signed-off-by: James Feist <james.f

Remove duplicate functions

There are many duplicate functions in the sensors,
collapse them into base class.

Change-Id: Ic0e4a1c396c221ea637cea5b8f429a751fc31f99
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Fansensor: Add psu fan support

Also simplify parsing logic by detecting type of tach.

Change-Id: Ib08bd240313c437275ea0b604d193e720c6e9515
Signed-off-by: James Feist <james.feist@linux.intel.com>

Update Variant Visitors

Update to using newer templates that support
vector.

Change-Id: I83ed73b606f33f5bfca304c80990bd92f06abe64
Signed-off-by: James Feist <james.feist@linux.intel.com>

Change external project to YOCTO

Allow out of tree builds so we can get CI running on
this repo.

Change-Id: Ica836320eca879fbc49d494d35a552525b99fab2
Signed-off-by: James Feist <james.feist@linux.i

Change external project to YOCTO

Allow out of tree builds so we can get CI running on
this repo.

Change-Id: Ica836320eca879fbc49d494d35a552525b99fab2
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add support for sensor override value

Write support Value property under xyz.openbmc_project.Sensor.Value
interface is added which will be used to do sensor override.
Sensor can be overridden by set

Add support for sensor override value

Write support Value property under xyz.openbmc_project.Sensor.Value
interface is added which will be used to do sensor override.
Sensor can be overridden by setting a value, which will be preserved,
till the service is restarted or Value is overridden again with NaN.

Change-Id: Ia606031a97e532cd12d768e36f1feaa4c7350620
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...