Turn on a bunch of warnings

Turn on as many warnings as easily possible from:
https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md

Turn on a bunch of warnings

Turn on as many warnings as easily possible from:
https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md#L100

Tested:
ipmitool sensor list still works

Change-Id: Ied8fa66de9fcd25e448f8048c4f8216b426b6f55
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Revert "Fix CPU detection GPIO handling logic"

This reverts commit be73e6a4d11f6c9f6f6887918404901cd87386b8.

The new SGPIO driver has a critical bug so the driver will be replaced
with old version.

Revert "Fix CPU detection GPIO handling logic"

This reverts commit be73e6a4d11f6c9f6f6887918404901cd87386b8.

The new SGPIO driver has a critical bug so the driver will be replaced
with old version. This commit is for following up of the change.

Change-Id: Ia9cc430b6fd519e3565621c31e6905667d048945
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

show more ...

Update Associations For bmcweb changes

Updating according to
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/22976

Tested: Thermal had all fans, and presence worked.

Change-Id: I03e1e13b3a9c2f

Update Associations For bmcweb changes

Updating according to
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/22976

Tested: Thermal had all fans, and presence worked.

Change-Id: I03e1e13b3a9c2f6d2ac4b7afc6e2723c04597931
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Support temp sensor on MCU which is available from I2C

Chassis MCU exposes register to report temperature for the peripheral board.
The MCU access is configurable as below:
{
"Bu

Support temp sensor on MCU which is available from I2C

Chassis MCU exposes register to report temperature for the peripheral board.
The MCU access is configurable as below:
{
"Bus": $bus,
"Address": "0xAA",
"Reg": "0xBB",
"Class": "MCUTemp",
"Name": "MCU Temp",
"Thresholds": [
xxx
]
"Type": "MCUTempSensor"
}

Tested:
The below interface was found under temperature sensor namespace:
└─/xyz/openbmc_project/sensors/temperature/MCU_Temp

Run ipmitool sensor and check below from list:
MCU Temp | 30.175 | degrees C | cr | na | 0.000 | 5.000 | 110.000 | 115.000 | na

Change-Id: I8d54455ccc39ea4f60a5b4aee5c68be092d39a72
Signed-off-by: Yuan Li <yuan.li@linux.intel.com>

show more ...

Fix CPU detection GPIO handling logic

This commit fixes CPU detection GPIO handling logic to support
the latest kernel SGPIO driver which creates a single gpiochip cdev
entry, /dev/gpiochip1.

Chang

Fix CPU detection GPIO handling logic

This commit fixes CPU detection GPIO handling logic to support
the latest kernel SGPIO driver which creates a single gpiochip cdev
entry, /dev/gpiochip1.

Change-Id: I386d3d6831b55d553635e71900299bd840f57906
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

show more ...

Change power control match to use host state

Lower level signals were removed, use host state instead.
Also fix bug that was introduced, std::abs(nan, number)
returns nan, so checkThresholds wasn't

Change power control match to use host state

Lower level signals were removed, use host state instead.
Also fix bug that was introduced, std::abs(nan, number)
returns nan, so checkThresholds wasn't being called.

Tested: Put in prints and saw power/post state change to on

Change-Id: I98df270237900c3a0b01c03ec7905851bc47e3b3
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

cpusensor: Add thresold offset

Added DTS critical offset parameter to change critical thresold
value of DTS sensors.

Tested by setting value in entity manager and seeing output
reflect in dbus inte

cpusensor: Add thresold offset

Added DTS critical offset parameter to change critical thresold
value of DTS sensors.

Tested by setting value in entity manager and seeing output
reflect in dbus interface.

Change-Id: Ib819d20322b7eca5f6e8690827bf97d49695e995
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

show more ...

Add Hysteresis support

This adds a hysteresis to each sensor that is 1% of
the range of the sensor.

Change-Id: I0c8606e61d1aca3582d1f6882be5da1bf2884cd9
Signed-off-by: James Feist <james.feist@linu

Add Hysteresis support

This adds a hysteresis to each sensor that is 1% of
the range of the sensor.

Change-Id: I0c8606e61d1aca3582d1f6882be5da1bf2884cd9
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Follow up on Todo, move path out of base sensor

Not every sensor needs a sysfs path, because of that
move it out of the base class and into the classes that
need it.

Change-Id: I62b7df681e1ee889eb6

Follow up on Todo, move path out of base sensor

Not every sensor needs a sysfs path, because of that
move it out of the base class and into the classes that
need it.

Change-Id: I62b7df681e1ee889eb66e371d1cd6094097e9f21
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

cpusensor: detect if cpu is available

Add CPU inventory item detection via gpio.

Tested: inventory item is exposed

Change-Id: Ia26a4bed5534edec6a7f5c7cf0965f84fa0fc23a
Signed-off-by: James Feist <

cpusensor: detect if cpu is available

Add CPU inventory item detection via gpio.

Tested: inventory item is exposed

Change-Id: Ia26a4bed5534edec6a7f5c7cf0965f84fa0fc23a
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Implement PSU Event

Expose PSU Event AC Lost, Fan Fault, Failure, Predictive D-Bus interface.
Read alarm and max_alarm, min_alarm, crit_alarm, lcrit_alarm and
assert or deassert the related properti

Implement PSU Event

Expose PSU Event AC Lost, Fan Fault, Failure, Predictive D-Bus interface.
Read alarm and max_alarm, min_alarm, crit_alarm, lcrit_alarm and
assert or deassert the related properties on PSU Event.

Tested By:
After run /usr/sbin/psusensor below D-Bus interface are exposed
/xyz/openbmc_project/State/Decorator/PSU1_OperationalStatus
/xyz/openbmc_project/State/Decorator/PSU2_OperationalStatus
After plugging out AC cable from PSU1, the functional property in
PSU1_OperationalStatus changes to "false" from "true".
After plugging in AC cable again, the property changes back to "true".

Change-Id: Ic21513471c4632835c39148ea313808fdcc816fa
Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>

show more ...

Add logging for Fan Presence / Redundancy

Add logging and fix bug with shared_ptr usage. We
now use a std::optional * to the shared redundancy
object, so that it can 1. point to object / null and 2.

Add logging for Fan Presence / Redundancy

Add logging and fix bug with shared_ptr usage. We
now use a std::optional * to the shared redundancy
object, so that it can 1. point to object / null and 2.
exist in config or not.

Tested: cat /var/log/redfish to see logs made by removing
and adding fans, and using sensor override to change
redundancy.

Change-Id: Ic4b319cf7484cbbd7ce7dbdf7556f48bebe11cb0
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add PSU PWM sensor to support FSC

Add PSU PWM sensor to allow FSC control PSU fan pwm.

Tested:
Change property Target to 100 in dbus interface xyz.openbmc_project.Control.FanPwm
path /xyz/openbmc_p

Add PSU PWM sensor to support FSC

Add PSU PWM sensor to allow FSC control PSU fan pwm.

Tested:
Change property Target to 100 in dbus interface xyz.openbmc_project.Control.FanPwm
path /xyz/openbmc_project/control/fanpwm/Pwm_PSU1_Fan_1, the value in
/sys/class/hwmon/hwmonx/fan1_target also become 100, and value property in interface
/xyz/openbmc_project/sensors/fan_pwm/Pwm_PSU1_Fan_1 become 39.2157

Run ipmitool sensor list, bellow sensors will show like:
Pwm PSU1 Fan 1 | 39.200 | unspecified | ok | na | na | na | na | na | na
Pwm PSU2 Fan 1 | 0.000 | unspecified | ok | na | na | na | na | na | na

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: I6a4d50912a190297dbcf4a4e5c511607f71cb0c0

show more ...

Check thresholds for sensor override

Fix bug, which got introduced when moving override logic
to base class. This fixes to check thresholds for external set
(i.e. sensor override).

Tested:
1. Verif

Check thresholds for sensor override

Fix bug, which got introduced when moving override logic
to base class. This fixes to check thresholds for external set
(i.e. sensor override).

Tested:
1. Verified that threshold events are triggered, when updating
Value property more than the threshold value
2. Verified that threshold events are set to low when Value
property is updated to normal level

Change-Id: I6a3cb9c66ebdc38c793b6397eb98f88ad9e1be55
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

ExitAirSensor: Get power readings from PSU

Now that PSU Sensors work, remove todo. Also fix
a bug where a int32 should have been a double as the
value from d-bus is a double.

Tested: Ipmitool senso

ExitAirSensor: Get power readings from PSU

Now that PSU Sensors work, remove todo. Also fix
a bug where a int32 should have been a double as the
value from d-bus is a double.

Tested: Ipmitool sensor list

Change-Id: Ic7b31c1091b8178dc23ca79fdc189b973095a8e3
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Remove references to experimental filesystem

We're at CPP17 everywhere now, no need to keep the
experimental refrerence.

Change-Id: Ifd6af23c9bd8e40061b444436943c5192f9fc3e8
Signed-off-by: James Fe

Remove references to experimental filesystem

We're at CPP17 everywhere now, no need to keep the
experimental refrerence.

Change-Id: Ifd6af23c9bd8e40061b444436943c5192f9fc3e8
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

[ADC-GPIO]Enabling ADC-Gpio Bridge

Commit 2: bridge
In case a channel has a bridge circuit,
we have to turn the bridge on prior to reading a value at least for one scan cycle
to get a valid value.
A

[ADC-GPIO]Enabling ADC-Gpio Bridge

Commit 2: bridge
In case a channel has a bridge circuit,
we have to turn the bridge on prior to reading a value at least for one scan cycle
to get a valid value.
Add support for ADC channel controlled by GPIO.
For example,ADC channel8, connected to CMOS battery, is controlled by a GPIO.
Need set 1 to gpio when Channel8 sampling, and set 0 to gpio when finish sampling.

Another Commit 1:Enable ADC Gpio bridge configuration

Tested:
P3VBAT previous value is 0.4V
P3VBAT sensor reading now:3.0843V

Change-Id: I64325845dfd4a931d0beda28993f6b15fa31ae95
Signed-off-by: Zhu, Yunge <yunge.zhu@linux.intel.com>

show more ...

Support more PSU Sensors

Base on PSU power sensors, support all other PSU sensors.

Tested By:
After run psusensor in BMC console, in xyz.openbmc_project.PSUSensor
PSU power, current, temperature, v

Support more PSU Sensors

Base on PSU power sensors, support all other PSU sensors.

Tested By:
After run psusensor in BMC console, in xyz.openbmc_project.PSUSensor
PSU power, current, temperature, voltage and fan dbus interface has
been created with correct Thresholds and value.
Run ipmitool -I lanplus -H xxx -U root -P xxx sensor list, bellow
sensors can show as:
PSU2 Input Curre | 0.546 | Amps | ok | na | na | na | 8.190 | na | na
PSU2 Output Curr | 9.000 | Amps | ok | na | na | na | 100.000 | 125.000 | na
PSU2 Fan Speed 1 | 3332.000 | RPM | ok | na | na | na | na | na | na
PSU2 Input Power | 117.000 | Watts | ok | na | na | na | 1357.200 | 1509.300 | na
PSU2 Output Powe | 105.300 | Watts | ok | na | na | na | na | na | na
PSU2 Temperature | 26.000 | degrees C | ok | na | na | na | 62.000 | 65.000 | na
PSU2 Input Volta | 235.000 | Volts | ok | na | na | na | na | na | na

Change-Id: I2167594a8f369c8ed95b3dc3948f8f5b0bd8bdbb
Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>

show more ...

Fix: Move overriding logic to base sensor class

Instead of having the overridden value check inside each
sensor type, move the same to sensor base class, so that
any future addition of new sensor mo

Fix: Move overriding logic to base sensor class

Instead of having the overridden value check inside each
sensor type, move the same to sensor base class, so that
any future addition of new sensor model, will be able to
inherit this feature automatically

Tested:
1. Verified the behaviour of overriden value by setting
the Value property.
2. restarting the sensor initializes the value back correctly

Change-Id: Iddf280cafcf6d9299e1edc13b942683bf60ea89b
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

cfm: allow setting of max pwm

When a change from xyz.openbmc_project.Control.CFMLimit
interface is detected set the max pwm in pid control configs
to limit max fan speed.

This also puts the max CFM

cfm: allow setting of max pwm

When a change from xyz.openbmc_project.Control.CFMLimit
interface is detected set the max pwm in pid control configs
to limit max fan speed.

This also puts the max CFM on d-bus for other commands to
use.

Tested-by: Used settingsd to control fan speed

Change-Id: Ic4ca37747690f6476cfa12bf3c19a44d7ee086c8
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add Item Iface to Track Fan Presence

Item iface has a present bit that phosphor-fan-presence
uses to track presence. Algin to this so we can add it
to redfish.

Tested: Pulled fan and correct bit ch

Add Item Iface to Track Fan Presence

Item iface has a present bit that phosphor-fan-presence
uses to track presence. Algin to this so we can add it
to redfish.

Tested: Pulled fan and correct bit changed to false

Change-Id: I5bfb5d97b8ad7a4d582b3e41b0f14007cdd88b51
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Implement PSU Power Sensor

Implement Power Supply Input Power Sensor.

Tested By:
With the related change in entity-manager, after run psusensor in
BMC console, xyz.openbmc_project.PSUSensor has bee

Implement PSU Power Sensor

Implement Power Supply Input Power Sensor.

Tested By:
With the related change in entity-manager, after run psusensor in
BMC console, xyz.openbmc_project.PSUSensor has been created and
PSU pin dbus interface has been created with correct Thresholds
and value. Ipmitool sensor list can show PSU pin sensor.

Change-Id: Ib057a9ecca7bf317eb8d98af1ddb8be39841a54f
Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>

show more ...

Add association to Fan Redundancy

This also needs an association.

Change-Id: I6b0f2f4c5fdc2143ee4e2336d0f9fb9976cec629
Signed-off-by: James Feist <james.feist@linux.intel.com>

Add associations for pwm

Pwm doesn't inheirt from Sensor as it is special, so
it needs it to be added seperate.

Tested: Saw associations on dbus

Change-Id: I2178e9346dcae845b47a013a2cc15f62e9ed9b3

Add associations for pwm

Pwm doesn't inheirt from Sensor as it is special, so
it needs it to be added seperate.

Tested: Saw associations on dbus

Change-Id: I2178e9346dcae845b47a013a2cc15f62e9ed9b31
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add associations to sensors

This adds associations to all the sensors on dbus.

Tested: Mapper has lots of sensor associations now.

Change-Id: I9a1c51d6b139e45a228507d29637c29a84b302d9
Signed-off-b

Add associations to sensors

This adds associations to all the sensors on dbus.

Tested: Mapper has lots of sensor associations now.

Change-Id: I9a1c51d6b139e45a228507d29637c29a84b302d9
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...