Add Group Event Support for PSU

Some group events such as PSU Fan Fault will only have one event but
have more than one target to trigger redfish log. For example, PSU Fan
only has one event PSU Fan

Add Group Event Support for PSU

Some group events such as PSU Fan Fault will only have one event but
have more than one target to trigger redfish log. For example, PSU Fan
only has one event PSU Fan Fault, any Fan failure will trigger PSU Fan
Fault and change the functional property to false. But if another PSU
Fan failure happens, we still need to trigger a redfish log to indicate
the specific fan number. So change the PSU Event logic to support this
feature.

Tested:
Remove one of the PSU, Redfish Log show PSU Fan Fault on Fan1 and Fan2.
Insert the PSU and Redfish Log show PSU Fan1 and Fan2 recovered.

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: I1a21d5a2a8172183b05b37a5ef747bd4f3510368

show more ...

Enabling NVMe sensor support

This commit introduces the support for NVMe drives for sensors.

All the NVMe drives which are detected by the FRU manager and are
present in the inventory are scanned a

Enabling NVMe sensor support

This commit introduces the support for NVMe drives for sensors.

All the NVMe drives which are detected by the FRU manager and are
present in the inventory are scanned at regular interval for reading
the temperature values of the NVMe devices.

Tested:

NAME TYPE SIGNATURE RESULT/VALUE
org.freedesktop.DBus.Introspectable interface - -
.Introspect method - s
org.freedesktop.DBus.Peer interface - -
.GetMachineId method - s
.Ping method - -
org.freedesktop.DBus.Properties interface - -
.Get method ss v
.GetAll method s a{sv}
.Set method ssv -
.PropertiesChanged signal sa{sv}as -
xyz.openbmc_project.Association.Definitions interface - -
.Associations property a(sss) 1 "chassis" "all_sensors" "/xyz/openb...
xyz.openbmc_project.Sensor.Threshold.Critical interface - -
.CriticalAlarmHigh property b false
.CriticalAlarmLow property b false
.CriticalHigh property d 115
.CriticalLow property d 0
xyz.openbmc_project.Sensor.Threshold.Warning interface - -
.WarningAlarmHigh property b false
.WarningAlarmLow property b false
.WarningHigh property d 110
.WarningLow property d 5
xyz.openbmc_project.Sensor.Value interface - -
.MaxValue property d 127
.MinValue property d -60
.Value property d 22

Change-Id: Icb119b424234d548c8ff5cda9c7a9517ec9696bb
Signed-off-by: Nikhil Potade <nikhil.potade@linux.intel.com>
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

HwmonTemp: Support more than 2 temperature readings; add support for MAX31730.

Tested:
All 4 temperature readings of MAX31730 are available in IPMI sensors:
~ # ipmitool sensor list | grep xxx
xxx_1

HwmonTemp: Support more than 2 temperature readings; add support for MAX31730.

Tested:
All 4 temperature readings of MAX31730 are available in IPMI sensors:
~ # ipmitool sensor list | grep xxx
xxx_1 | 28.000 | degrees C | ok | na...
xxx_2 | 27.000 | degrees C | ok | na...
xxx_3 | 29.000 | degrees C | ok | na...
xxx_4 | 42.000 | degrees C | ok | na...

Signed-off-by: Alex Qiu <xqiu@google.com>
Change-Id: I5325dfcc2c7ee8c2737c05e46560153301b206a5

show more ...

convert sysfs gpio usage to libgpiod

Updated Fan presence sensor monitoring call back
to use pin name and gpiod APIs. Number based sysfs
framework is deprecated and replaced by descriptor
based gpio

convert sysfs gpio usage to libgpiod

Updated Fan presence sensor monitoring call back
to use pin name and gpiod APIs. Number based sysfs
framework is deprecated and replaced by descriptor
based gpiod framework. With named gpio pin,
code is more portable provided the device tree
defines GPIO pin name consistently.

This requires device tree change (225598) and
configuration file change (entity-manager/+/28119)

Tested By:
remove and insert fans and observe fan presence
status change on dbus fan sensor objects

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: Ice17a472285373ce866132ccc0da02cd1e70ddbe

show more ...

Update ioctl header

This commit updates local copy of the peci-ioctl.h to sync with
the header file in OpenBMC v5.4 linux tree.

This can be dropped in the future once PECI is upstream and yocto shi

Update ioctl header

This commit updates local copy of the peci-ioctl.h to sync with
the header file in OpenBMC v5.4 linux tree.

This can be dropped in the future once PECI is upstream and yocto ships
a kernel version that includes the header.

Change-Id: I07ce03680aed3a602ffc635888aa827435e54879
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

show more ...

Move ioctl header to common include path

Currently this project places the header under a path that is only added
to the includes list when not building under yocto. The existing yocto
solution is n

Move ioctl header to common include path

Currently this project places the header under a path that is only added
to the includes list when not building under yocto. The existing yocto
solution is not compatible with the upcoming 5.4 kernel, so instead
always include the local copy.

This can be dropped in the future once PECI is upstream and yocto ships
a kernel version that includes the header.

Change-Id: I11347b33c0d23e6b769c81d9c99390e69b1fd6af
Signed-off-by: Joel Stanley <joel@jms.id.au>

show more ...

ipmbsensor fix errors / thresholds

Make the sensor set the lowest possible value when
multiple read errors occur. Also fix the sensor threshold
settings based on the spec:

A high-going threshold ha

ipmbsensor fix errors / thresholds

Make the sensor set the lowest possible value when
multiple read errors occur. Also fix the sensor threshold
settings based on the spec:

A high-going threshold has its assertion events become set when the
reading is >= the threshold, while for a low-going event the assertion
becomes set when the reading is <= the threshold.

Tested: fans boosted after putting me in recovery

Change-Id: I0fc9edafb57afa61cf68124eec5d124cdbb51983
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

fix warnings

Fix a couple warnings so we can use meson warning level 3. Instances of
the following warnings are found and resolved:

Wreorder
Wsign-compare

Change-Id: Ia223b42aa6bf743cfa0e7042

fix warnings

Fix a couple warnings so we can use meson warning level 3. Instances of
the following warnings are found and resolved:

Wreorder
Wsign-compare

Change-Id: Ia223b42aa6bf743cfa0e7042cc3d5a18977459be
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

tachsensor header: whitespace cleanup

Cleanup extra vertical whitespace.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ie2744640b6d72779c4e4ab8241a3c895d012e726

include: add missing headers

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I6b26a1bea2aae173b57dbd8affa0ba4991b1c9bb

use quotes for local headers

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I95f247bd17cffab8b9ef3337f48336f8d7059c2d

psusensors: Cleaning up debug and error wording

Rewords some misleading error messages
Adds additional test for failure to set property
Adds additional line for sensor value update
Sensor label head

psusensors: Cleaning up debug and error wording

Rewords some misleading error messages
Adds additional test for failure to set property
Adds additional line for sensor value update
Sensor label head line now shows pairing

Tested: Output appears as expected on my machine

Change-Id: Ibb2ca0df23124120070ca47d4377942089dbbed7
Signed-off-by: Josh Lehan <krellan@google.com>

show more ...

exitAir: Remove 'this' captures

'this' captures cause race conditions in matches and
async calls. Use shared_from_this() instead. Also move
cfmSensor storage into global space so they work without
a

exitAir: Remove 'this' captures

'this' captures cause race conditions in matches and
async calls. Use shared_from_this() instead. Also move
cfmSensor storage into global space so they work without
an exitAirSensor

Tested: Removed exit air sensor and sensor list worked.
Also tested works on system with exit air sensor.

Change-Id: Iabbf5393fbf07f7d19ef104e87c37bc172c202e4
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Support MAX34451, fix sensor type, enum issues

Add support for MAX34451 power sequencers, as well as fix some issues
with substring matching with regards to hwmon file prefix (sensor type)
and hwmon

Support MAX34451, fix sensor type, enum issues

Add support for MAX34451 power sequencers, as well as fix some issues
with substring matching with regards to hwmon file prefix (sensor type)
and hwmon file suffix (sensor enumeration).
e.g vout11 , vout would be the sensor type and 11 would be the
enumeration.
Test:
Reboot BMC on a system with a MAX34451 present
which published the following sysfs hwmon labels,
e.g grep -H "" /sys/class/hwmon/hwmonXX/*_label
in10_label:vout12
in11_label:vout13
in12_label:vout16
in1_label:vout1
in2_label:vout2
in3_label:vout4
in4_label:vout5
in5_label:vout6
in6_label:vout7
in7_label:vout9
in8_label:vout10
in9_label:vout11
then did dbusctl --no-pager tree xyz.openbmc_project.PSUSensor
and saw the correct corresponding output voltage paths.
Before the patch having an enumeration > 9 would cause issues.

Change-Id: I9a82eea11f54266003c673013d0fed131f2f11fc
Signed-off-by: Jason Ling <jasonling@google.com>

show more ...

Fix Association interface

Mapper changed to only allow the new interface, update
to it.

Tested: Mapper showed all associations

Change-Id: I8b252c70e9f27b083a438393c731fbeb3e2ca0e5
Signed-off-by: J

Fix Association interface

Mapper changed to only allow the new interface, update
to it.

Tested: Mapper showed all associations

Change-Id: I8b252c70e9f27b083a438393c731fbeb3e2ca0e5
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Create Async Get Sensor Configuration

This pattern was good back when entity manager didn't
have so many configurations, now the response is too big
and it should be async to increase performance.

Create Async Get Sensor Configuration

This pattern was good back when entity manager didn't
have so many configurations, now the response is too big
and it should be async to increase performance.

Tested: ipmitool sensor list for adcs still works

Change-Id: Ic808884719d70e82b79b35b04617b55a9028f0cd
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add PSU FRU to Redfish

Add PSU FRU to Redfish chassis or baseboard.

Tested:
Check redfish
https://BMC_IP/redfish/v1/Chassis/WC_Baseboard/Power
Page will show:
"PowerSupplies": [
{
"@oda

Add PSU FRU to Redfish

Add PSU FRU to Redfish chassis or baseboard.

Tested:
Check redfish
https://BMC_IP/redfish/v1/Chassis/WC_Baseboard/Power
Page will show:
"PowerSupplies": [
{
"@odata.id": "/redfish/v1/Chassis/WC_Baseboard/Power#/PowerSupplies/0",
"Manufacturer": "SOLUM CO., LTD. ",
"MemberId": "SOLUM_CO_IS162F22_PSU1",
"Model": "IS162F22",
"Name": "SOLUM CO IS162F22 PSU1",
"PartNumber": "G36234-014",
"PowerInputWatts": 0.0,
"PowerOutputWatts": 0.0,
"SerialNumber": "PSSF162202ACNS1622A4BJCB0259",
"Status": {
"Health": "OK",
"State": "Enabled"
}
},
{
"@odata.id": "/redfish/v1/Chassis/WC_Baseboard/Power#/PowerSupplies/1",
"Manufacturer": "SOLUM CO., LTD. ",
"MemberId": "SOLUM_CO_IS162F22_PSU2",
"Model": "IS162F22",
"Name": "SOLUM CO IS162F22 PSU2",
"PartNumber": "G36234-013",
"PowerInputWatts": 152.75,
"PowerOutputWatts": 135.75,
"SerialNumber": "PSSF162202ACNS1622A4BJ890333",
"Status": {
"Health": "OK",
"State": "Enabled"
}
}
],

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: I1d104b5a3090cdaa9cea22529150569ebfc24730

show more ...

Check thresholds each set

Thresholds can be changed even if the reading isn't,
call check thresholds each time so that if they are
modified that we can set / unset the assert.

Tested: Lowered senso

Check thresholds each set

Thresholds can be changed even if the reading isn't,
call check thresholds each time so that if they are
modified that we can set / unset the assert.

Tested: Lowered sensor threshold, it got asserted

Change-Id: Ibf3b874254e34be079f4e8d559e620e6922c5d3a
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Stop logging bad SEL on power transitions

Improve the power transition handling logic to avoid
extra sel.

Tested: DC cycled multiple times and watched SEL not happen

Change-Id: I173f8179ff983e08a1

Stop logging bad SEL on power transitions

Improve the power transition handling logic to avoid
extra sel.

Tested: DC cycled multiple times and watched SEL not happen

Change-Id: I173f8179ff983e08a12af0c618c03f4145c0ac04
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add Deassert Event to PSU

Tested:
Plug out AC cable and plug in it again, below redfish log is created
{
"@odata.context": "/redfish/v1/$metadata#LogEntry.LogEntry",
"@odata.id": "/redfish/v

Add Deassert Event to PSU

Tested:
Plug out AC cable and plug in it again, below redfish log is created
{
"@odata.context": "/redfish/v1/$metadata#LogEntry.LogEntry",
"@odata.id": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/
1566427243",
"@odata.type": "#LogEntry.v1_4_0.LogEntry",
"Created": "2019-08-21T22:40:43+00:00",
"EntryType": "Event",
"Id": "1566427243",
"Message": "Power supply PSU2 AC power regained.",
"MessageArgs": [
"PSU2"
],
"MessageId": "OpenBMC.0.1.PowerSupplyACInserted",
"Name": "System Event Log Entry",
"Severity": "OK"
},

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: Ic2626c99f06962dafabb580fe498fb558480f61e

show more ...

cpusensor: refine CPU detection logic

This commit refines CPU detection logic using gpio line name based
handling.

Tested: Worked well with new SGPIO kernel driver and updated
platform configuratio

cpusensor: refine CPU detection logic

This commit refines CPU detection logic using gpio line name based
handling.

Tested: Worked well with new SGPIO kernel driver and updated
platform configuration.

Change-Id: I5dae2b7497b6b5291b56e73d2175ca8cbb0580d4
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

show more ...

Refine BridgeGpio object creation logic

This commit refines BridgeGpio object creation logic by using explicit
std::move to prevent object copy. Also, for cases of rescanning of
ADCSensors, it adjus

Refine BridgeGpio object creation logic

This commit refines BridgeGpio object creation logic by using explicit
std::move to prevent object copy. Also, for cases of rescanning of
ADCSensors, it adjusts timing of destroying for the previous ADCSensor
to avoid double request of a gpio line.

Tested: adcsensor service was started without making a below error
even in case of a recreation sensors caused by rescanning:
Error requesting gpio: P3VBAT_BRIDGE_EN
terminate called after throwing an instance of 'std::system_error'
what(): error setting GPIO line values: Operation not permitted

Change-Id: I26ca059f8fe6eea2c60605f19ec49a3e365dc66f
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

show more ...

IpmbSensor: Add support for HSC sensor

1. Added support for HSC ADM1278 type sensors.
2. Added a subType as temp, volt, curr and power with default
subtype as temperature.
3. Added support for Sc

IpmbSensor: Add support for HSC sensor

1. Added support for HSC ADM1278 type sensors.
2. Added a subType as temp, volt, curr and power with default
subtype as temperature.
3. Added support for Scale and offset with default value as
scale = 1 and offset = 0.

Tested sensors with config file update.

Change-Id: If8c6b931bc9a27fabe4991ffce44b1a2545195ea
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>

show more ...

adcsensor: improve bridge gpio handling

This commit improves bridge gpio handling using name based gpio line
access and polarity setting support.

Tested: P3VBAT sensor reading worked correctly.

Ch

adcsensor: improve bridge gpio handling

This commit improves bridge gpio handling using name based gpio line
access and polarity setting support.

Tested: P3VBAT sensor reading worked correctly.

Change-Id: Iff174c52dba90cc068f4b5e527d4ab1c381817d0
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

show more ...

Trigger Redfish Log in PSU Event

When PSU Event is asserted, trigger Redfish Log.

Tested:
Plug out AC cable on PSU2, we can see below in Redfish Log Entries.
{

"@odata.context": "/redfish/v1/$

Trigger Redfish Log in PSU Event

When PSU Event is asserted, trigger Redfish Log.

Tested:
Plug out AC cable on PSU2, we can see below in Redfish Log Entries.
{

"@odata.context": "/redfish/v1/$metadata#LogEntry.LogEntry",
data.context": "/redfish/v1/$metadata#LogEntry.LogEntry",
"@odata.id": "/redfish/v1/Systems/system/LogServices/EventLog/
Entries/#1562158096",
"@odata.type": "#LogEntry.v1_4_0.LogEntry",
"Created": "2019-07-03T12:48:16+00:00",
"EntryType": "Event",
"Id": "1562158096",
"Message": "Power supply PSU2 AC power lost.",
"MessageArgs": [
"PSU2"
],
"MessageId": "OpenBMC.0.1.PowerSupplyACLost",
"Name": "System Event Log Entry",
"Severity": "Critical"
},

Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
Change-Id: I406dbf2047e82ccf523dcea91dce48600341aaee

show more ...