Boost beast

This commit is the beginings of attempting to transition away from
crow, and toward boost::beast. Unit tests are passing, and
implementation appears to be slightly faster than crow.

Ch

Boost beast

This commit is the beginings of attempting to transition away from
crow, and toward boost::beast. Unit tests are passing, and
implementation appears to be slightly faster than crow.

Change-Id: Ic8d946dc7a04f514c67b1098f181eee1ced69171

show more ...

Added JSON utilities to allow easy exception-less usage of nlohmann JSON.

These functions are not yet used, but will be required by at least two upcoming
patchsets. This functionality has been cut o

Added JSON utilities to allow easy exception-less usage of nlohmann JSON.

These functions are not yet used, but will be required by at least two upcoming
patchsets. This functionality has been cut out from Configuration patchset for
easier merge without having to wait for that commit.

Change-Id: Ibe5d5cefd874d4a2d896b42a2b7cfc17480f3c5a
Signed-off-by: Kowalski, Kamil <kamil.kowalski@intel.com>

show more ...

Move thermal interfaces to new schema

With the change to entity manager, move the thermal componets to the
proper inventory manager interfaces

Change-Id: I520e65b1df53ca8d3fbc12253882ae69b708bbbf
S

Move thermal interfaces to new schema

With the change to entity manager, move the thermal componets to the
proper inventory manager interfaces

Change-Id: I520e65b1df53ca8d3fbc12253882ae69b708bbbf
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Move bmcweb over to sdbusplus

This patchset moves bmcweb from using boost-dbus over entirely to
sdbusplus. This has some nice improvements in performance (about 30%
of CPU cycles saved in dbus tran

Move bmcweb over to sdbusplus

This patchset moves bmcweb from using boost-dbus over entirely to
sdbusplus. This has some nice improvements in performance (about 30%
of CPU cycles saved in dbus transactions), as well as makes this
project manuver closer to the upstream way of thinking.

Changes to bmcweb are largely ceremonial, and fall into a few
categories:
1. Moves async_method_call instances to the new format, and deletes any
use of the "endpoint" object in leiu of the sdbusplus style interface
2. sdbus object_path object doesn't allow access to the string
directly, so code that uses it moves to explicit casts.
3. The mapbox variant, while attempting to recreate boost::variant,
misses a T* get<T*>() method implementation, which allows using variant
without exceptions. Currently, there is an overload for
mapbox::get_ptr implementation which replecates the functionality.

Tested by: Booting the bmcweb on a target, iterating through redfish
basic phosphor-webui usage, and websockets usage

Change-Id: I2d95882908d6eb6dba00b9219a221dd96449ca7b
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Spelling fixes in redfish-core

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

C

Spelling fixes in redfish-core

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Iaac459596247a9063350a129d0458ebe0c0e39ce
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fix header

Needed a space.

Change-Id: Ie44a1feae140b1e6fd278afa0d07295d89f7ace2
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Id065d

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: Id065de1812c3eb383992533efd99b5079b74729d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add MAINTAINERS file

Change-Id: I9dc3173ecc4f661e526426e8044ccacfac5a263e
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

Introduce Thermal schema

Changes:
-redfish.hpp add thermal node installation
-thermal.hpp add thermal schema for chassis
-sensor.hpp add support for retrieving:
temperature, and fan

Verification:

Introduce Thermal schema

Changes:
-redfish.hpp add thermal node installation
-thermal.hpp add thermal schema for chassis
-sensor.hpp add support for retrieving:
temperature, and fan

Verification:
-web server: no regression
-RSV: pass
-build on x86 and ASPEED

This patchset builds on Dawids original.

Change-Id: Ia8e40edff3c722fa02a161248bcdf602e36e3e62
Signed-off-by: Lewanczyk, Dawid <dawid.lewanczyk@intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Remove hunter and submodules

And use external project instead. This should make it easier to keep
our systems up to date with yocto.

Change-Id: Id2c9f3e474eebf2194eaf58b0c572f7a1421def6

Introduce Redfish Error messages definitions

Added a python script that should be use to generate error_messages.cpp na .hpp
files. These files as are not subject to change in a dynamic manner, shou

Introduce Redfish Error messages definitions

Added a python script that should be use to generate error_messages.cpp na .hpp
files. These files as are not subject to change in a dynamic manner, should be
regenerated only when MessageRegistry changes.

Tested on x86 Ubuntu VM and Wolfpass platform:
a) No regression in BMCWeb interface
- Went through WebUI observed no changes in functionality
b) No regression in Redfish functionality
- Went through nodes and observed no changes in functionality
- Sessions now return error messages in addition to HTTP codes

Change-Id: I4aba9ee247b6cd2c46a9c158d14bdc7546e9b11b
Signed-off-by: Kowalski, Kamil <kamil.kowalski@intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Added VLAN Object to EthernetInterface schema

VLAN object added to EthernetInterface schema which is visible when Ethernet Interface is a VLAN interface.

Does not break anything on Wolfpass or x86.

Added VLAN Object to EthernetInterface schema

VLAN object added to EthernetInterface schema which is visible when Ethernet Interface is a VLAN interface.

Does not break anything on Wolfpass or x86. BMCWeb working

Change-Id: I965c484e6e120568db4e6542d2b48f8a7fb54fd0
Signed-off-by: Kowalski, Kamil <kamil.kowalski@intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Enabling Ethernet Interfaces, and Ethernet Interfaces Collection Schemas

Commit provides Schemas for:
* Single Eth Interface (GET)
* Eth Interface Collection (GET)

Both are using EthernetProvider,

Enabling Ethernet Interfaces, and Ethernet Interfaces Collection Schemas

Commit provides Schemas for:
* Single Eth Interface (GET)
* Eth Interface Collection (GET)

Both are using EthernetProvider, which delivers data
available from xyz.openbmc_project.Network

It was tested:
* Regression (no regression in web server behaviour)
* Memory Leaks (no leaks detected via valgrind)
* Compiling multiple arch (x86, ASPEED)
* Service Validator pass all available schemas

Change-Id: Idee321cb294f48b59f7740512bbe416cf10236c0
Signed-off-by: Rapkiewicz, Pawel <pawel.rapkiewicz@intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Fix an issue with directory permissions

directory includes need to manage both the routes, just just the one
ending in slash

Change-Id: I1ba0e9021b212e88861aa720bb5a9d7610b72a9c
Signed-off-by: Ed T

Fix an issue with directory permissions

directory includes need to manage both the routes, just just the one
ending in slash

Change-Id: I1ba0e9021b212e88861aa720bb5a9d7610b72a9c
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Make middleware try other auth types on auth failure

This commit makes the authentication middleware attempt other auth
mechanisms if available from the user.

Signed-off-by: Ed Tanous <ed.tanous@in

Make middleware try other auth types on auth failure

This commit makes the authentication middleware attempt other auth
mechanisms if available from the user.

Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Tested By: Phosphor webui launches and logs in. Redfish endpoints now
work with a cookie present.

Change-Id: I7c11d4b5eb3c32c8e2b9ba348b70a55bfb72bd4e

show more ...

Change order of authorization types

Basic authentication is very slow by virtue of the fact that it has to
call into pam. THis commit rearranges the flow to accomplish 2 things.
1. If a non-basic a

Change order of authorization types

Basic authentication is very slow by virtue of the fact that it has to
call into pam. THis commit rearranges the flow to accomplish 2 things.
1. If a non-basic auth mechanism is provided, prefer that.
2. Check the whitelist first, before attempting to authenticate the
user.

Change-Id: Icfe5a218c00a2aeb53acd1ab00bb8cc568424d1d
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Fix seg fault on shutdown

Use unique_ptr correctly to avoid seg faults from double freed objects.

Fixes the seg fault on shutdown that we've been seeing for a while.

Change-Id: I4372c3bf727d5cdd87

Fix seg fault on shutdown

Use unique_ptr correctly to avoid seg faults from double freed objects.

Fixes the seg fault on shutdown that we've been seeing for a while.

Change-Id: I4372c3bf727d5cdd870805b3ecba7f446c9a1985

show more ...

Implement pretty printing json to HTML

Change-Id: Ibe3cdc2cd53470ccd437b1b6e21bc7dd29c4b85e
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

Clean up async dbus endpoint

This commit makes the webui more compatible with the dbus backend, and
cleans up the backend to support multiple concurrent transactions, as
well as support for the "enu

Clean up async dbus endpoint

This commit makes the webui more compatible with the dbus backend, and
cleans up the backend to support multiple concurrent transactions, as
well as support for the "enumerate" keyword.

Change-Id: I66144904b5c9b2ce7d1b1147cc80dfd356beb0bc
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Remove multithreaded code, and make crow use a single thread

Change-Id: I39e9ba84ab3464cf75b5bba82badb729525bf3b9
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

Disable logging when in release mode

This increases the performance of the webserver quite a bit.

Change-Id: I20714d89163cf30c65afd18d16f4fd16c06824d5
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

Minor fixes to make redfish pass compliance tests

1. Role members needs to be an array, not an object
2. Fix accounts schema to use the new user manager
3. Remove "status" field hardcodes
4. Hardcod

Minor fixes to make redfish pass compliance tests

1. Role members needs to be an array, not an object
2. Fix accounts schema to use the new user manager
3. Remove "status" field hardcodes
4. Hardcode chassisType to rackmount for now
5. Work around bug in get sub routes
6. Add ID to SessionService Schema

Change-Id: Ibb13d6ace747ac028e840638868c3a01d65dedfa
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Adding Chassis and ChassisCollection Schemas to Redfish

This commit:
* removes previous redfish_v1 Chassis implementation
* Adds Chassis and ChassisCollection implementation as Node way
* Adds Chass

Adding Chassis and ChassisCollection Schemas to Redfish

This commit:
* removes previous redfish_v1 Chassis implementation
* Adds Chassis and ChassisCollection implementation as Node way
* Adds Chassis Provider class for retrieving data from EntityManager

It was tested:
* Wolfpass run, to see if previous functionality was not broken
* Service Validator, which did not unveil any regression, and did
verified that implemented schemas are complient.

Change-Id: I75a9545a0abd8b85d6ce72329c523fc076affc28
Signed-off-by: Rapkiewicz, Pawel <pawel.rapkiewicz@intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Signed-off-by: Rapkiewicz, Pawel <pawel.rapkiewicz@intel.com>

show more ...

Wrap Cmake file on 80 characters

And enable LTO only for non debug builds

Change-Id: I3e5ea6fa88e5da3e9f8ab33a3e56355258025b9d
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

Make getUrl not copy

Make get url return a const std::string* instead of a copy. Also, make
the getSubroutes function modify strings in place rather than
construct new strings where possible

Chang

Make getUrl not copy

Make get url return a const std::string* instead of a copy. Also, make
the getSubroutes function modify strings in place rather than
construct new strings where possible

Change-Id: I68d8053a62abd8d907ecb6717e0f266eee4d09a8
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...