Move to 2021.1

Update the script to point at 2021.1 and run it.

Since we have an exclude list, this only brings in new versions of
schemas bmcweb already uses.

Overview of 2021.1:
https://www.dmtf

Move to 2021.1

Update the script to point at 2021.1 and run it.

Since we have an exclude list, this only brings in new versions of
schemas bmcweb already uses.

Overview of 2021.1:
https://www.dmtf.org/sites/default/files/Redfish_Release_2021.1_Overview.pdf

Features IBM plans to use:
Resource, Action, Enum, and Property Deprecated Messages
Boot Progress: Setup Entered
System: Stop Boot On Fault
Chassis: Spare Part Number
Enabled for Memory, Processor
Log Entry: AutomatedServiceNotify, Resolution
Power Modes
Enable/Disable USB

Tested: Clean run of the validator passes.
Change-Id: Ib22e5ea314c41ae354930b2c5857fe9512859507
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove OemCrashdump_v1 from index.xml

8401529 removed OemCrashdump.json but didn't from $metadata/index.xml
and the update_schemas.py.

This is causing the following validator fail and holding up th

Remove OemCrashdump_v1 from index.xml

8401529 removed OemCrashdump.json but didn't from $metadata/index.xml
and the update_schemas.py.

This is causing the following validator fail and holding up the bump:

ERROR - The following schema URIs referenced from $metadata could not
be retrieved:
/redfish/v1/schema/OemCrashdump_v1.xml

See https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/42245

Tested: None.
Change-Id: I6106bb19c725c088b7343722c1001f4e188e216d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

log_services: Remove raw PECI command

The raw PECI command is recommended not to include in a standard
build, so removing it from the bmcweb to avoid accidental
inclusion.

Tested:
Confirmed that th

log_services: Remove raw PECI command

The raw PECI command is recommended not to include in a standard
build, so removing it from the bmcweb to avoid accidental
inclusion.

Tested:
Confirmed that the raw PECI command is gone.

Change-Id: I2b52e0ede089da6df6ca3ad304194de8af27b709
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Remove default.css from the image

This is primarily to save space, and remove cruft. As part of the "old"
json->html parser, this file was used to do the syntax highlighting for
the hilight-js clas

Remove default.css from the image

This is primarily to save space, and remove cruft. As part of the "old"
json->html parser, this file was used to do the syntax highlighting for
the hilight-js class we used. That parser has been removed, so this
code is now dead.

Tested:
Has no external impact to test. Code builds.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Iebbf97003d41818abc2a9eae68c23c636f13d2e6

show more ...

Exclude not used schemas

Created a list of all used schemas, and a few being added for use in reviews
now. Exclude all other schemas.

Developers if they wish to use a new schema will have to add it

Exclude not used schemas

Created a list of all used schemas, and a few being added for use in reviews
now. Exclude all other schemas.

Developers if they wish to use a new schema will have to add it to this
list and rerun update_schemas.py.

Size of obmc-phosphor-image-witherspoon-<date>.rootfs.squashfs-xz:
Before 2020.4: 19451904
With 2020.4, before this commit: 19492864
With this commit: 19275776

Tested: Validator passes.
Change-Id: I23272049aa38c51ac7af0d3b0f5b4641a349a487
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move to 2020.4

2020.4 contains a lot of new schemas.
New feature include: new power and thermal schemas, conditions,
and new account types.

For more information, see:
https://www.dmtf.org/sites/def

Move to 2020.4

2020.4 contains a lot of new schemas.
New feature include: new power and thermal schemas, conditions,
and new account types.

For more information, see:
https://www.dmtf.org/sites/default/files/Redfish_Release_2020.4_Overview.pdf

Tested: Validator passes. Able to see new schemas.
Change-Id: I7fb860c84fa4cff80698dcb26a463b155e6faba7
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove unused files

Remove some ancient files that are no longer used or required.

1. JenkinsFile: Was used when this was a project that only existed on my
desktop, and I used a private Jenkins ins

Remove unused files

Remove some ancient files that are no longer used or required.

1. JenkinsFile: Was used when this was a project that only existed on my
desktop, and I used a private Jenkins instance to test it. Today,
bmcweb uses the openbmc CI, which doesn't require this file.
2. scripts/run_clang_tiidy.py. This script is now part of the clang
builds themselves, so it should be used from there.
3. src/ast*.cpp and src/test_resources. These were left from when
bmcweb handled the ast video driver itself, and had unit tests to prove
it worked. The code to run the unit tests has been long removed, we
just forgot to remove the tests.
4. static/highlight.pack.js. This was previously used for json parsing
in the HTML UI. It is no longer used as of commit
57fce80e24cfe08e530e0697d6c70bba14076d1c and should've been removed as
part of it, but unfortunately was not.

Tested:
None of the above were used previously, so should have no measurable
impact to the build.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I757b0dc8e4dc6cc93ba60d39218016e2f4d47ed0

show more ...

Redfish Session : Support ClientOriginIPAddress

This commit implements the ClientOriginIPAddress property on
the session resource. The IP address is persisted across the reboot

Tested by:
1. Crea

Redfish Session : Support ClientOriginIPAddress

This commit implements the ClientOriginIPAddress property on
the session resource. The IP address is persisted across the reboot

Tested by:
1. Create session
POST https://${bmc}/redfish/v1/SessionService/Sessions -d '{"UserName":<>, "Password":<>}'
2. Check the session gets updated with the ClientOriginIPAddress
GET https://${bmc}/redfish/v1/SessionService/Sessions/<id>
3. Redfish validator passed
4. Create session and reboot the BMC to ensure the IP address is persisted
5. Tested the basic auth populates the clientIp at req

Signed-off-by: Sunitha Harish <sunharis@in.ibm.com>
Change-Id: Iaa60d0657c991bde4bcf6c86819055c71c92e421

show more ...

Revert "Redfish Session : Support ClientOriginIPAddress"

This reverts commit e436008377fbcf287be02c9e9e1b59c6627d7673.

Reason for revert:

This breaks several things.
1. Not all login endpoints are

Revert "Redfish Session : Support ClientOriginIPAddress"

This reverts commit e436008377fbcf287be02c9e9e1b59c6627d7673.

Reason for revert:

This breaks several things.
1. Not all login endpoints are handled, which lead to returning blank ip addresses
2. IP addresses are not persisted.
3. This crashes occasionally on remote_endpoint, and ignores ec.

Change-Id: I58c875721cf48bf02db833c9c57a9eead5e249d5

show more ...

Redfish Session : Support ClientOriginIPAddress

This commit implements the ClientOriginIPAddress property on
the session resource

Tested by:
1. Create session
POST https://${bmc}/redfish/v1/

Redfish Session : Support ClientOriginIPAddress

This commit implements the ClientOriginIPAddress property on
the session resource

Tested by:
1. Create session
POST https://${bmc}/redfish/v1/SessionService/Sessions -d '{"UserName":<>, "Password":<>}'
2. Check the session gets updated with the ClientOriginIPAddress
GET https://${bmc}/redfish/v1/SessionService/Sessions/<id>
3. Redfish validator passed

Signed-off-by: Sunitha Harish <sunharis@in.ibm.com>
Change-Id: I4c5c6f651bb6faec0cb1b1b78d9da593ecb85ff0

show more ...

Remove OEM schemas and related code for Dump LogServices

In this commit, Oem schemas for Dump LogServices are removed
as per the latest Redfish schemas. Also, the code is changed
w.r.t the latest sc

Remove OEM schemas and related code for Dump LogServices

In this commit, Oem schemas for Dump LogServices are removed
as per the latest Redfish schemas. Also, the code is changed
w.r.t the latest schema changes.

Redfish Validator Passed.

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I12c8d283cd54c32e71a2b11857e7c4cce89b9f0a

show more ...

Move to 2020.3

Run the script update_schemas.py by pointing it to 2020.3

An overview of 2020.3 release can be found at:
https://www.dmtf.org/sites/default/files/Redfish_Release_2020.3_Overview.pdf

Move to 2020.3

Run the script update_schemas.py by pointing it to 2020.3

An overview of 2020.3 release can be found at:
https://www.dmtf.org/sites/default/files/Redfish_Release_2020.3_Overview.pdf

Tested: Loaded on a Witherspoon and Validator passed with the latest schemas

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I6c7a2e0cbdbe599930ba453a1d8c134c22136306

show more ...

Improve JSON->HTML conversion

The existing JSON to html conversion is quite unfortunate, as it runs
several very expensive regular expressions on an output to properly
invoke the correct behavior, a

Improve JSON->HTML conversion

The existing JSON to html conversion is quite unfortunate, as it runs
several very expensive regular expressions on an output to properly
invoke the correct behavior, and to escape things like links. This
patchset adjusts the behavior to directly dump the tree to HTML,
skipping the json step entirely.

Most of the code was pulled from the nlohmann::serializer class.

Small side node:
This also resolves the CSP issue with the inline CSS classes that are
currently embedded in the json UI.

Note, in terms of user facing behavior, this finally fixes the CSS
issue, so the div is now centered as designed. Previously it was left
justified.

Tested:
Ran several redfish schemas and compared to old ones. Output appears
the same in the window, and content security policy warnings are gone.
Verified several links works as expected, and verified the behavior of
all base types, as well as empty arrays and empty objects. All appear
to work correctly.

Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: Id9bf6dc33acb1603f009de4cd322e81d83f334be

show more ...

schema: add missing tags

Tested: Made validator pass for OemManager

Change-Id: I2acef893bb5ead465ebdfb631259f34f8e93031d
Signed-off-by: James Feist <james.feist@linux.intel.com>

VirtualMedia fixes for Redfish Service Validator

Removes all warnings and errors for VirtualMedia
- rework for OemVirtualMedia
- minor adjustments for jsons

Tested:
Redfish Service Validator ran wi

VirtualMedia fixes for Redfish Service Validator

Removes all warnings and errors for VirtualMedia
- rework for OemVirtualMedia
- minor adjustments for jsons

Tested:
Redfish Service Validator ran with no errors and/or warnings

Change-Id: Ic027166153a807a8bd3a6c04f042969f16e0dc6a
Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com>

show more ...

Redfish: Minor changes in the Oem schemas for dump

In this commit, CollectDiagnisticData action in
OemLogService schema is updated with two parameters.

It also includes dereferencing the unused nam

Redfish: Minor changes in the Oem schemas for dump

In this commit, CollectDiagnisticData action in
OemLogService schema is updated with two parameters.

It also includes dereferencing the unused namespace
in metadata xml file.

Tested-By:
Redfish Validator - Passed

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I093ddaef9fa786767b2853e235571a4664ee759c

show more ...

Codespell spelling fixes

These spelling errors were found using
https://github.com/codespell-project/codespell

Tested: Built and ran against validator.
Signed-off-by: Gunnar Mills <gmills@us.ibm.co

Codespell spelling fixes

These spelling errors were found using
https://github.com/codespell-project/codespell

Tested: Built and ran against validator.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Change-Id: I214fe102550295578cfdf0fc58305897d261ce55

show more ...

Spelling: 's/Coefficent/Coefficient/g

Tested: Top commit (along with this) was built and ran against
validator.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Change-Id: Ie5af15941250b7952

Spelling: 's/Coefficent/Coefficient/g

Tested: Top commit (along with this) was built and ran against
validator.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Change-Id: Ie5af15941250b795215cee87e757e56cce26c46e

show more ...

Add non-versioned Namespace

Redfish schemas have a non-versioned Namespace of the schema:
https://github.com/openbmc/bmcweb/blob/master/static/redfish/v1/schema/OemSession_v1.xml#L19
https://github.

Add non-versioned Namespace

Redfish schemas have a non-versioned Namespace of the schema:
https://github.com/openbmc/bmcweb/blob/master/static/redfish/v1/schema/OemSession_v1.xml#L19
https://github.com/openbmc/bmcweb/blob/master/static/redfish/v1/schema/Zone_v1.xml#L42

Add that to OemLogEntry and OemLogService.

This fixes the "badNamespaceInclude" Redfish validator errors.

These schemas used to have this but was removed in
https://github.com/openbmc/bmcweb/commit/239c4b88e53fc39f1e3ac9597acfcd8378bdfc4e#

Alternative to
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/33918/4/static/redfish/v1/%2524metadata/index.xml

Tested: Validator passes.
Change-Id: Ibcc831db3d5c243bd0fff2e527e04392aebeda5f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move to 2020.2

Point update_schemas.py at 2020.2 and run the script.

An overview of 2020.2 can be found at:
https://www.dmtf.org/sites/default/files/Redfish_Release_2020.2_Overview.pdf

Tested: Loa

Move to 2020.2

Point update_schemas.py at 2020.2 and run the script.

An overview of 2020.2 can be found at:
https://www.dmtf.org/sites/default/files/Redfish_Release_2020.2_Overview.pdf

Tested: Loaded on a Witherspoon and ran the validator.
See the new schemas.
Change-Id: Idb6cbc58efe484dcffa0cc22deff3a4746af67ed
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Redfish: Changes in Oem schemas for dump

Implemented Oem schemas for extending LogService and
LogEntry

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I37d56b33403700ee65cd6ec7d

Redfish: Changes in Oem schemas for dump

Implemented Oem schemas for extending LogService and
LogEntry

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I37d56b33403700ee65cd6ec7dee06395525d335c

show more ...

New OpenBMC OEM schema for Session

This commit defines the OemSession schema for storing
- the clients unique identifier
- the IP Address from where the session is created.

Signed-off-by: Sunitha

New OpenBMC OEM schema for Session

This commit defines the OemSession schema for storing
- the clients unique identifier
- the IP Address from where the session is created.

Signed-off-by: Sunitha Harish <sunithaharish04@gmail.com>
Change-Id: I759cda25dbb2dadd9b3d14cca9076e6412b41287

show more ...

Redfish:Define new Oem schemas for dump

Implemented Oem schemas for extending LogService and
LogEntry

Testing:
redfish validator passed.

Change-Id: I89a76cf3bd991b36a6aa48871f25d03fbbe30f66
Signed

Redfish:Define new Oem schemas for dump

Implemented Oem schemas for extending LogService and
LogEntry

Testing:
redfish validator passed.

Change-Id: I89a76cf3bd991b36a6aa48871f25d03fbbe30f66
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

show more ...

Move to 2020.1

Make changes to update_schemas.py needed for the move and run
update_schemas.py.

Need 1.3.6 or later version of Redfish-Service-Validator.
CI uses the master branch of Redfish-Servic

Move to 2020.1

Make changes to update_schemas.py needed for the move and run
update_schemas.py.

Need 1.3.6 or later version of Redfish-Service-Validator.
CI uses the master branch of Redfish-Service-Validator, which has
this fix.

Redfish-Service-Validators before 1.3.6 will incorrectly throw errors in
message registries like (Task Event Message Registry)
/redfish/v1/Registries/TaskEvent/TaskEvent and (Base Message Registry)
/redfish/v1/Registries/Base/Base.

For more information:
https://redfishforum.com/thread/323/validator-errors-when-moving-release

This does introduce some "warnDeprecated" due to "Severity" becoming
Deprecated in MessageRegistry v1_4_0. Since all bmcweb Registries are
<v1_4_0, not a real problem. Redfish has no Base Message Registry and
Task Event Message Registry available to move to something that
uses MessageRegistry v1_4_0. Will take up with Redfish.

2020.1 includes new features like AutoRebot (Boot -> AutomaticRetry),
factory reset (ResetToDefaults action), and Modified Event Log property
which are in OpenBMC's D-Bus interfaces today.

Tested: Built bmcweb, loaded on a Witherspoon, and ran
the validator. Validator passed.

See new schemas:
curl -k https://${bmc}/redfish/v1/JsonSchemas/SecureBootDatabase
{
"@odata.context": "/redfish/v1/$metadata#JsonSchemaFile.JsonSchemaFile",
"@odata.id": "/redfish/v1/JsonSchemas/SecureBootDatabase",
"@odata.type": "#JsonSchemaFile.v1_0_2.JsonSchemaFile",
"Name": "SecureBootDatabase Schema File",

Change-Id: If30fcc50276aea44d8a77ed547ee0cbd72e4cf1a
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move to 2019.4

Make changes to update_schemas.py needed for the move and run
update_schemas.py.

To see an overview of 2019.4 see
https://www.dmtf.org/sites/default/files/Redfish_Release_2019.4_Over

Move to 2019.4

Make changes to update_schemas.py needed for the move and run
update_schemas.py.

To see an overview of 2019.4 see
https://www.dmtf.org/sites/default/files/Redfish_Release_2019.4_Overview.pdf

Tested: Built bmcweb, loaded on a Witherspoon, and ran
the validator. No errors.

See new schemas:
curl -k https://${bmc}/redfish/v1/JsonSchemas/VCATEntry
{
"@odata.context": "/redfish/v1/$metadata#JsonSchemaFile.JsonSchemaFile",
"@odata.id": "/redfish/v1/JsonSchemas/VCATEntry",
"@odata.type": "#JsonSchemaFile.v1_0_2.JsonSchemaFile",
"Name": "VCATEntry Schema File",
"Schema": "#VCATEntry.VCATEntry",

Change-Id: I5ae6e3c655e44c82c4457515555bdb934dfb7763
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...