4aad6ed2 | 30-Jan-2025 |
Ed Tanous <etanous@nvidia.com> |
Ignore header failures on registries
The generated registries have an imperfect handling of #include dependencies. Update the script to ignore the misc-include-cleaner recommendations for now. Fut
Ignore header failures on registries
The generated registries have an imperfect handling of #include dependencies. Update the script to ignore the misc-include-cleaner recommendations for now. Future fixes could be done to make these generated headers actually correctly include their dependencies, but that is non trivial to do, and the build is broken.
Change-Id: I32c70e9f865ca7ef693c736a45b3ea59513a751d Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
9b46bc0b | 21-Jan-2025 |
Myung Bae <myungbae@us.ibm.com> |
Update to 2024.4
Update schema to the latest release 2024.4.
See below for more info on this release: https://www.dmtf.org/standards/redfish
Tested: - Redfish Service Validator passes
Change-Id:
Update to 2024.4
Update schema to the latest release 2024.4.
See below for more info on this release: https://www.dmtf.org/standards/redfish
Tested: - Redfish Service Validator passes
Change-Id: I1845d6afa04ee418ba3ab0bd0bc8ce59886e4376 Signed-off-by: Myung Bae <myungbae@us.ibm.com>
show more ...
|
6c038f26 | 14-Jan-2025 |
Ed Tanous <etanous@nvidia.com> |
Roll out error message utils
This code should really be in a cpp/hpp file, not in a generated python script. The python script housed this temporarily to allow us to generate the registries. It's
Roll out error message utils
This code should really be in a cpp/hpp file, not in a generated python script. The python script housed this temporarily to allow us to generate the registries. It's time to roll it out.
Tested: Message registries generate successfully on GET. Redfish service validator passes.
Change-Id: I7aca2d0a7fac6d530511421b667ff732617df61e Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
40e9b92e | 10-Sep-2024 |
Ed Tanous <etanous@nvidia.com> |
Use SPDX identifiers
SPDX identifiers are simpler, and reduce the amount of cruft we have in code files. They are recommended by linux foundation, and therefore we should do as they allow.
This pa
Use SPDX identifiers
SPDX identifiers are simpler, and reduce the amount of cruft we have in code files. They are recommended by linux foundation, and therefore we should do as they allow.
This patchset does not intend to modify any intent on any existing copyrights or licenses, only to standardize their inclusion.
[1] https://www.linuxfoundation.org/blog/blog/copyright-notices-in-open-source-software-projects
Change-Id: I935c7c0156caa78fc368c929cebd0f068031e830 Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
c8895b05 | 03-Jan-2025 |
Ed Tanous <etanous@nvidia.com> |
Reformat python
Apply black formatter to code.
Change-Id: I4a3d8426b03eeb8d71230f24788ac8caeb3618c3 Signed-off-by: Ed Tanous <etanous@nvidia.com> |
7e6d0323 | 26-Dec-2024 |
Tam Nguyen <tamnguyenchi@os.amperecomputing.com> |
Fix out of range error when input non default registries
The parse_registries.py generates base, heartbeat, resource and taskevent registries without checking input registries list. Which causes out
Fix out of range error when input non default registries
The parse_registries.py generates base, heartbeat, resource and taskevent registries without checking input registries list. Which causes out of range error when input non default value. This commit only generates above registries if they are input.
Tested: Input only openbmc registry passes. Input only heartbeat registry passes. Run with default registries passes.
Change-Id: Ibb6e6ee9f241c424bb78782466eb3199b11332c3 Signed-off-by: Tam Nguyen <tamnguyenchi@os.amperecomputing.com>
show more ...
|
770362fe | 16-Dec-2024 |
Milton D. Miller II <mdmii@outlook.com> |
Use raw content URL
Replace the message registry URL with the official GitHub raw download URL to give the json content not a web SCM GUI.
Change-Id: I0ac800ee3803c9bef3a6a799b20887df84c3c173 Signe
Use raw content URL
Replace the message registry URL with the official GitHub raw download URL to give the json content not a web SCM GUI.
Change-Id: I0ac800ee3803c9bef3a6a799b20887df84c3c173 Signed-off-by: Milton Miller <mdmii@outlook.com>
show more ...
|
a8a5bc1b | 02-Dec-2024 |
Ed Tanous <etanous@nvidia.com> |
Generate heartbeat registry
Generate the heartbeat registry, and adjust the #includes of the other generated registries.
Tested: Redfish service validator succeeds.
Change-Id: Iedbf1ae8dc655966669
Generate heartbeat registry
Generate the heartbeat registry, and adjust the #includes of the other generated registries.
Tested: Redfish service validator succeeds.
Change-Id: Iedbf1ae8dc6559666691f1feb71af08e856d5c80 Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
847deee3 | 02-Dec-2024 |
Ed Tanous <etanous@nvidia.com> |
Generate resource event
Generate Resource event registry
Tested: On last patch of series. No behavior changes.
Change-Id: I924919db0e7fbde8ed698de6b59b86f788de9708 Signed-off-by: Ed Tanous <etano
Generate resource event
Generate Resource event registry
Tested: On last patch of series. No behavior changes.
Change-Id: I924919db0e7fbde8ed698de6b59b86f788de9708 Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
f175c280 | 02-Dec-2024 |
Ed Tanous <etanous@nvidia.com> |
Generate task event
Generate the task event registry.
Tested: on last patch of series
Change-Id: I55b7914978f7a1d637cad6dfae398949af0a7107 Signed-off-by: Ed Tanous <etanous@nvidia.com> |
66aabb70 | 10-Dec-2024 |
Ed Tanous <etanous@nvidia.com> |
Fix URI warning in RSV
Redfish service valitator warns:
WARNING - PublicationUri: Empty string found - Services should omit properties if not supported
This commit adds to our registry the url to
Fix URI warning in RSV
Redfish service valitator warns:
WARNING - PublicationUri: Empty string found - Services should omit properties if not supported
This commit adds to our registry the url to the openbmc registry file.
Tested: Redfish Service validator no longer returns a warning.
Change-Id: Ia54be175490b4e7e00e3c0c4ab8c60dce1b96863 Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
56b81992 | 02-Dec-2024 |
Ed Tanous <etanous@nvidia.com> |
Make message registries use 2 digit versions
Redfish specification, section 9.5.11.2 says:
The MessageId property value shall be in the format: <MessageRegistryPrefix>.<MajorVersion>.<MinorVersion>
Make message registries use 2 digit versions
Redfish specification, section 9.5.11.2 says:
The MessageId property value shall be in the format: <MessageRegistryPrefix>.<MajorVersion>.<MinorVersion>.<MessageKey>
bmcweb in certain places has incorrectly used the 3 digit version instead of the 2 digit version. This commit fixes that by modifying the parse_registries script to generate 3 separate struct entries to represent the registry version, and parse them where appropriate.
MessageRegistryFileCollection uses the 3 digit version. No behavior changes. Message/event log entries use the 2 digit version. This will cause a MessageId change from: Base.1.19.0.InternalError to Base.1.19.InternalError
This is a breaking change, so a new option to allow the old behavior is provided.
Tested: Redfish Service validator passes. Heartbeat events on EventService show 2 digit versions.
Change-Id: I4165e994f73e200f13bed8ea76cb58bee2b69faa Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
06b71375 | 02-Dec-2024 |
Ed Tanous <etanous@nvidia.com> |
Remove check_base_registry
We now generate our registries, this script is no longer useful.
Change-Id: I8e0e18e5c9d2683738e67fb318d663ae960f808d Signed-off-by: Ed Tanous <etanous@nvidia.com> |
352945bb | 18-Nov-2024 |
Ed Tanous <etanous@nvidia.com> |
Update base registry keys to 1.19
This has been incorrect for a while now. Update the version string so it's generated automatically.
Tested: Redfish service validator passes Redfish protocol vali
Update base registry keys to 1.19
This has been incorrect for a while now. Update the version string so it's generated automatically.
Tested: Redfish service validator passes Redfish protocol validator passes
Change-Id: I7abaf5c523c82a61331e5d696b498a35c2cf3788 Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
644cdcb8 | 17-Nov-2024 |
Ed Tanous <etanous@nvidia.com> |
Make all ints size_t
We should be consistent when we declare index types. Nlohmann uses an underlying uint64_t as the integer type, so use that for all index types.
Size_t is directly creatable fr
Make all ints size_t
We should be consistent when we declare index types. Nlohmann uses an underlying uint64_t as the integer type, so use that for all index types.
Size_t is directly creatable from it in both 32 and 64 bit modes.
Tested: On last patch in series.
Change-Id: Id1da0e7be2e2046bdbd732247d208b6e9e8c008c Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
f8cca876 | 17-Nov-2024 |
Ed Tanous <etanous@nvidia.com> |
Order by order in DMTF registry
The DMTF registry has a defined order. Previously these were randomly ordered dependent on the hash function used when they were generated years ago.
Functionally t
Order by order in DMTF registry
The DMTF registry has a defined order. Previously these were randomly ordered dependent on the hash function used when they were generated years ago.
Functionally the only change here is to parse_registries.py, to remove the sorting, then to regenerate the files.
Tested: On last patch in series.
Change-Id: I7432c26ec4a1b18acf63ece85500df370f4758d3 Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
7ccfe684 | 16-Nov-2024 |
Ed Tanous <etanous@nvidia.com> |
Generate error messages source
This file has gotten desynced from the standard, and maintaining it is a pain. refactor the parse_registries.py script to generate this file and update all wrong inst
Generate error messages source
This file has gotten desynced from the standard, and maintaining it is a pain. refactor the parse_registries.py script to generate this file and update all wrong instances to the correct types.
To the extent possible, the generated code tries to be replaced with 1:1 identical structures to make review simpler.
Tested: On last patch in series.
Change-Id: Ic203a93fd26e0487475ce82c62beb6a22612368a Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
c87294a6 | 17-Nov-2024 |
Ed Tanous <etanous@nvidia.com> |
Remove InvalidUpload response code
Invalid response is something from the openbmc registry, so it's not a valid thing to return as a response code. For this patch, remove the generated error messag
Remove InvalidUpload response code
Invalid response is something from the openbmc registry, so it's not a valid thing to return as a response code. For this patch, remove the generated error message, and replace the one place it's used with internalError.
Tested: On last patch in series.
Change-Id: I8215935f00923c72fd7763645c06d0b6af73c01d Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
42079ecb | 16-Nov-2024 |
Ed Tanous <etanous@nvidia.com> |
Generate error messages for Redfish
error_messages.hpp and error_messages.cpp were at one time generated. That script has been lost to the sands of time, and since then there's been lots of places w
Generate error messages for Redfish
error_messages.hpp and error_messages.cpp were at one time generated. That script has been lost to the sands of time, and since then there's been lots of places where we've been inconsistent, or updated our base registry without updating the generated code. This causes wording, syntax, and other errors.
This commit updates the script to simply generate this header with the intent of generating it from here on out and avoid issues. As written, goes to great lengths to generate exactly the same code, and make only changes to the doxygen comments, and add the missing types. This is done to allow for easy diffing that nothing important has changed.
Testing on last patch in series.
Change-Id: Ic1da1c02519098bdb53656d94a458b78c67d25bb Signed-off-by: Ed Tanous <etanous@nvidia.com>
show more ...
|
b575caef | 01-Oct-2024 |
Jishnu CM <jishnunambiarcm@duck.com> |
Bump base registry to 1.19.0
Adds GenerateSecretKeyRequired registry to the Base for MFA
Change-Id: Ia690639b4bebbbd265b223bd626b0eb814103f99 Signed-off-by: Jishnu CM <jishnunambiarcm@duck.com> |
dd5c81e9 | 17-Sep-2024 |
Gunnar Mills <gmills@us.ibm.com> |
Update to 2024.3
1 line change in update_schemas.py and rerun it.
See below for more info on this release: https://www.dmtf.org/content/redfish-release-20243-now-available
Tested: Inspection only.
Update to 2024.3
1 line change in update_schemas.py and rerun it.
See below for more info on this release: https://www.dmtf.org/content/redfish-release-20243-now-available
Tested: Inspection only.
Change-Id: I856b9777fd386f828724bd7a521dcd5c8c3270cf Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
28cfceb2 | 22-Aug-2024 |
Gunnar Mills <gmills@us.ibm.com> |
Update to 2024.2
Redfish changed the directory structure again. Don't see that ZipFile has a "cd" so insert the version in the path when checking or building the path.
You can see this directory st
Update to 2024.2
Redfish changed the directory structure again. Don't see that ZipFile has a "cd" so insert the version in the path when checking or building the path.
You can see this directory structure change by downloading 2024.2 vs 2024.1. Also by printing the ZipFile Info.
<ZipInfo filename='DSP8010_2024.2/info.json' compress_type=deflate filemode='-rw-r--r--' file_size=54 compress_size=42>
This is how we used to do it. [1]
[1]: https://github.com/openbmc/bmcweb/commit/60c922dfacd5d1aeec8789e03edc91b47f4a6661
Make the changes for the script, bump the version, and run the script.
See below for more info on this release: https://www.dmtf.org/content/redfish-release-20242-now-available
Tested: Validator is happy.
Change-Id: I87674d5b9ff19b39d3cdf2fb046543e21a6ebc5b Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
99da8c8e | 29-Jul-2024 |
George Liu <liuxiwei@ieisystem.com> |
scripts: csdl-to-json-converter: README.md: Fix MD034 warnings
The following warnings are generated by using markdownlint analysis: ``` MD034/no-bare-urls Bare URL used [Context: "https://github.com
scripts: csdl-to-json-converter: README.md: Fix MD034 warnings
The following warnings are generated by using markdownlint analysis: ``` MD034/no-bare-urls Bare URL used [Context: "https://github.com/openbmc/doc...";] ``` Refer to markdown-lint [1] to fix MD034 [1]: https://github.com/updownpress/markdown-lint/blob/master/rules/034-no-bare-urls.md
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: I85dea378a1f08293b2ef071c949fd184dcc7c015
show more ...
|
ced552a9 | 29-Jul-2024 |
George Liu <liuxiwei@ieisystem.com> |
scripts: csdl-to-json-converter: README.md: Fix MD040 warnings
The following warnings are generated by using markdownlint analysis: ``` MD040/fenced-code-language Fenced code blocks should have a la
scripts: csdl-to-json-converter: README.md: Fix MD040 warnings
The following warnings are generated by using markdownlint analysis: ``` MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] ``` Refer to markdown-lint [1] to fix MD040 [1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: I183c4e220b7fdcec9c235a04dcdd9b4f065863e8
show more ...
|
fdbce79b | 26-Jun-2024 |
Ed Tanous <ed@tanous.net> |
Fix Task Monitor URI
Fixes #272
The TaskMonitor urls we create aren't correct per Redfish. Per DSP0266 section 12.2, our TaskMonitor URIs should take the form
/redfish/v1/TaskService/TaskMonitors
Fix Task Monitor URI
Fixes #272
The TaskMonitor urls we create aren't correct per Redfish. Per DSP0266 section 12.2, our TaskMonitor URIs should take the form
/redfish/v1/TaskService/TaskMonitors/<id>
Note that even though this appears to be a collection, it is not, and does not "exist" in the Redfish schema, hence why it is called out explicitly.
Tested: Started dump collection task with POST ``` /redfish/v1/Managers/bmc/LogServices/Dump/Actions/LogService.CollectDiagnosticData ``` GET /redfish/v1/Tasks/0
Returned TaskMonitor = /redfish/v1/Tasks/TaskMonitors/0
GET /redfish/v1/Tasks/TaskMonitors/0 returned 200
Change-Id: I9fb1d62090f7787d7649c077b748b51ac3202f8a Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|