Add MessageArgs for Redfish messages from the Base registry

Per the Redfish API Specification, the MessageArgs array of
strings is required when using a MessageId for a
parameterized message.

This

Add MessageArgs for Redfish messages from the Base registry

Per the Redfish API Specification, the MessageArgs array of
strings is required when using a MessageId for a
parameterized message.

This change adds the MessageArgs array for the Redfish messages
that we use from the Base message registry.

Tested: Manually set various error types and confirmed that the
MessageArg array was properly displayed.

Change-Id: I2248128f8290305ba3466ef2ce57447ce970a57d
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add automatic range-checking and type-casting for readJson

This change allows numerical types to be passed to readJson
with the desired type. They will then be automatically
range-checked and cast

Add automatic range-checking and type-casting for readJson

This change allows numerical types to be passed to readJson
with the desired type. They will then be automatically
range-checked and cast to that type.

Tested: Requested variables of type uint64_t, uint8_t, int,
int16_t, and int8_t and confirmed that the range was correctly
checked for each.

Change-Id: Ia55cb03ba2c4321a7de35a7c7b566980a72c5449
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Change the BMC LogService to only display from the message registry

This change renames the existing BMC LogService that displays all
entries in the journal to a BMC Journal LogService.

The new sta

Change the BMC LogService to only display from the message registry

This change renames the existing BMC LogService that displays all
entries in the journal to a BMC Journal LogService.

The new standard BMC LogService is modified to only display messages
from the registry. The registry MessageId and MessageArgs must
be included in the journal metadata as "REDFISH_MESSAGE_ID" and
"REDFISH_MESSAGE_ARG_<x>" respectively, where <x> is the arg
number from the registry.

Change-Id: I4556cbea5032ec639ad1fda084571144defe23dc
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add the Redfish message registries

This change adds the message registries used by bmcweb.

It includes the OEM OpenBMC.0.1.0 message registry and the
DMTF Base.1.4.0 message registry for reference.

Add the Redfish message registries

This change adds the message registries used by bmcweb.

It includes the OEM OpenBMC.0.1.0 message registry and the
DMTF Base.1.4.0 message registry for reference.

Tested: Ran the Redfish Service Validator and got passing
results for the MessageRegistryCollection and the two
MessageRegsitryFiles.

Change-Id: I3e5756103006f065530253b5dbc0d7720cf616b9
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add helper functions to get data from the journal

This change adds helper functions to simplify getting
metadata, IDs, and timestamps from the journal.

Change-Id: Icb8a08b52f7311e6471238fe90bfc4d7c

Add helper functions to get data from the journal

This change adds helper functions to simplify getting
metadata, IDs, and timestamps from the journal.

Change-Id: Icb8a08b52f7311e6471238fe90bfc4d7cae55ecd
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Simplify Redfish error message property interface

The error message code used a json_pointer object which must
begin with a '/' character and had to be sent as an extra
parameter. This change simpl

Simplify Redfish error message property interface

The error message code used a json_pointer object which must
begin with a '/' character and had to be sent as an extra
parameter. This change simplifies the interface by using a
string so there doesn't have to be a '/'. This allowed the
same property argument passed for the message to be used
for the property field path.

Tested: Sent an error with a property and verified that it is
correctly displayed.

Change-Id: I0571e2eee627cedf29d751588a4f1bceee66f084
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add VlanInterface patch back

A merge conflict deleted the VLAN. Add it back to the main flow.

Change-Id: Ie0f5d61a9377b7f2a0e89ca5b00e54e2d32c2df8
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

Initial implementation of processors and memory schema

This is an initial implementations of GET methods for
several schemas:

* ProcessorCollection
* Processor
* MemoryCollection
* Memory

It fetch

Initial implementation of processors and memory schema

This is an initial implementations of GET methods for
several schemas:

* ProcessorCollection
* Processor
* MemoryCollection
* Memory

It fetches data from Smbios service.

Tested:
* Compiance report
* Manual walk through selected schemas.

Change-Id: I11e00d0982248f2307e24b9a246ac60672dda8a1
Signed-off-by: Rapkiewicz, Pawel <pawel.rapkiewicz@intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Managers: Actions object: Support Reset property

cherry-picked from:
https://github.com/ampere-openbmc/bmcweb/commit/dfb534ab5db1bb0bcdc9a6519f1e1ccfede6f363

Add URI of Reset Actions:
/redfish/v1/

Managers: Actions object: Support Reset property

cherry-picked from:
https://github.com/ampere-openbmc/bmcweb/commit/dfb534ab5db1bb0bcdc9a6519f1e1ccfede6f363

Add URI of Reset Actions:
/redfish/v1/Managers/openbmc/Actions/Manager.Reset for handling the HTTP POST
method.

We're only able to issue GracefulRestart for OpenBMC therefore the
bmcweb supports for ResetType property with "GracefulRestart" value.

Tested: Using redfishtool command to test:
python3 redfishtool.py -A Basic -S Always --rhost=$bmc_ip -u $bmc_user
-p $bmc_password -d '{"ResetType": "GracefulRestart"}' raw POST
/redfish/v1/Managers/openbmc/Actions/Manager.Reset

Change-Id: I2bbc172d43c3244cc304934618c0c5d1e21d9c08
Signed-off-by: Jennifer Lee <jennifer1.lee@intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

bmcweb: fix a possible buffer overflow issue

This commit fixes a possible buffer overflow that could occur if dbus
paths don't follow the dbus specification.

Change-Id: Ib3c5d4743b1ac7f65a480a88613

bmcweb: fix a possible buffer overflow issue

This commit fixes a possible buffer overflow that could occur if dbus
paths don't follow the dbus specification.

Change-Id: Ib3c5d4743b1ac7f65a480a88613267ec0b4b7c2b
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Update Redfish to Base.1.4.0 message registry

Update the Redfish error_messages from Base.1.2.0 to Base.1.4.0
from the Redfish standard registries.

Change-Id: I771b119372fd995bd1dc4065830485b6a848f

Update Redfish to Base.1.4.0 message registry

Update the Redfish error_messages from Base.1.2.0 to Base.1.4.0
from the Redfish standard registries.

Change-Id: I771b119372fd995bd1dc4065830485b6a848f086
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Update formatting of error string literals and message descriptions

clang-format doesn't automatically merge multi-line string
literals, so this change updates the formatting to merge some
multi-lin

Update formatting of error string literals and message descriptions

clang-format doesn't automatically merge multi-line string
literals, so this change updates the formatting to merge some
multi-line strings into fewer lines.

This change also corrects the <argx> numbering in the error message
descriptions to match the function parameter numbers.

Change-Id: Ibedcaf5793a607acacdb3bc83081599ba508c989
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Fix a bug in optional json parsing

A small logic error caused bugs in the required-ness of optional params.
In the error case, a bad_request return code would be returned with no
error message. Thi

Fix a bug in optional json parsing

A small logic error caused bugs in the required-ness of optional params.
In the error case, a bad_request return code would be returned with no
error message. This commit allows the request to suceed unharmed.

Change-Id: I1c1cbaf08e79bc1f52485ae12d73701d74e0e2aa
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

bmcweb: merge conflict resolution

Merge conflict in: Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the http status and JSON

bmcweb: merge conflict resolution

Merge conflict in: Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the http status and JSON content in the response object.

When using an AsyncResp object, this allows for simply calling
the Redfish error and returning.

Change-Id: I3b37cce1e7f603c0b4cc74a16f8f00da9a7f1373
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Chassis: Power: Support get PowerSupply and Voltages
sensors information.

cherry-picked from:
https://github.com/ampere-openbmc/bmcweb/commit/a20f8b17c1efb92b9a8e95e8867d945bc6177804

Sensor module

Chassis: Power: Support get PowerSupply and Voltages
sensors information.

cherry-picked from:
https://github.com/ampere-openbmc/bmcweb/commit/a20f8b17c1efb92b9a8e95e8867d945bc6177804

Sensor module adds sensorType:"power" to retrieve power supply sensor
information.
This applicable to Power schema version 1.2.1

Limit:
- Not retrieve PowerControl information yet.
- Need to get UpperThresholdFatal and LowerThresholdFatal value.

Tested: Browser and redfishtool
Command test: redfishtool -A Basic -S Always --rhost=$bmc_ip -u
$bmc_user -p $bmc_password Chassis -I 1 Power

Redmine ID: #2145.

Change-Id: Ifd4a7495c216f894f46610c02d3e8a8e3988dfaa
Signed-off-by: Tung Vu <tung.vu@amperecomputing.com>

Chassis: Thermal and Power: Correct @odata.id information

cherry-picked from:
https://github.com/ampere-openbmc/bmcweb/commit/ae95b0db60e5e680819c9f9b0c6d61caf66b14cf

Allocate @odata.id of schema in correct way.
Sensor module is general interface not used for specific schema.

Tested: Browser and redfishtool
Command test:
- redfishtool -A Basic -S Always --rhost=$bmc_ip -u $bmc_user -p
$bmc_password Chassis -I 1 Power
- redfishtool -A Basic -S Always --rhost=$bmc_ip -u $bmc_user -p
$bmc_password Chassis -I 1 Thermal

Redmine ID: #2145 & #2146

Change-Id: I265bbb366c323f39fb6d4ac4f7cccfed4382e98d
Signed-off-by: Tung Vu <tung.vu@amperecomputing.com>

Chassis: Correct @odata.id for specific Chassis sub-node.

cherry-picked from:
https://github.com/ampere-openbmc/bmcweb/commit/3eaa53a395ad9275042893413cbefc78f52310e5

Currently there are Thermal and Power sub-nodes of Chassis node, correct
@odata.id information for each sub-node in JSON payload.

Tested: Browser and redfishtool
Command test:
- redfishtool -A Basic -S Always --rhost=$bmc_ip -u $bmc_user -p
$bmc_password Chassis Thermal -I 1
- redfishtool -A Basic -S Always --rhost=$bmc_ip -u $bmc_user -p
$bmc_password Chassis Power -I 1

Change-Id: I2f831ed40926e85c0b6d1cfa7d759eb0b9321daa
Signed-off-by: Tung Vu <tung.vu@amperecomputing.com>
Signed-off-by: Jennifer Lee <jennifer1.lee@intel.com>

show more ...

Add PID Patch

This allows runtime modifying Pid configurations
and zones.

Tested by:
Sent PATCH for:
Modify FanController
Modify FanZone
New FanController
New FanZone
Modify PidController
New PidCo

Add PID Patch

This allows runtime modifying Pid configurations
and zones.

Tested by:
Sent PATCH for:
Modify FanController
Modify FanZone
New FanController
New FanZone
Modify PidController
New PidController
Delete FanController
Delete FanZone

Change-Id: Ie2dd52ea0b09dc4ad1ed016ec4c27b3c39be28de
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add paging and partial results for BMCLogService

Since BMC logs can be very large and may take some time
to load, the browser could time out during the request.

This change adds partial results sup

Add paging and partial results for BMCLogService

Since BMC logs can be very large and may take some time
to load, the browser could time out during the request.

This change adds partial results support for those logs
using the $skip and $top redfish query parameters so only
up to 1000 are printed at a time with a link to get the next
1000 if they exist.

Tested: Loaded a log with more than 1000 entries and confirmed
that $skip entries are skipped and only $top (up to 1000) are
loaded. Also verified that the nextLink property correctly
points to the next set of log entries.

Change-Id: I0a586524a8aab47b9ab457e1d3f56a8b6d97a700
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Speed up managers schema

PID was doing every query 8x times.

Change-Id: I11fa064c2f9c416fe15fdfb15c63a6490f0b68dd
Signed-off-by: James Feist <james.feist@linux.intel.com>

Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the http status and JSON content in the response object.

When using an AsyncRe

Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the http status and JSON content in the response object.

When using an AsyncResp object, this allows for simply calling
the Redfish error and returning.

Change-Id: Icfdce2de763225f070e8dd61e591f296703f46bb
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Implement a new way of unpacking json to structs

The existing way of decoding json structures, while fast has some disadvantages.
1. it's very verbose to write.
2. It requires in depth knowlege of r

Implement a new way of unpacking json to structs

The existing way of decoding json structures, while fast has some disadvantages.
1. it's very verbose to write.
2. It requires in depth knowlege of redfish error messages to get
correct.
3. It _can_ lead to undesired behavior, like half of a patch being
applied, if only some of the values have bad types.

This commit implements a new interface for decoding redfish json
named.... readJson. It is a templated function, that lets you decode
json values based on type easily, while still handling all the correct
error codes that were handled previously. Use is done similar to the
example below:

std::string required;
boost::optional<std::string> optional;
if (!json_util::readJson(req, res, "OptionalParam", optional,
"RequiredParam", required))
{
return;
}

if (optional){
// optional param was given, take action.
}

As part of this patchset, the systems schema is moved to the new
interface, which deletes some of the code involved and shows the
improvement in clarity.

Change-Id: I041a97c84d294df8cd4de4c2702e5ee22c0bc120
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Clean up SessionService POST

Previously, SessionService would return a json decode error for all
errors, even if certain keys were incorrect. This updates the POST
handler to use a better method, a

Clean up SessionService POST

Previously, SessionService would return a json decode error for all
errors, even if certain keys were incorrect. This updates the POST
handler to use a better method, and should reduce the binary size a
little, given that we're removing the possibly throwing get<> code.

This needs a very good review. This endpoint is available pre-auth, and
needs to be secure regardless of input.

Tested By:
curl --noproxy "*" -k -X POST -d '{"UserName": "root", "Password":
"0penBmc"}' https://10.243.48.30/redfish/v1/SessionService/Sessions/
Returns correct response.
Tested several variations, including extra parameters, missing username,
missing password, ect. Got correct error code in all cases.

Change-Id: Ic8e6edd9f7badc0d22aa8dafa9c0c260386712ac
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Add a BMC LogService

Adds a redfish LogService that provides the contents of the
BMC journald instance available over readfish.

This should be considered a prototype at this time, and suggestions o

Add a BMC LogService

Adds a redfish LogService that provides the contents of the
BMC journald instance available over readfish.

This should be considered a prototype at this time, and suggestions on
how this could be done better are welcome.

At some point in the future, we could make this available over the
redfish TaskService via SSE.

Change-Id: Ibca0d473dcef545763256cc1df5574571a3af414
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Implement fan PWM reading through redfish

This patchset implements the ability to be able to read the PWM output
values from redfish under the Thermal schema. to be able to map fan
outputs to redfis

Implement fan PWM reading through redfish

This patchset implements the ability to be able to read the PWM output
values from redfish under the Thermal schema. to be able to map fan
outputs to redfish.

Change-Id: I858d81ef61183722390a073fa925416d17da5fec
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Redfish: Fixed incorrect firmware ID strings

Fixes: https://github.com/openbmc/bmcweb/issues/4

It was probably caused by incorrect merging, and that messed up the
logic of the code. Fixed it so th

Redfish: Fixed incorrect firmware ID strings

Fixes: https://github.com/openbmc/bmcweb/issues/4

It was probably caused by incorrect merging, and that messed up the
logic of the code. Fixed it so the Firmware Collection and Firmware
response reflects correct information.

Signed-off-by: Jennifer Lee <jennifer1.lee@intel.com>
Change-Id: I749a0af804cfa3e5cce89d1b8e11ec09d00d818d

show more ...

Redfish Rename LogService variables

To match naming convention.

Change-Id: I18371e7c605c03eaade5e3c00d2852c95ffa751a
Signed-off-by: Ed Tanous <ed.tanous@intel.com>