bmcweb: merge conflict resolution

Merge conflict in: Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the h

bmcweb: merge conflict resolution

Merge conflict in: Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the http status and JSON content in the response object.

When using an AsyncResp object, this allows for simply calling
the Redfish error and returning.

Change-Id: I3b37cce1e7f603c0b4cc74a16f8f00da9a7f1373
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Add PID Patch

This allows runtime modifying Pid configurations
and zones.

Tested by:
Sent PATCH for:
Modify FanController
Modify FanZone
New FanController
Ne

Add PID Patch

This allows runtime modifying Pid configurations
and zones.

Tested by:
Sent PATCH for:
Modify FanController
Modify FanZone
New FanController
New FanZone
Modify PidController
New PidController
Delete FanController
Delete FanZone

Change-Id: Ie2dd52ea0b09dc4ad1ed016ec4c27b3c39be28de
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Speed up managers schema

PID was doing every query 8x times.

Change-Id: I11fa064c2f9c416fe15fdfb15c63a6490f0b68dd
Signed-off-by: James Feist <james.feist@linux.intel.com>

Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the http status and JSON content in the response object.

W

Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the http status and JSON content in the response object.

When using an AsyncResp object, this allows for simply calling
the Redfish error and returning.

Change-Id: Icfdce2de763225f070e8dd61e591f296703f46bb
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add PID Get To Redfish

Add doGet to managers for PID configuration data.
Make sure passes schema validation.

Change-Id: Ieeb97bf76a3d8a3c06f59f79cc0887aec746675e
Signed-off-

Add PID Get To Redfish

Add doGet to managers for PID configuration data.
Make sure passes schema validation.

Change-Id: Ieeb97bf76a3d8a3c06f59f79cc0887aec746675e
Signed-off-by: James Feist <james.feist@linux.intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Ampere bmcweb: Add Firmware Version to Managers Schema

cherry-picked from:
https://github.com/ampere-openbmc/bmcweb/commit/a92abc99ac6831499ed362aa8e2d14cfe2d99e48

Change-Id: I

Ampere bmcweb: Add Firmware Version to Managers Schema

cherry-picked from:
https://github.com/ampere-openbmc/bmcweb/commit/a92abc99ac6831499ed362aa8e2d14cfe2d99e48

Change-Id: Ie817d8b3aab765e1e9a948c1d3de91cfca1f31ad
Signed-off-by: Tung Vu <tung.vu@amperecomputing.com>
Signed-off-by: Jennifer Lee <jennifer1.lee@intel.com>

Ampere: Correct Cpp coding style on previous commit

Limit column of a line to 80 characters.

cherry-picked from:
https://github.com/ampere-openbmc/bmcweb/commit/7065ea3e9179a6ec5f294e21e6028ed15637262c

Change-Id: I1d8f2cf84ee48f9d4af5176858be00aa6a4f582d
Signed-off-by: Chuong Tran <chuong.tran@amperecomputing.com>
Signed-off-by: Jennifer Lee <jennifer1.lee@intel.com>

Ampere bmcweb: Managers: Add ManagerType property.

Add ManagerType property to "BMC" type.

cherry-picked from:
https://github.com/ampere-openbmc/bmcweb/commit/d589325ed7c5da2f3468ac0d105cfecc6405528a

Tested: Browser and redfishtool
Command test: redfishtool -A Basic -S Always --rhost=$bmc_ip -u
$bmc_user -p $bmc_password Managers -I openbmc

Redmine ID: #2026

Change-Id: I2cee251aa1b47fd06148f96b6b4fba018e0e5f1f
Signed-off-by: Tung Vu <tung.vu@amperecomputing.com>
Signed-off-by: Jennifer Lee <jennifer1.lee@intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Move to clang-format-6.0

This commit moves the codebase to the lastest clang-format file from
upstream, as well as clang-format-6.0.

Change-Id: Ice8313468097c0c42317fbb9e10ddf03

Move to clang-format-6.0

This commit moves the codebase to the lastest clang-format file from
upstream, as well as clang-format-6.0.

Change-Id: Ice8313468097c0c42317fbb9e10ddf036e8cff4c
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Fix merge conflict

Got a couple patches that collided in air, and now builds are broken.
This resolves the collision by moving the new patches forward to the
latest #defines

Fix merge conflict

Got a couple patches that collided in air, and now builds are broken.
This resolves the collision by moving the new patches forward to the
latest #defines

Change-Id: I1fe35d17a68c61ad90752ae73000e2579131bf5d
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Fix crash issue with Managers schema

The bmc was initing two copies of the managers route, which was causing
the route handler to crash at startup. Remove the extra one.

Jul 26

Fix crash issue with Managers schema

The bmc was initing two copies of the managers route, which was causing
the route handler to crash at startup. Remove the extra one.

Jul 26 20:39:50 wolfpass systemd[1]: Started Start bmcweb server.
Jul 26 20:39:50 wolfpass bmcweb[3279]: terminate called after throwing
an instance of 'std::runtime_error'
Jul 26 20:39:50 wolfpass bmcweb[3279]: what(): handler already exists
for /redfish/v1/Managers/openbmc

Change-Id: Id2c469b5e82bddc68987f89f0eff23072b16854c
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Move over to upstream c++ style

This patchset moves bmcweb over to the upstream style naming
conventions for variables, classes, and functions, as well as imposes
the latest clang-fo

Move over to upstream c++ style

This patchset moves bmcweb over to the upstream style naming
conventions for variables, classes, and functions, as well as imposes
the latest clang-format file.

This changeset was mostly built automatically by the included
.clang-tidy file, which has the ability to autoformat and auto rename
variables. At some point in the future I would like to see this in
greater use, but for now, we will impose it on bmcweb, and see how it
goes.

Tested: Code still compiles, and appears to run, although other issues
are possible and likely.

Change-Id: If422a2e36df924e897736b3feffa89f411d9dac1
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Boost beast

This commit is the beginings of attempting to transition away from
crow, and toward boost::beast. Unit tests are passing, and
implementation appears to be slightly faste

Boost beast

This commit is the beginings of attempting to transition away from
crow, and toward boost::beast. Unit tests are passing, and
implementation appears to be slightly faster than crow.

Change-Id: Ic8d946dc7a04f514c67b1098f181eee1ced69171

show more ...

Enabling Ethernet Interfaces, and Ethernet Interfaces Collection Schemas

Commit provides Schemas for:
* Single Eth Interface (GET)
* Eth Interface Collection (GET)

Both are

Enabling Ethernet Interfaces, and Ethernet Interfaces Collection Schemas

Commit provides Schemas for:
* Single Eth Interface (GET)
* Eth Interface Collection (GET)

Both are using EthernetProvider, which delivers data
available from xyz.openbmc_project.Network

It was tested:
* Regression (no regression in web server behaviour)
* Memory Leaks (no leaks detected via valgrind)
* Compiling multiple arch (x86, ASPEED)
* Service Validator pass all available schemas

Change-Id: Idee321cb294f48b59f7740512bbe416cf10236c0
Signed-off-by: Rapkiewicz, Pawel <pawel.rapkiewicz@intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Minor fixes to make redfish pass compliance tests

1. Role members needs to be an array, not an object
2. Fix accounts schema to use the new user manager
3. Remove "status" field hard

Minor fixes to make redfish pass compliance tests

1. Role members needs to be an array, not an object
2. Fix accounts schema to use the new user manager
3. Remove "status" field hardcodes
4. Hardcode chassisType to rackmount for now
5. Work around bug in get sub routes
6. Add ID to SessionService Schema

Change-Id: Ibb13d6ace747ac028e840638868c3a01d65dedfa
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Make a few changes to privileges commit

1. Create char* overloads for the things that need it.
2. Fix up a couple errant moves
3. Use the gtest APIs for testing container membership,

Make a few changes to privileges commit

1. Create char* overloads for the things that need it.
2. Fix up a couple errant moves
3. Use the gtest APIs for testing container membership, rather than sort
4. Move the index management to vector rather than map to avoid a lookup
5. Remove errant use of .at()
6. Move privilege comparison into the privilege class, in order to keep
the bitset implementation private. This removes the requirment on the
forward declaration of PrivilegeProvider, and the use of friend class
7. Remove unimplemented override strcutures. Feel free to add them
back once implemented
8. Make setSignlePrivilege return a code if the set failed
9. Remove the need for an extra construction of a blank privileges
object for things that require no privileges.

Tested by: updating unit tests with the appropriate APIs. Relevant
unit tests pass

Change-Id: Ie9cde003b6c865979b4cac086379d0a3473896ce
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Redfish Manager and ManagerCollection

Node version of the Manager and ManagerCollection implementation.

Change-Id: I693fa57add670fb0ecfc0cf0046e06142571c543
Signed-off-by: B

Redfish Manager and ManagerCollection

Node version of the Manager and ManagerCollection implementation.

Change-Id: I693fa57add670fb0ecfc0cf0046e06142571c543
Signed-off-by: Borawski.Lukasz <lukasz.borawski@intel.com>

show more ...